)]}'
{"announce.sh":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e87ab14d54dcf265abadf2a4589e7fc4e4aae3bb","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"relnotes_file\u003d\"$RELNOTESDIR/$SHORTNAME-$VERSION\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# If we don\u0027t have a setup.py use the current directory name asn the library"},{"line_number":164,"context_line":"# name so the email template makes sense."},{"line_number":165,"context_line":"if [ -e setup.py ] ; then"},{"line_number":166,"context_line":"    # Some projects have setup_requires dependencies on packages that are"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_323c20e2","line":163,"range":{"start_line":163,"start_character":61,"end_line":163,"end_character":64},"updated":"2016-11-16 01:49:39.000000000","message":"(s/asn/as)","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1c345c9f8997169f74f503c29fba96f620b65386","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"relnotes_file\u003d\"$RELNOTESDIR/$SHORTNAME-$VERSION\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# If we don\u0027t have a setup.py use the current directory name asn the library"},{"line_number":164,"context_line":"# name so the email template makes sense."},{"line_number":165,"context_line":"if [ -e setup.py ] ; then"},{"line_number":166,"context_line":"    # Some projects have setup_requires dependencies on packages that are"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_4d801d47","line":163,"range":{"start_line":163,"start_character":61,"end_line":163,"end_character":64},"in_reply_to":"7a77a97e_323c20e2","updated":"2016-11-16 01:53:27.000000000","message":"Done","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3604460a686710f44b9f3f3fb63ac55205ed68d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    echo \"Priming setup_requires packages\""},{"line_number":171,"context_line":"    python setup.py --name"},{"line_number":172,"context_line":"else"},{"line_number":173,"context_line":"    with_library_name\u003d\"--library-name $(basename $(pwd))\""},{"line_number":174,"context_line":"fi"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_d80854dc","line":173,"updated":"2016-11-16 13:17:49.000000000","message":"Is this a valid assumption, or do we need different ways to get the names of things based on the metadata format used for packaging the language they\u0027re written in? It\u0027s definitely a start, so it\u0027s better than failing, I\u0027m just wondering how often it\u0027s going to be inaccurate.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6ef07e461dc061dd5b41440234d5e92a18ef710a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    echo \"Priming setup_requires packages\""},{"line_number":171,"context_line":"    python setup.py --name"},{"line_number":172,"context_line":"else"},{"line_number":173,"context_line":"    with_library_name\u003d\"--library-name $(basename $(pwd))\""},{"line_number":174,"context_line":"fi"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_b862f6d6","line":173,"in_reply_to":"7a77a97e_d80854dc","updated":"2016-12-13 06:15:08.000000000","message":"A look at all the repos currently mentioned in deliverables/* indicates that exactly 1 would be incorrect.  In the openstack/puppet-tripleo is really openstack-tripleo.  So the false positives that we generate email about would be low.\n\nWe could of course grow support for extracting the name from package.json or metata.json and that would reduce that further but yes to be more accurate we\u0027d need to grow custom support per language.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e87ab14d54dcf265abadf2a4589e7fc4e4aae3bb","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    $first_release \\"},{"line_number":185,"context_line":"    . \"$DIFF_START\" \"$VERSION\" \\"},{"line_number":186,"context_line":"    $include_pypi_link \\"},{"line_number":187,"context_line":"    $with_library_name \\"},{"line_number":188,"context_line":"    | tee $relnotes_file"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_d2020c0b","line":187,"range":{"start_line":187,"start_character":5,"end_line":187,"end_character":22},"updated":"2016-11-16 01:49:39.000000000","message":"(nit) this will be unset for python packages","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1c345c9f8997169f74f503c29fba96f620b65386","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    $first_release \\"},{"line_number":185,"context_line":"    . \"$DIFF_START\" \"$VERSION\" \\"},{"line_number":186,"context_line":"    $include_pypi_link \\"},{"line_number":187,"context_line":"    $with_library_name \\"},{"line_number":188,"context_line":"    | tee $relnotes_file"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_6ddeb96e","line":187,"range":{"start_line":187,"start_character":5,"end_line":187,"end_character":22},"in_reply_to":"7a77a97e_d2020c0b","updated":"2016-11-16 01:53:27.000000000","message":"Yeah, but we do the same thing for $include_pypi_link so I figured I could get away with it ;P","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f111d6e9bb5745c69dfe621ed915c1adf0a5d0b6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    $first_release \\"},{"line_number":187,"context_line":"    . \"$library_name\" \"$DIFF_START\" \"$VERSION\" \\"},{"line_number":188,"context_line":"    $include_pypi_link \\"},{"line_number":189,"context_line":"    --description \"$description\" \\"},{"line_number":190,"context_line":"    | tee $relnotes_file"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"echo"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a6eadb0_2f866213","line":189,"range":{"start_line":189,"start_character":20,"end_line":189,"end_character":31},"updated":"2016-12-14 07:25:46.000000000","message":"(noting this passes through an empty string.. the template if block will match False for empty strings so the formatting is still correct)","commit_id":"c913609e040a2cdc7ed72bbf40d7d0edcf98ad8d"}],"releasetools/cmds/release_notes.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e87ab14d54dcf265abadf2a4589e7fc4e4aae3bb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        action\u003d\u0027store_true\u0027,"},{"line_number":67,"context_line":"                        help\u003d\"this is a stable release\","},{"line_number":68,"context_line":"                        )"},{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_6d6959be","line":69,"updated":"2016-11-16 01:49:39.000000000","message":"This implies it will take precedence over setup.py which is not true in release_notes.py","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6ef07e461dc061dd5b41440234d5e92a18ef710a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        action\u003d\u0027store_true\u0027,"},{"line_number":67,"context_line":"                        help\u003d\"this is a stable release\","},{"line_number":68,"context_line":"                        )"},{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_58f802e6","line":69,"in_reply_to":"7a77a97e_38a4e8a4","updated":"2016-12-13 06:15:08.000000000","message":"Sure.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3604460a686710f44b9f3f3fb63ac55205ed68d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        action\u003d\u0027store_true\u0027,"},{"line_number":67,"context_line":"                        help\u003d\"this is a stable release\","},{"line_number":68,"context_line":"                        )"},{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_38a4e8a4","line":69,"in_reply_to":"7a77a97e_6d6959be","updated":"2016-11-16 13:17:49.000000000","message":"Why don\u0027t we make this a required name argument and have the wrapper always pass it.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1c345c9f8997169f74f503c29fba96f620b65386","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"},{"line_number":73,"context_line":"                        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    email_group \u003d parser.add_argument_group(\u0027email settings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_0d3b859d","line":72,"updated":"2016-11-16 01:53:27.000000000","message":"What about:\n\n \"Provide the Library name.  Only used when setup.py isn\u0027t available\"\n\n?","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d25cf3a45e9166941ed92ba22999b4afa00a95bf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"},{"line_number":73,"context_line":"                        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    email_group \u003d parser.add_argument_group(\u0027email settings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_182c0998","line":72,"in_reply_to":"7a77a97e_086773e9","updated":"2016-11-18 19:41:00.000000000","message":"I was hoping to avoid having 2 places where we have logic to figure out how to get the name of a thing.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"e00b29b1b41ec848f33b0fd2dc0c94292329766e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    parser.add_argument(\u0027--library-name\u0027,"},{"line_number":70,"context_line":"                        action\u003d\u0027store\u0027,"},{"line_number":71,"context_line":"                        help\u003d(\u0027Provide the Library name rather than calling \u0027"},{"line_number":72,"context_line":"                              \u0027setup.py to get it\u0027),"},{"line_number":73,"context_line":"                        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    email_group \u003d parser.add_argument_group(\u0027email settings\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_086773e9","line":72,"in_reply_to":"7a77a97e_0d3b859d","updated":"2016-11-18 09:09:40.000000000","message":"Why not let it take precedence? ie, use the library-name if supplied. If not, try setup.py. If that fails, raise an error?","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f111d6e9bb5745c69dfe621ed915c1adf0a5d0b6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                        help\u003d\"library directory, for example\""},{"line_number":26,"context_line":"                             \" \u0027openstack/cliff\u0027\","},{"line_number":27,"context_line":"                        )"},{"line_number":28,"context_line":"    parser.add_argument(\u0027library_name\u0027, action\u003d\u0027store\u0027,"},{"line_number":29,"context_line":"                        help\u003d\u0027The name of the library being released\u0027,"},{"line_number":30,"context_line":"                        )"},{"line_number":31,"context_line":"    parser.add_argument(\"start_revision\", metavar\u003d\u0027revision\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_af16f2ee","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":10},"updated":"2016-12-14 07:25:46.000000000","message":"(noting this changes the usage.. I assume nobody else is really running the script though)","commit_id":"c913609e040a2cdc7ed72bbf40d7d0edcf98ad8d"}],"releasetools/release_notes.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3604460a686710f44b9f3f3fb63ac55205ed68d","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if os.path.isfile(os.path.join(library_path, \"setup.py\")):"},{"line_number":266,"context_line":"        # Get the python library/program description..."},{"line_number":267,"context_line":"        cmd \u003d [sys.executable, \u0027setup.py\u0027, \u0027--description\u0027]"},{"line_number":268,"context_line":"        stdout, stderr \u003d run_cmd(cmd, cwd\u003dlibrary_path)"},{"line_number":269,"context_line":"        description \u003d stdout.strip()"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_98c09c2c","line":267,"updated":"2016-11-16 13:17:49.000000000","message":"Should we pass this in from the wrapper script, too? I\u0027d rather we only have one place with language-specific logic.","commit_id":"a4f0e798f9245753621fc7c61fdfccaff470bce4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f111d6e9bb5745c69dfe621ed915c1adf0a5d0b6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                           email_to, email_reply_to, email_tags,"},{"line_number":227,"context_line":"                           include_pypi_link,"},{"line_number":228,"context_line":"                           changes_only,"},{"line_number":229,"context_line":"                           first_release,"},{"line_number":230,"context_line":"                           library_name, description"},{"line_number":231,"context_line":"                           ):"},{"line_number":232,"context_line":"    \"\"\"Return the text of the release notes."},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ef08eadb","line":230,"range":{"start_line":229,"start_character":41,"end_line":230,"end_character":52},"updated":"2016-12-14 07:25:46.000000000","message":"(the arbitrary line breaks here bother me ;p)","commit_id":"c913609e040a2cdc7ed72bbf40d7d0edcf98ad8d"}]}
