)]}'
{"openstack_releases/cmds/list_changes.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"842a33e54191790f990c5eefd2efca8563b2aac9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    :param title: A header to print before dumping results (if return_output"},{"line_number":62,"context_line":"                  is False). If not provided, the file_pattern and git_range is"},{"line_number":63,"context_line":"                  used for a generic header."},{"line_number":64,"context_line":"    :param return_output: Specify True if you the output from the git diff"},{"line_number":65,"context_line":"                  command should be returned to the caller, else it\u0027s dumped"},{"line_number":66,"context_line":"                  to stdout by default."},{"line_number":67,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_93632ddc","line":64,"updated":"2016-02-11 16:01:05.000000000","message":"I think I\u0027d prefer to just have this function always return the output, and let the caller decide what to do with it. That eliminates the need for the last 2 args. You could create a show_git_diff() function to avoid duplicating the title, get, print calls if those are used in a bunch of places.","commit_id":"befe639d7d61c3645a583c716222834270390991"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2faa01113304e6c7abcd461f688d09e05fefaccf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    :param title: A header to print before dumping results (if return_output"},{"line_number":62,"context_line":"                  is False). If not provided, the file_pattern and git_range is"},{"line_number":63,"context_line":"                  used for a generic header."},{"line_number":64,"context_line":"    :param return_output: Specify True if you the output from the git diff"},{"line_number":65,"context_line":"                  command should be returned to the caller, else it\u0027s dumped"},{"line_number":66,"context_line":"                  to stdout by default."},{"line_number":67,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_c9a8117a","line":64,"in_reply_to":"3a57f1b5_93632ddc","updated":"2016-02-11 18:37:53.000000000","message":"Sure, but then do you always print the title / header even if there are no file matches for the pattern glob? It\u0027s not the end of the world if you do I guess and there are no results.","commit_id":"befe639d7d61c3645a583c716222834270390991"}]}