)]}'
{"openstack_releases/governance.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a91f58526aee71228441ad161dc826f7bf4cee22","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def __init__(self, name, data):"},{"line_number":52,"context_line":"        self.name \u003d name"},{"line_number":53,"context_line":"        self.data \u003d data"},{"line_number":54,"context_line":"        self.ptl \u003d data.get(\u0027ptl\u0027, {})"},{"line_number":55,"context_line":"        self.deliverables \u003d {"},{"line_number":56,"context_line":"            dn: Deliverable(dn, di, self)"},{"line_number":57,"context_line":"            for dn, di in self.data.get(\u0027deliverables\u0027, {}).items()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0ca801db","line":54,"updated":"2016-07-14 01:43:33.000000000","message":"This is largely theoretical but if the data is missing a ptl key then this default value will cause the print statement (added in list_changes) to raise a KeyError and abort.\n\nWe can either set the default to something like:\n\n self.ptl \u003d data.get(\u0027ptl\u0027, {\u0027name\u0027: \u0027MISSING\u0027, \u0027irc\u0027:\u0027MISSING\u0027})\n\nand carry on or just directly reference the PTL and trust the projects.yaml is always correct.","commit_id":"1c28ab77526ee939e176be65a0be4201b0c3d4c1"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"247ee1ef76fc78b694a0399e29eee3afe84395f5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def __init__(self, name, data):"},{"line_number":52,"context_line":"        self.name \u003d name"},{"line_number":53,"context_line":"        self.data \u003d data"},{"line_number":54,"context_line":"        self.ptl \u003d data.get(\u0027ptl\u0027, {})"},{"line_number":55,"context_line":"        self.deliverables \u003d {"},{"line_number":56,"context_line":"            dn: Deliverable(dn, di, self)"},{"line_number":57,"context_line":"            for dn, di in self.data.get(\u0027deliverables\u0027, {}).items()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_31260269","line":54,"in_reply_to":"1aa78d24_0ca801db","updated":"2016-07-18 10:27:25.000000000","message":"I agree this is theoretical and I don think we have projects without PTL or irc info.","commit_id":"1c28ab77526ee939e176be65a0be4201b0c3d4c1"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"9bf44e3a141369831181f13eea087c38831a8297","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027name\u0027: \u0027MISSING\u0027,"},{"line_number":59,"context_line":"            \u0027irc\u0027: \u0027MISSING\u0027,"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        self.ptl.update(data.get(\u0027ptl\u0027, {}))"},{"line_number":62,"context_line":"        self.deliverables \u003d {"},{"line_number":63,"context_line":"            dn: Deliverable(dn, di, self)"},{"line_number":64,"context_line":"            for dn, di in self.data.get(\u0027deliverables\u0027, {}).items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2b449d19","line":61,"updated":"2016-07-24 19:41:33.000000000","message":"I like it :)","commit_id":"2b5c5298fa623e2dd4aa0411e5212680c7d50d8e"}]}