)]}'
{"openstack_releases/cmds/validate.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ae49f48a9d953a2a07c6555251b7aea9360bdc5a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                                    print(\u0027SHA found in descendants\u0027)"},{"line_number":308,"context_line":"                                else:"},{"line_number":309,"context_line":"                                    print(\u0027SHA NOT FOUND in descendants\u0027)"},{"line_number":310,"context_line":"                                    if series_name \u003d\u003d \u0027_independent\u0027:"},{"line_number":311,"context_line":"                                        save \u003d warnings.append"},{"line_number":312,"context_line":"                                    else:"},{"line_number":313,"context_line":"                                        save \u003d errors.append"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8e563fcc","line":310,"updated":"2016-08-17 02:40:12.000000000","message":"Now that we test this in the is_independent check I don\u0027t think we need this anymore do we?","commit_id":"0289d784a24f23fa5690826c2d38901b8ba8bdd7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8352e0ad93a3b93de99ae7b596674489f9d8e875","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                                    print(\u0027SHA found in descendants\u0027)"},{"line_number":308,"context_line":"                                else:"},{"line_number":309,"context_line":"                                    print(\u0027SHA NOT FOUND in descendants\u0027)"},{"line_number":310,"context_line":"                                    if series_name \u003d\u003d \u0027_independent\u0027:"},{"line_number":311,"context_line":"                                        save \u003d warnings.append"},{"line_number":312,"context_line":"                                    else:"},{"line_number":313,"context_line":"                                        save \u003d errors.append"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0db7d5f5","line":310,"in_reply_to":"3ac371cc_8e563fcc","updated":"2016-08-17 14:31:07.000000000","message":"Good point. I want to do a lot of cleanup in here because this function is really long and the logic is twisty. I\u0027d rather do that in a separate patch.","commit_id":"0289d784a24f23fa5690826c2d38901b8ba8bdd7"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ae49f48a9d953a2a07c6555251b7aea9360bdc5a","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                    )"},{"line_number":322,"context_line":"                            else:"},{"line_number":323,"context_line":"                                print(\u0027skipping descendant test for independent project, \u0027"},{"line_number":324,"context_line":"                                      \u0027verify branch manually\u0027)"},{"line_number":325,"context_line":"            prev_version \u003d release[\u0027version\u0027]"},{"line_number":326,"context_line":"            prev_projects \u003d set(p[\u0027repo\u0027] for p in release[\u0027projects\u0027])"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_2edaab4c","line":324,"updated":"2016-08-17 02:40:12.000000000","message":"Generally my worry with this is that we\u0027ve now introduced a manual check *sometimes* and we\u0027ll forget to do that thing.  I guess the impact to that is limited but still my intuition says this is a backwards step in testing coverage.\n\nHaving said that if we\u0027re going to do this then I feel like we need to have this \u0027check\u0027 clearly documented so all reviewers are on the same page.\n\nIt could also form the basis for a automated check that can be added to code once it\u0027s well understood.","commit_id":"0289d784a24f23fa5690826c2d38901b8ba8bdd7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8352e0ad93a3b93de99ae7b596674489f9d8e875","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                    )"},{"line_number":322,"context_line":"                            else:"},{"line_number":323,"context_line":"                                print(\u0027skipping descendant test for independent project, \u0027"},{"line_number":324,"context_line":"                                      \u0027verify branch manually\u0027)"},{"line_number":325,"context_line":"            prev_version \u003d release[\u0027version\u0027]"},{"line_number":326,"context_line":"            prev_projects \u003d set(p[\u0027repo\u0027] for p in release[\u0027projects\u0027])"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_edd4f920","line":324,"in_reply_to":"3ac371cc_2edaab4c","updated":"2016-08-17 14:31:07.000000000","message":"The list-changes report already shows the branch the commit is on and the logic to figure out the right series to test was more complicated than I wanted to try to implement while the ansible release is blocked on this bug, so I just punted it.","commit_id":"0289d784a24f23fa5690826c2d38901b8ba8bdd7"}]}