)]}'
{"deliverables/newton/instack-undercloud.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1e2a2399ec4e00c193939c4dbcbc6b21a82a30a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_56d773ec","line":40,"updated":"2016-11-10 07:41:25.000000000","message":"Ie14f778f4e5a8d740d31cbddffc239fdb449f23d Concerns me a little.  The comit message reads:\n\n\"Currently we have some users who are still using ceilometer on undercloud. Turning this on by default keeps the behavior consistent for upgrades. If not used, this can be turned off easily in undercloud.conf.\"\n\nThis implies to me that there are some users that are not running ceilometer that are now going to get it as a result of an upgrade *unless* they have explictly set enable_telemetry\u003dFalse","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3dafe8fe0bec626aeabbd667195b22131da60ebd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_27953d86","line":40,"in_reply_to":"9a629dbe_0a3855ee","updated":"2016-11-11 02:37:11.000000000","message":"okay so Let me get this straight.\n\nA user running 4..0.0 had telemetry by default, upgrades to 5..0.0 and no longer has telemetry , upgrades 5.1.0 and gets it again?\n\nIn 4.0.0 there wasn\u0027t a config option to tweak so they couldn\u0027t do that thing.\nIf a 5.0.0 user decides they really wanted telemetry then they could have tweaked the config variable and upon upgrade to 5.1.0 they still get telemetry.\n\nSo it\u0027s only impacts people that upgrade from 5.0.0 to 5.1.0 that haven\u0027t set an explicit enable_telemetry value in the config file.\n\nI\u0027m not sure that there is a fix here other than be explicit with the upgrade documentation.","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"10c4337e7225f121ad63f0796f592c8e6007ccf8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_94bd3904","line":40,"in_reply_to":"9a629dbe_1a64f5b6","updated":"2016-11-11 16:58:22.000000000","message":"we have a docs patch at https://review.openstack.org/#/c/396690/","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c7bbe8503993054e12157b3ae94e93055d76e372","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_1a64f5b6","line":40,"in_reply_to":"9a629dbe_27953d86","updated":"2016-11-11 15:49:34.000000000","message":"That\u0027s all correct. I\u0027ll work towards getting this behavior documented in tripleo-docs","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b13887006470b31d75e95adc3f0ec873f4bf2be9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_0a3855ee","line":40,"in_reply_to":"9a629dbe_56d773ec","updated":"2016-11-10 15:49:45.000000000","message":"that commit to set enable_telemetry\u003dTrue by default actually switches it back to the default behavior.\n\nWe changed the default behavior to enable_telmetry\u003dFalse with commit f6ce77547831a015bb7f6404c040957028022edd.\n\nSo, we\u0027re actually fixing that inconsistency in that we are going back to the default so that the behavior is the same on upgrades.\n\nFor users who have set an explicit enable_telemetry value, that will be unchanged.","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b7f1d6a4ec31e0a9dbd078674982cf67f5a9f37c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - version: 5.1.0"},{"line_number":38,"context_line":"    projects:"},{"line_number":39,"context_line":"      - repo: openstack/instack-undercloud"},{"line_number":40,"context_line":"        hash: a9047744407a993e2cb02411ad48d421440d647c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_6652b268","line":40,"in_reply_to":"9a629dbe_94bd3904","updated":"2016-11-11 23:01:22.000000000","message":"Okay.  Thanks","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"}],"deliverables/newton/tripleo-common.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1e2a2399ec4e00c193939c4dbcbc6b21a82a30a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - version: 5.4.0"},{"line_number":33,"context_line":"    projects:"},{"line_number":34,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":35,"context_line":"        hash: 6da966ce29ceedfab06099baa106882f89e5064a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_acb24004","line":35,"updated":"2016-11-10 07:41:25.000000000","message":"Umm what happened here[1] with the requirements appearing to go backwards?  IS that what you expect?\n\n[1] http://logs.openstack.org/99/391799/4/check/gate-releases-tox-list-changes-ubuntu-xenial/a7f9873/console.html#_2016-11-10_02_14_50_000442","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3dafe8fe0bec626aeabbd667195b22131da60ebd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - version: 5.4.0"},{"line_number":33,"context_line":"    projects:"},{"line_number":34,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":35,"context_line":"        hash: 6da966ce29ceedfab06099baa106882f89e5064a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_6ca55a45","line":35,"in_reply_to":"9a629dbe_010cbbeb","updated":"2016-11-11 02:37:11.000000000","message":"Ahh okay.  So this happened because you\u0027re cycle-trailing and you branched newton *after* requirements was open for ocata. so you got changes destined for ocata :(\n\nWe\u0027ll need to think about how to prevent that in the future.","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b13887006470b31d75e95adc3f0ec873f4bf2be9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - version: 5.4.0"},{"line_number":33,"context_line":"    projects:"},{"line_number":34,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":35,"context_line":"        hash: 6da966ce29ceedfab06099baa106882f89e5064a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_010cbbeb","line":35,"in_reply_to":"9a629dbe_acb24004","updated":"2016-11-10 15:49:45.000000000","message":"this was caused by commit eddce897c208a64a097c156342996a96b031f74c\nwhich was a sync from global requirements from stable/newton.\n\nWhen the tripleo-common stable/newton branch was created from master, it naturally had the same requirements.txt as the master branch. And this commit brought it into sync with global-requirements.txt from stable/newton.\n\nso, yes, this is what I would expect. Although i admit it is a bit odd of how this worked out. Did we miss some other part of the process when stable/newton branches were created?","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"}],"deliverables/newton/tripleo-ui.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1e2a2399ec4e00c193939c4dbcbc6b21a82a30a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    projects:"},{"line_number":26,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":27,"context_line":"        hash: 656117b66b2ed79f5fec5fbed8768869b9000966"},{"line_number":28,"context_line":"  - version: 1.0.5"},{"line_number":29,"context_line":"    projects:"},{"line_number":30,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":31,"context_line":"        hash: fb3c3f0cb6b62f60e4883b7a4408415b2222758a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_ccb9347b","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":18},"updated":"2016-11-10 07:41:25.000000000","message":"About half of the changes in this release don\u0027t seem to be bug fixes .... are you certain that a patch level bump is appropriate?","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"7b0c1fd1bde8f3595f4dcb6611df5cb3f35b1ea3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    projects:"},{"line_number":26,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":27,"context_line":"        hash: 656117b66b2ed79f5fec5fbed8768869b9000966"},{"line_number":28,"context_line":"  - version: 1.0.5"},{"line_number":29,"context_line":"    projects:"},{"line_number":30,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":31,"context_line":"        hash: fb3c3f0cb6b62f60e4883b7a4408415b2222758a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_a1478fba","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":18},"in_reply_to":"9a629dbe_21db7f50","updated":"2016-11-10 15:53:48.000000000","message":"Apologies for not including bug references to all commit messages, although I can confirm that all patches backported to stable/newton branch can be considered bug fixes","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b13887006470b31d75e95adc3f0ec873f4bf2be9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    projects:"},{"line_number":26,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":27,"context_line":"        hash: 656117b66b2ed79f5fec5fbed8768869b9000966"},{"line_number":28,"context_line":"  - version: 1.0.5"},{"line_number":29,"context_line":"    projects:"},{"line_number":30,"context_line":"      - repo: openstack/tripleo-ui"},{"line_number":31,"context_line":"        hash: fb3c3f0cb6b62f60e4883b7a4408415b2222758a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_21db7f50","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":18},"in_reply_to":"9a629dbe_ccb9347b","updated":"2016-11-10 15:49:45.000000000","message":"I will ask someone more familiar with the changes done to tripleo-ui to comment.","commit_id":"7dab0d4b6ef363a34b60d23c4bb21278eba5f249"}]}
