)]}'
{"openstack_releases/cmds/validate.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2aefe4222afb6b9aa85b078dd8e3e5ab55a44b17","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            # that\u0027s where the deliverable file is."},{"line_number":161,"context_line":"            if is_independent:"},{"line_number":162,"context_line":"                if series_name !\u003d \u0027_independent\u0027:"},{"line_number":163,"context_line":"                    mk_warning("},{"line_number":164,"context_line":"                        \u0027%s uses the independent release model \u0027"},{"line_number":165,"context_line":"                        \u0027and should be in the _independent \u0027"},{"line_number":166,"context_line":"                        \u0027directory\u0027 % project[\u0027repo\u0027],"},{"line_number":167,"context_line":"                    )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"            # Check the SHA specified for the tag."},{"line_number":170,"context_line":"            print(\u0027%s SHA %s \u0027 % (project[\u0027repo\u0027], project[\u0027hash\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_15f2b5d2","line":167,"range":{"start_line":163,"start_character":0,"end_line":167,"end_character":21},"updated":"2016-11-24 01:03:23.000000000","message":"eg here","commit_id":"5a444cd329526418f563f859e82c65c2836f0a0e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2aefe4222afb6b9aa85b078dd8e3e5ab55a44b17","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                release[\u0027version\u0027],"},{"line_number":223,"context_line":"                                release_type\u003drelease_type,"},{"line_number":224,"context_line":"                                pre_ok\u003d(release_model in _USES_PREVER)):"},{"line_number":225,"context_line":"                            msg \u003d (\u0027could not validate version %r: %s\u0027 %"},{"line_number":226,"context_line":"                                   (release[\u0027version\u0027], e))"},{"line_number":227,"context_line":"                            mk_error(msg)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                        # Check to see if we are re-tagging the same"},{"line_number":230,"context_line":"                        # commit with a new version."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_95b405f3","line":227,"range":{"start_line":225,"start_character":28,"end_line":227,"end_character":41},"updated":"2016-11-24 01:03:23.000000000","message":"nit: AFAICT everywhere else you\u0027ve moved the string construction into the mk_error() call so this seems a little inconsistent ... perhaps:\n\n                            mk_error(\u0027could not validate version %r: %s\u0027 %\n                                           (release[\u0027version\u0027], e)))\n\n?","commit_id":"5a444cd329526418f563f859e82c65c2836f0a0e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2aefe4222afb6b9aa85b078dd8e3e5ab55a44b17","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            if nr !\u003d deliverable_info[\u0027releases\u0027][-1]:"},{"line_number":272,"context_line":"                msg \u003d (\u0027new release %s must be listed last, \u0027"},{"line_number":273,"context_line":"                       \u0027with one new release per patch\u0027 % nr[\u0027version\u0027])"},{"line_number":274,"context_line":"                mk_error(msg)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def validate_new_releases(deliverable_info, filename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_d57cbd22","line":274,"updated":"2016-11-24 01:03:23.000000000","message":"nit: okay so maybe not all.","commit_id":"5a444cd329526418f563f859e82c65c2836f0a0e"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"796624f06908cc4bf28dbcf3fd76057d274d65ee","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            filename,"},{"line_number":378,"context_line":"            team_data,"},{"line_number":379,"context_line":"            mk_warning,"},{"line_number":380,"context_line":"            mk_error,"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        validate_releases("},{"line_number":383,"context_line":"            deliverable_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_f77c45ed","line":380,"updated":"2016-11-24 14:27:42.000000000","message":"should no longer pass \u0027filename\u0027","commit_id":"5a444cd329526418f563f859e82c65c2836f0a0e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8af197f003587ca046b6fdf83274e2ded99274a","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            filename,"},{"line_number":378,"context_line":"            team_data,"},{"line_number":379,"context_line":"            mk_warning,"},{"line_number":380,"context_line":"            mk_error,"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        validate_releases("},{"line_number":383,"context_line":"            deliverable_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_d8056d11","line":380,"in_reply_to":"5a74a57a_f77c45ed","updated":"2016-11-28 01:39:39.000000000","message":"I\u0027m going to fix this and re-publish to keep this moving.\n\nI hope that isn\u0027t over stepping.","commit_id":"5a444cd329526418f563f859e82c65c2836f0a0e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"86e2a3af2bf1caf621b88ba8b0a4e4e4dac703b7","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        if series_name \u003d\u003d defaults.RELEASE:"},{"line_number":392,"context_line":"            validate_new_releases("},{"line_number":393,"context_line":"                deliverable_info,"},{"line_number":394,"context_line":"                filename,"},{"line_number":395,"context_line":"                team_data,"},{"line_number":396,"context_line":"                mk_warning,"},{"line_number":397,"context_line":"                mk_error,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_f8b14902","line":394,"range":{"start_line":394,"start_character":16,"end_line":394,"end_character":24},"updated":"2016-11-28 01:55:54.000000000","message":"I missed this one also.","commit_id":"ae310ae5cc8d126e902af49cc6871c44899cfca9"}]}