)]}'
{"openstack_releases/cmds/validate.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"51982751dfaeacf750376e9ce325963dde03ad8d","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                         (loc, repo, branch[\u0027name\u0027])))"},{"line_number":447,"context_line":"                )"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"# if the branch already exists, the name is by definition valid"},{"line_number":451,"context_line":"# if the branch exists, the data in the map must match reality"},{"line_number":452,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_98b2dee3","line":449,"updated":"2016-11-29 01:27:30.000000000","message":"This looks to be almost a duplicate of validate_feature_branches()  Is there any merit in merging them?\n\n def validate_feature_branches(...)\n     return _validate_muble_branches(\u0027feature\u0027, .....)\n\n def validate_driverfixes_branches(...)\n     return _validate_muble_branches(\u0027driverfixes\u0027, .....)\n\nOr is that pre-mature complication?","commit_id":"eced26b1b5943d5c1f96f8dac82aefd313510465"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"46c9c4658df58821b9e94e9ef81cb6b8383199ac","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                         (loc, repo, branch[\u0027name\u0027])))"},{"line_number":447,"context_line":"                )"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"# if the branch already exists, the name is by definition valid"},{"line_number":451,"context_line":"# if the branch exists, the data in the map must match reality"},{"line_number":452,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_755168d8","line":449,"in_reply_to":"5a74a57a_58668651","updated":"2016-11-29 15:58:37.000000000","message":"I added the additional rule.\n\nI thought we would want to keep the validation functions separate, to be clear which rules apply where and to avoid complication when we want to change a rule. That results in some repetition, but I think it\u0027s clearer in the end.","commit_id":"eced26b1b5943d5c1f96f8dac82aefd313510465"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"f89171c68cf3b2bdbc8d6d21422966580770f14b","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                         (loc, repo, branch[\u0027name\u0027])))"},{"line_number":447,"context_line":"                )"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"# if the branch already exists, the name is by definition valid"},{"line_number":451,"context_line":"# if the branch exists, the data in the map must match reality"},{"line_number":452,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_58668651","line":449,"in_reply_to":"5a74a57a_98b2dee3","updated":"2016-11-29 01:32:54.000000000","message":"Ahh Actually I see Based on https://review.openstack.org/#/c/403878/1/README.rst@89  driverfixes must have a valid series name ie driverfixes/liberty #winning driverfixes/banana #fail.\n\nBut we don\u0027t actually enforce that in the function here.  I think that the documented use is correct and matches my understanding of how driverfixes are used.\n\nWith that in mind I think we need to borrow some of validate_stable_branches()","commit_id":"eced26b1b5943d5c1f96f8dac82aefd313510465"}]}