)]}'
{"openstack_releases/tests/test_validate.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"f9a540b2f81fae4173704136c554630b39cf9d96","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(0, len(warnings))"},{"line_number":471,"context_line":"        self.assertEqual(1, len(errors))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_master_release_from_sha_on_stable(self):"},{"line_number":474,"context_line":"        deliverable_info \u003d {"},{"line_number":475,"context_line":"            \u0027artifact-link-mode\u0027: \u0027none\u0027,"},{"line_number":476,"context_line":"            \u0027releases\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_e102e46e","line":473,"updated":"2016-11-30 14:50:11.000000000","message":"The names of these methods seem backwards. The stable test is looking at the current default release series, and the master test is using the \u0027newton\u0027 series.","commit_id":"eec9137272d43b2d6da15b782e6441ec8b5364c6"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"887eb06e705048852eaaa32d7c442a9d997aa8f9","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(0, len(warnings))"},{"line_number":471,"context_line":"        self.assertEqual(1, len(errors))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_master_release_from_sha_on_stable(self):"},{"line_number":474,"context_line":"        deliverable_info \u003d {"},{"line_number":475,"context_line":"            \u0027artifact-link-mode\u0027: \u0027none\u0027,"},{"line_number":476,"context_line":"            \u0027releases\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_377452ce","line":473,"in_reply_to":"5a74a57a_575a6c2b","updated":"2016-12-01 08:14:39.000000000","message":"Yes, that\u0027s exactly what I meant by this title. A \"master release\" using a \"SHA on stable\"... I\u0027ll try to find a clearer title :)","commit_id":"eec9137272d43b2d6da15b782e6441ec8b5364c6"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"47753d52d40326da1d20b805a2ffea877b48295f","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(0, len(warnings))"},{"line_number":471,"context_line":"        self.assertEqual(1, len(errors))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_master_release_from_sha_on_stable(self):"},{"line_number":474,"context_line":"        deliverable_info \u003d {"},{"line_number":475,"context_line":"            \u0027artifact-link-mode\u0027: \u0027none\u0027,"},{"line_number":476,"context_line":"            \u0027releases\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_fd843f5e","line":473,"in_reply_to":"5a74a57a_e102e46e","updated":"2016-11-30 16:55:50.000000000","message":"Hmm, not sure I follow you...\nThis one tests a master release from a sha on a stable branch.\nThe other tests a stable release from a sha on master...","commit_id":"eec9137272d43b2d6da15b782e6441ec8b5364c6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e2efd50dbc9d094455afb9b23793cad519202b39","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(0, len(warnings))"},{"line_number":471,"context_line":"        self.assertEqual(1, len(errors))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_master_release_from_sha_on_stable(self):"},{"line_number":474,"context_line":"        deliverable_info \u003d {"},{"line_number":475,"context_line":"            \u0027artifact-link-mode\u0027: \u0027none\u0027,"},{"line_number":476,"context_line":"            \u0027releases\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_575a6c2b","line":473,"in_reply_to":"5a74a57a_fd843f5e","updated":"2016-11-30 18:53:40.000000000","message":"This one passes defaults.RELEASE as the series to validate_releases(), which is what I would expect for a release coming from master. The other passes \u0027newton\u0027 which is what I would expect for a stable branch release. So the SHAs may be in the right branch of openstack/automaton, but the rest of the arguments seem out of alignment.","commit_id":"eec9137272d43b2d6da15b782e6441ec8b5364c6"}]}