)]}'
{"openstack_releases/links.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"596d394bb8cadc35592aa28f849e0e8378d5e0c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def wheel_py2_url(version, project):"},{"line_number":46,"context_line":"    repo_base \u003d project[\u0027repo\u0027].rsplit(\u0027/\u0027)[-1]"},{"line_number":47,"context_line":"    base \u003d project.get(\u0027tarball-base\u0027, repo_base).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":48,"context_line":"    return \u0027{s}/{r}/{n}-{v}-py2-none-any.whl\u0027.format("},{"line_number":49,"context_line":"        s\u003d\u0027https://tarballs.openstack.org\u0027,"},{"line_number":50,"context_line":"        v\u003dversion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_831575e7","line":47,"updated":"2017-10-25 21:11:37.000000000","message":"Huh?  I was going to suggest that we use https://packaging.pypa.io/en/latest/utils/#packaging.utils.canonicalize_name but this is doing the opposite","commit_id":"496f8dfd3f3a50e965f9306ff497a71c4e728967"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3374b764201332a09e4fcd8d5c3f06dae04d5e54","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def wheel_py2_url(version, project):"},{"line_number":46,"context_line":"    repo_base \u003d project[\u0027repo\u0027].rsplit(\u0027/\u0027)[-1]"},{"line_number":47,"context_line":"    base \u003d project.get(\u0027tarball-base\u0027, repo_base).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":48,"context_line":"    return \u0027{s}/{r}/{n}-{v}-py2-none-any.whl\u0027.format("},{"line_number":49,"context_line":"        s\u003d\u0027https://tarballs.openstack.org\u0027,"},{"line_number":50,"context_line":"        v\u003dversion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b2e315a4","line":47,"in_reply_to":"3f4b6375_59bbecc3","updated":"2017-10-26 01:57:52.000000000","message":"\"We have it backwards here\" as in this patch is not correct? Seems like canonicalize_name makes different changes than we want in this situation, no?","commit_id":"496f8dfd3f3a50e965f9306ff497a71c4e728967"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"844fe1e569ee64a1588e3092031c531d6a3c81b7","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def wheel_py2_url(version, project):"},{"line_number":46,"context_line":"    repo_base \u003d project[\u0027repo\u0027].rsplit(\u0027/\u0027)[-1]"},{"line_number":47,"context_line":"    base \u003d project.get(\u0027tarball-base\u0027, repo_base).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":48,"context_line":"    return \u0027{s}/{r}/{n}-{v}-py2-none-any.whl\u0027.format("},{"line_number":49,"context_line":"        s\u003d\u0027https://tarballs.openstack.org\u0027,"},{"line_number":50,"context_line":"        v\u003dversion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_59bbecc3","line":47,"in_reply_to":"3f4b6375_831575e7","updated":"2017-10-25 22:35:34.000000000","message":"Oops, yeah, I think we have it backwards here. Good eye, Tony.","commit_id":"496f8dfd3f3a50e965f9306ff497a71c4e728967"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fec59d33b82bf23ce594677d3bb445445ab87bce","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def wheel_py2_url(version, project):"},{"line_number":46,"context_line":"    repo_base \u003d project[\u0027repo\u0027].rsplit(\u0027/\u0027)[-1]"},{"line_number":47,"context_line":"    base \u003d project.get(\u0027tarball-base\u0027, repo_base).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":48,"context_line":"    return \u0027{s}/{r}/{n}-{v}-py2-none-any.whl\u0027.format("},{"line_number":49,"context_line":"        s\u003d\u0027https://tarballs.openstack.org\u0027,"},{"line_number":50,"context_line":"        v\u003dversion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_e82760c9","line":47,"in_reply_to":"3f4b6375_b2e315a4","updated":"2017-10-26 03:49:35.000000000","message":"Ultimately we get the name for the wheel from [1] which makes different choices.  It may come down to \u0027-\u0027s being canonical in module names but \u0027_\u0027s in filenames.\n\n\n \u003e\u003e\u003e import wheel.bdist_wheel\n \u003e\u003e\u003e wheel.bdist_wheel.safer_name(\u0027glance_store\u0027)\n \u0027glance_store\u0027\n \u003e\u003e\u003e wheel.bdist_wheel.safer_name(\u0027glance-store\u0027)\n \u0027glance_store\u0027\n \u003e\u003e\u003e import packaging.utils\n \u003e\u003e\u003e packaging.utils.canonicalize_name(\u0027glance_store\u0027)\n \u0027glance-store\u0027\n \u003e\u003e\u003e packaging.utils.canonicalize_name(\u0027glance-store\u0027)\n\u0027glance-store\u0027\n\nSo IMO this change is correct for *our* infrastructure but perhaps we\u0027re out of sync with the global python community.\n\n[1] http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/pypi-extract-name.py#n29","commit_id":"496f8dfd3f3a50e965f9306ff497a71c4e728967"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"482760af64445b3a665e3307e642958cc4f33047","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def wheel_py2_url(version, project):"},{"line_number":46,"context_line":"    repo_base \u003d project[\u0027repo\u0027].rsplit(\u0027/\u0027)[-1]"},{"line_number":47,"context_line":"    base \u003d project.get(\u0027tarball-base\u0027, repo_base).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":48,"context_line":"    return \u0027{s}/{r}/{n}-{v}-py2-none-any.whl\u0027.format("},{"line_number":49,"context_line":"        s\u003d\u0027https://tarballs.openstack.org\u0027,"},{"line_number":50,"context_line":"        v\u003dversion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_ee44fe75","line":47,"in_reply_to":"3f4b6375_e82760c9","updated":"2017-10-26 12:04:55.000000000","message":"Cool, I did not know about safer_name. I will update to use that.","commit_id":"496f8dfd3f3a50e965f9306ff497a71c4e728967"}]}