)]}'
{"openstack_releases/cmds/validate.py":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"178e338492889bb143cd93fc9c7b101e2ade6218","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    repository_settings \u003d deliverable_info.get(\u0027repository-settings\u0027, {})"},{"line_number":733,"context_line":"    for repo in actual_repos:"},{"line_number":734,"context_line":"        if repo not in repository_settings:"},{"line_number":735,"context_line":"            # TODO(dhellmann): Turn this into a warning after the T"},{"line_number":736,"context_line":"            # series is open."},{"line_number":737,"context_line":"            mk_warning("},{"line_number":738,"context_line":"                \u0027release %s includes repository %s \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_e3ee0fb3","line":735,"updated":"2018-02-07 17:52:32.000000000","message":"you mean turn it into an error, right...","commit_id":"d045fb7dd16183cbf5707090f651cff27332fd22"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9986b95db00cb0391304d90dc56af72b3f4523c5","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    repository_settings \u003d deliverable_info.get(\u0027repository-settings\u0027, {})"},{"line_number":733,"context_line":"    for repo in actual_repos:"},{"line_number":734,"context_line":"        if repo not in repository_settings:"},{"line_number":735,"context_line":"            # TODO(dhellmann): Turn this into a warning after the T"},{"line_number":736,"context_line":"            # series is open."},{"line_number":737,"context_line":"            mk_warning("},{"line_number":738,"context_line":"                \u0027release %s includes repository %s \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_57cf79af","line":735,"in_reply_to":"3fa0c359_a11d5f74","updated":"2018-02-07 19:53:01.000000000","message":"See https://review.openstack.org/#/c/541842/2","commit_id":"d045fb7dd16183cbf5707090f651cff27332fd22"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ed3610f17994fd8e6b222fc196bb16866bb66e8c","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    repository_settings \u003d deliverable_info.get(\u0027repository-settings\u0027, {})"},{"line_number":733,"context_line":"    for repo in actual_repos:"},{"line_number":734,"context_line":"        if repo not in repository_settings:"},{"line_number":735,"context_line":"            # TODO(dhellmann): Turn this into a warning after the T"},{"line_number":736,"context_line":"            # series is open."},{"line_number":737,"context_line":"            mk_warning("},{"line_number":738,"context_line":"                \u0027release %s includes repository %s \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_a11d5f74","line":735,"in_reply_to":"3fa0c359_e3ee0fb3","updated":"2018-02-07 19:11:54.000000000","message":"Oops, yes. I\u0027ll go ahead and file the patch to do that as part of this series, since later patches add the missing data.","commit_id":"d045fb7dd16183cbf5707090f651cff27332fd22"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2fd08b144268af83d4ca20a8a4d0e90942dac376","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    repository_settings \u003d deliverable_info.get(\u0027repository-settings\u0027, {})"},{"line_number":733,"context_line":"    for repo in actual_repos:"},{"line_number":734,"context_line":"        if repo not in repository_settings:"},{"line_number":735,"context_line":"            # TODO(dhellmann): Turn this into a warning after the T"},{"line_number":736,"context_line":"            # series is open."},{"line_number":737,"context_line":"            mk_warning("},{"line_number":738,"context_line":"                \u0027release %s includes repository %s \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa0c359_7bf13fcd","line":735,"range":{"start_line":735,"start_character":48,"end_line":735,"end_character":55},"updated":"2018-02-07 22:04:34.000000000","message":"error?","commit_id":"333092d22670c1b8fb25030d438d2e11e728aabb"}],"openstack_releases/tests/test_validate.py":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"178e338492889bb143cd93fc9c7b101e2ade6218","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            warnings.append,"},{"line_number":178,"context_line":"            errors.append,"},{"line_number":179,"context_line":"        )"},{"line_number":180,"context_line":"        print(warnings, errors)"},{"line_number":181,"context_line":"        self.assertEqual(1, len(warnings))"},{"line_number":182,"context_line":"        self.assertEqual(0, len(errors))"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_a37c87eb","line":180,"updated":"2018-02-07 17:52:32.000000000","message":"Leftover debug ?","commit_id":"d045fb7dd16183cbf5707090f651cff27332fd22"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ed3610f17994fd8e6b222fc196bb16866bb66e8c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            warnings.append,"},{"line_number":178,"context_line":"            errors.append,"},{"line_number":179,"context_line":"        )"},{"line_number":180,"context_line":"        print(warnings, errors)"},{"line_number":181,"context_line":"        self.assertEqual(1, len(warnings))"},{"line_number":182,"context_line":"        self.assertEqual(0, len(errors))"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa0c359_413b3bea","line":180,"in_reply_to":"3fa0c359_a37c87eb","updated":"2018-02-07 19:11:54.000000000","message":"Lots of the tests include this. The tests are brittle because they\u0027re counting errors or warnings rather than looking for specific messages. The test output is captured and only shown when the test fails, and having the warnings and errors list almost always shows what new message means a test\u0027s inputs need to be updated.","commit_id":"d045fb7dd16183cbf5707090f651cff27332fd22"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2fd08b144268af83d4ca20a8a4d0e90942dac376","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        errors \u003d []"},{"line_number":1282,"context_line":"        validate.validate_new_releases("},{"line_number":1283,"context_line":"            deliverable_info,"},{"line_number":1284,"context_line":"            \u0027release-test.yaml\u0027,"},{"line_number":1285,"context_line":"            self.team_data,"},{"line_number":1286,"context_line":"            warnings.append,"},{"line_number":1287,"context_line":"            errors.append,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa0c359_5e88f16f","line":1284,"range":{"start_line":1284,"start_character":12,"end_line":1284,"end_character":31},"updated":"2018-02-07 22:04:34.000000000","message":"This is a little non-obvious (to me).  Perhaps a comment or something more explicit \u0027bad_deliverable_name\u0027 ?\n\nTo me this looked more like a failed conversion in filename \u003d\u003e deliverable_name","commit_id":"333092d22670c1b8fb25030d438d2e11e728aabb"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2fd08b144268af83d4ca20a8a4d0e90942dac376","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        errors \u003d []"},{"line_number":1311,"context_line":"        validate.validate_new_releases("},{"line_number":1312,"context_line":"            deliverable_info,"},{"line_number":1313,"context_line":"            \u0027release-test.yaml\u0027,"},{"line_number":1314,"context_line":"            self.team_data,"},{"line_number":1315,"context_line":"            warnings.append,"},{"line_number":1316,"context_line":"            errors.append,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa0c359_be9815c0","line":1313,"range":{"start_line":1313,"start_character":12,"end_line":1313,"end_character":31},"updated":"2018-02-07 22:04:34.000000000","message":"as above","commit_id":"333092d22670c1b8fb25030d438d2e11e728aabb"}]}