)]}'
{"openstack_releases/deliverable.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"de48e2bdb2e471b9bfdc238cecc1c63836ff6bf2","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        if deliv:"},{"line_number":270,"context_line":"            self.deliv \u003d weakref.proxy(deliv)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            self.deliv \u003d deliv"},{"line_number":273,"context_line":"        self._data \u003d data"},{"line_number":274,"context_line":"        self._projects \u003d {"},{"line_number":275,"context_line":"            p[\u0027repo\u0027]: ReleaseProject(p[\u0027repo\u0027], p[\u0027hash\u0027], p, self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e4b7bfd7","line":272,"updated":"2018-06-08 23:50:47.000000000","message":"Isn\u0027t deliv None here if it didn\u0027t pass the if check? Wouldn\u0027t it be more explicit to do:\n\nself.deliv \u003d None\nif deliv:\n    seld.deliv \u003d weakref.proxy(deliv)","commit_id":"ef1b0d65747dc8335cce1ba4092e077c756f0e21"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"52a255b8a83fb3dca2b35b5a4bb3ec4e1d4754dc","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        if deliv:"},{"line_number":270,"context_line":"            self.deliv \u003d weakref.proxy(deliv)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            self.deliv \u003d deliv"},{"line_number":273,"context_line":"        self._data \u003d data"},{"line_number":274,"context_line":"        self._projects \u003d {"},{"line_number":275,"context_line":"            p[\u0027repo\u0027]: ReleaseProject(p[\u0027repo\u0027], p[\u0027hash\u0027], p, self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_97b7c885","line":272,"in_reply_to":"5f7c97a3_87047f4b","updated":"2018-06-13 14:28:43.000000000","message":"I added this so I could pass None in the unit test and not have to construct an entire Deliverable object just to construct a Release object.","commit_id":"ef1b0d65747dc8335cce1ba4092e077c756f0e21"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c82f892c6b95677817438f050cb38365a0cb9eb9","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        if deliv:"},{"line_number":270,"context_line":"            self.deliv \u003d weakref.proxy(deliv)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            self.deliv \u003d deliv"},{"line_number":273,"context_line":"        self._data \u003d data"},{"line_number":274,"context_line":"        self._projects \u003d {"},{"line_number":275,"context_line":"            p[\u0027repo\u0027]: ReleaseProject(p[\u0027repo\u0027], p[\u0027hash\u0027], p, self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7a0bf1d3","line":272,"in_reply_to":"5f7c97a3_97b7c885","updated":"2018-06-13 14:44:32.000000000","message":"OK, it looks kind of odd to me done this way, but tomato tomato.","commit_id":"ef1b0d65747dc8335cce1ba4092e077c756f0e21"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"62c0fd508c739719092d5365d77e096cfc78c2f6","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        if deliv:"},{"line_number":270,"context_line":"            self.deliv \u003d weakref.proxy(deliv)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            self.deliv \u003d deliv"},{"line_number":273,"context_line":"        self._data \u003d data"},{"line_number":274,"context_line":"        self._projects \u003d {"},{"line_number":275,"context_line":"            p[\u0027repo\u0027]: ReleaseProject(p[\u0027repo\u0027], p[\u0027hash\u0027], p, self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_87047f4b","line":272,"in_reply_to":"5f7c97a3_e4b7bfd7","updated":"2018-06-13 08:40:01.000000000","message":"deliv is not necessarily None if it fails the check. Could also be empty string, or 0 or empty set, or empty array... \n\nBut yes, agree it looks like unrelated change.","commit_id":"ef1b0d65747dc8335cce1ba4092e077c756f0e21"}],"openstack_releases/tests/test_deliverable.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"52a255b8a83fb3dca2b35b5a4bb3ec4e1d4754dc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class TestReleaseWasForced(base.BaseTestCase):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_false(self):"},{"line_number":76,"context_line":"        r \u003d deliverable.Release(\u0027version\u0027, [], {\u0027flags\u0027: []}, None)"},{"line_number":77,"context_line":"        self.assertFalse(r.was_forced)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_true(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_57adb02e","line":76,"range":{"start_line":76,"start_character":62,"end_line":76,"end_character":66},"updated":"2018-06-13 14:28:43.000000000","message":"Here\u0027s the None passed to deliv.","commit_id":"ef1b0d65747dc8335cce1ba4092e077c756f0e21"}]}