)]}'
{"deliverables/rocky/networking-bagpipe.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5976451b50fce68d0ad71575fa449adb1d39a48","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  - projects:"},{"line_number":32,"context_line":"      - hash: 6150dccbc763a8d5b5ff22c2bbbcec8527e7213d"},{"line_number":33,"context_line":"        repo: openstack/networking-bagpipe"},{"line_number":34,"context_line":"    version: 9.0.1"},{"line_number":35,"context_line":"branches:"},{"line_number":36,"context_line":"  - location: 9.0.0.0rc1"},{"line_number":37,"context_line":"    name: stable/rocky"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c5c38189","line":34,"updated":"2018-09-18 14:41:39.000000000","message":"There are minimum required version changes in this stable patch release:\n\nhttp://logs.openstack.org/13/602013/1/check/releases-tox-list-changes/1395426/job-output.txt.gz#_2018-09-12_12_11_04_663904\n\n2018-09-12 12:11:04.663904 | ubuntu-xenial | Requirements updates\n2018-09-12 12:11:04.663941 | ubuntu-xenial | --------------------\n2018-09-12 12:11:04.663957 | ubuntu-xenial |\n2018-09-12 12:11:04.664021 | ubuntu-xenial | diff --git a/requirements.txt b/requirements.txt\n2018-09-12 12:11:04.664071 | ubuntu-xenial | index cf79fea..7ad05c4 100644\n2018-09-12 12:11:04.664110 | ubuntu-xenial | --- a/requirements.txt\n2018-09-12 12:11:04.664147 | ubuntu-xenial | +++ b/requirements.txt\n2018-09-12 12:11:04.664214 | ubuntu-xenial | @@ -17,2 +17,2 @@ debtcollector\u003e\u003d1.2.0 # Apache-2.0\n2018-09-12 12:11:04.664264 | ubuntu-xenial | -neutron\u003e\u003d13.0.0.0b1 # Apache-2.0\n2018-09-12 12:11:04.664309 | ubuntu-xenial | -horizon\u003e\u003d13.0.0 # Apache-2.0\n2018-09-12 12:11:04.664354 | ubuntu-xenial | +neutron\u003e\u003d13.0.0 # Apache-2.0\n2018-09-12 12:11:04.664398 | ubuntu-xenial | +horizon\u003e\u003d14.0.0 # Apache-2.0\n2018-09-12 12:11:04.664472 | ubuntu-xenial | diff --git a/test-requirements.txt b/test-requirements.txt\n2018-09-12 12:11:04.664541 | ubuntu-xenial | index 6b268b6..86d7e6d 100644\n2018-09-12 12:11:04.664593 | ubuntu-xenial | --- a/test-requirements.txt\n2018-09-12 12:11:04.664637 | ubuntu-xenial | +++ b/test-requirements.txt\n2018-09-12 12:11:04.664699 | ubuntu-xenial | @@ -23,2 +23,5 @@ tempest\u003e\u003d17.1.0 # Apache-2.0\n2018-09-12 12:11:04.664755 | ubuntu-xenial | -networking-bagpipe\u003e\u003d8.0.0 # Apache-2.0\n2018-09-12 12:11:04.664806 | ubuntu-xenial | -networking-odl\u003e\u003d12.0.0 # Apache-2.0\n2018-09-12 12:11:04.664861 | ubuntu-xenial | +networking-bagpipe\u003e\u003d9.0.0 # Apache-2.0\n2018-09-12 12:11:04.664942 | ubuntu-xenial | +# we can\u0027t use \u003e\u003d 13 which currently can\u0027t be properly installed\n2018-09-12 12:11:04.665032 | ubuntu-xenial | +# (requires ceilometer which, not being on pypy, is required withi\n2018-09-12 12:11:04.665116 | ubuntu-xenial | +# \"-e git\", which does not play nice with \"pip install -c\")\n2018-09-12 12:11:04.665172 | ubuntu-xenial | +networking-odl\u003e\u003d12.0.0,\u003c13 # Apache-2.0\n\nGenerally those are not OK - are the neutron stadium projects an exception to this?","commit_id":"25735df229caea2935072973913ef29e527d22a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3fc2efb3d46f866aca08a3f46095528844bfc15","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  - projects:"},{"line_number":32,"context_line":"      - hash: 6150dccbc763a8d5b5ff22c2bbbcec8527e7213d"},{"line_number":33,"context_line":"        repo: openstack/networking-bagpipe"},{"line_number":34,"context_line":"    version: 9.0.1"},{"line_number":35,"context_line":"branches:"},{"line_number":36,"context_line":"  - location: 9.0.0.0rc1"},{"line_number":37,"context_line":"    name: stable/rocky"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c8cdd886","line":34,"in_reply_to":"3f79a3b5_c5c38189","updated":"2018-09-18 15:26:40.000000000","message":"Thanks for pointing this.\nI know a change in requirements is not an usual thing, but in this case I believe it is okay because these projects are assumed to run with neutron and other neutron stadium projects from rocky releases.\nWe don\u0027t assume (and test) networking-bgpvpn|bagpipe of queens release can run with neutron rocky. They are run as part of neutron-server, so the same release (Rocky) is assumed.\n\n--\n\nNote that these requirement entries were added as part of zuul v3 migration and we forgot to bump them before the release.","commit_id":"25735df229caea2935072973913ef29e527d22a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99de447aba1af3ae9199de0dde905a7839abc1ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  - projects:"},{"line_number":32,"context_line":"      - hash: 6150dccbc763a8d5b5ff22c2bbbcec8527e7213d"},{"line_number":33,"context_line":"        repo: openstack/networking-bagpipe"},{"line_number":34,"context_line":"    version: 9.0.1"},{"line_number":35,"context_line":"branches:"},{"line_number":36,"context_line":"  - location: 9.0.0.0rc1"},{"line_number":37,"context_line":"    name: stable/rocky"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_0893d04f","line":34,"in_reply_to":"3f79a3b5_c8cdd886","updated":"2018-09-18 15:30:00.000000000","message":"Just dumping IRC conversation for posterity:\n\n(9:47:29 AM) mriedem: tmorin: hi i\u0027ve got a couple of questions in your stable/rocky release patch https://review.openstack.org/#/c/602013/\n(9:47:47 AM) mriedem: wondering how requirements work with the networking-bagpipe/bgpvpn services\n(9:49:28 AM) mriedem: generally it\u0027s not OK to increase the minimum required versions of dependencies on stable releases because we should assume that dependencies are frozen after a release GAs, but maybe these services are essentially considered part of neutron-server so they are treated differently by packagers/deployers/operators\n(10:16:50 AM) amotoki: mriedem: thanks for raising this. I did not notice it so far.\n(10:17:44 AM) amotoki: mriedem: however, I am okay with this change in this case because they are assumed to run with neutron and other neutron stadium projects from rocky releases.\n(10:18:42 AM) amotoki: mriedem: we don\u0027t assume and test networking-bgpvpn|bagpipe (for example) of queens release can run with neutron rocky.\n(10:19:12 AM) mriedem: so it\u0027s all lock-step 1:1 with the neutron server code, and that\u0027s how it\u0027s always been, and that\u0027s how users/deployers are already used to it working?\n(10:19:22 AM) amotoki: mriedem: these requirements were introduced during zuul v3 adoption and in my understanding we forgot to bump the required version\n(10:19:50 AM) mriedem: there is no client of client/server version negotiation in other words - either over rest or rpc apis\n(10:19:55 AM) amotoki: mriedem: yes, I believe no deployers use mixed versions\n(10:19:55 AM) mriedem: *no kind of client/server\n(10:20:20 AM) mriedem: amotoki: ok can you comment on the review for posterity?\n(10:20:33 AM) mriedem: i assume tmorin is in france and therefore done for the day...\n(10:20:40 AM) amotoki: mriedem: sure. the same thing can be said to horizon requirement change.\n(10:20:44 AM) mlavalle: yes, he is in France\n(10:21:52 AM) amotoki: mlavalle: is my understanding above same as yours? I would like to double check it.\n(10:22:00 AM) mriedem: ok someone just tell me how that all works on the review and i\u0027ll +1 it\n(10:22:23 AM) mlavalle: amotoki: yes\n(10:26:05 AM) MrWatson is now known as NostawRm\n(10:26:56 AM) amotoki: mriedem: done\n(10:27:04 AM) amotoki: mlavalle: thanks for your confrimation","commit_id":"25735df229caea2935072973913ef29e527d22a6"}],"deliverables/rocky/networking-bgpvpn.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5976451b50fce68d0ad71575fa449adb1d39a48","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  - projects:"},{"line_number":32,"context_line":"      - hash: d406efdf423af7f0dc72b11553e9255b10b99759"},{"line_number":33,"context_line":"        repo: openstack/networking-bgpvpn"},{"line_number":34,"context_line":"    version: 9.0.1"},{"line_number":35,"context_line":"branches:"},{"line_number":36,"context_line":"  - location: 9.0.0.0rc1"},{"line_number":37,"context_line":"    name: stable/rocky"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_653aad98","line":34,"updated":"2018-09-18 14:41:39.000000000","message":"There are minimum required version updates in here:\n\nhttp://logs.openstack.org/13/602013/1/check/releases-tox-list-changes/1395426/job-output.txt.gz#_2018-09-12_12_10_58_462020\n\nIs that normal?","commit_id":"25735df229caea2935072973913ef29e527d22a6"}]}