)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e01d30bd5b173c0100cdb0efbe264e8f52b71f48","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"new-release was grabbing the latest commit when adding an EOL tag. This"},{"line_number":10,"context_line":"tag should only be set on released commits. This updates the logic to"},{"line_number":11,"context_line":"use the same commit hash as the last release before going EOL."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I05308aaead044889717c754cffeb0daf57fdc399"},{"line_number":14,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_ab3e5726","line":11,"updated":"2019-04-06 19:26:09.000000000","message":"Should it? That would mean we can\u0027t EOL an EM branch accurately, since there won\u0027t be any releases after the EM tag.","commit_id":"358705abd81d822fc98eeaa58aac1892d7981f40"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7147742ada62975fa8016d3ffcc70f5780e48079","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"new-release was grabbing the latest commit when adding an EOL tag. This"},{"line_number":10,"context_line":"tag should only be set on released commits. This updates the logic to"},{"line_number":11,"context_line":"use the same commit hash as the last release before going EOL."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I05308aaead044889717c754cffeb0daf57fdc399"},{"line_number":14,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_cb2163b6","line":11,"in_reply_to":"5fc1f717_2b7907fb","updated":"2019-04-06 20:35:58.000000000","message":"But there would be additional commits on the branch, and we would lose those to the garbage collection if we don\u0027t tag them at EOL.","commit_id":"358705abd81d822fc98eeaa58aac1892d7981f40"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a48c5c3a8adb14838451374992c074303f6c5b4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"new-release was grabbing the latest commit when adding an EOL tag. This"},{"line_number":10,"context_line":"tag should only be set on released commits. This updates the logic to"},{"line_number":11,"context_line":"use the same commit hash as the last release before going EOL."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I05308aaead044889717c754cffeb0daf57fdc399"},{"line_number":14,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_2b7907fb","line":11,"in_reply_to":"5fc1f717_ab3e5726","updated":"2019-04-06 19:29:57.000000000","message":"Right, that\u0027s what we\u0027ve stated. Once a branch goes into extended maintenance, we will no longer be doing any releases from it. So the only transition or activity after going into EM would be to go to EOL.","commit_id":"358705abd81d822fc98eeaa58aac1892d7981f40"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a4bd069067bebed498bf35e1ba35ed06a50ef33","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"new-release was grabbing the latest commit when adding an EOL tag. This"},{"line_number":10,"context_line":"tag should only be set on released commits. This updates the logic to"},{"line_number":11,"context_line":"use the same commit hash as the last release before going EOL."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I05308aaead044889717c754cffeb0daf57fdc399"},{"line_number":14,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_80e9f2e3","line":11,"in_reply_to":"5fc1f717_cb2163b6","updated":"2019-04-08 05:05:52.000000000","message":"I agree with Doug, we should tag the HEAD as it\u0027s possible that during the EM phase we\u0027ve merged changes that are not released which would get lost.\n\nBoth  EM[1] and EOL[2] have words to effect of tagging HEAD, and that\u0027s what we did prior to EM.\n\nI think we should stringly encourage teams to release what\u0027s there at the transition to EM but that\u0027s a tangent.\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#extended-maintenance\n[2] https://docs.openstack.org/project-team-guide/stable-branches.html#end-of-life","commit_id":"358705abd81d822fc98eeaa58aac1892d7981f40"}]}