)]}'
{"id":"openstack%2Freleases~663839","triplet_id":"openstack%2Freleases~master~I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153","project":"openstack/releases","branch":"master","topic":"feature/new_tools","hashtags":[],"change_id":"I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153","subject":"Add --interactive to new-releases","status":"MERGED","created":"2019-06-07 04:43:21.000000000","updated":"2019-11-29 10:12:13.000000000","submitted":"2019-11-29 10:12:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663839-1575022333572-d413f5fc","meta_rev_id":"d4b967cf7770642cd9b01a4b7efd1940f976abb9","_number":663839,"virtual_id_number":663839,"owner":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-29 10:12:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-11-26 22:43:39.000000000","_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-11-27 09:27:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":1,"date":"2019-11-27 10:16:01.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":2,"date":"2019-11-18 01:34:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":1,"date":"2019-11-18 01:34:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":1,"date":"2019-11-29 09:58:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"PTL-Approved":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"}],"values":{" 0":"Not approved yet","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-07 17:38:10.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2019-10-31 19:28:09.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-11-15 14:38:00.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-11-27 09:27:13.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-11-27 10:16:01.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2019-11-29 09:58:17.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2019-11-29 10:12:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"497ec0cc4512f86edefb5cb1cdddb0919d85c6eb","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-06-07 04:43:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aa17f43a72a15c9d3ab0521eb7fe45ae38194d4b","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-06-07 04:45:56.000000000","message":"Patch Set 1: Workflow-1\n\nThese are basically the tools I used to create: https://review.opendev.org/#/q/topic:wci-m1-releases\n\nSetting -W as I want to test them again as I \u0027polished\u0027 them since last night","accounts_in_message":[],"_revision_number":1},{"id":"31a6f43abfb1b1ebb5c7d5264b064263a29dc65b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 04:56:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py35 http://logs.openstack.org/39/663839/1/check/openstack-tox-py35/0f35941/ : SUCCESS in 4m 12s\n- openstack-tox-py36 http://logs.openstack.org/39/663839/1/check/openstack-tox-py36/eb07154/ : SUCCESS in 4m 35s\n- openstack-tox-docs http://logs.openstack.org/39/663839/1/check/openstack-tox-docs/31ee006/html/ : SUCCESS in 7m 23s\n- openstack-tox-validate http://logs.openstack.org/39/663839/1/check/openstack-tox-validate/bb10f47/ : SUCCESS in 4m 10s\n- releases-tox-list-changes http://logs.openstack.org/39/663839/1/check/releases-tox-list-changes/598f600/ : SUCCESS in 3m 47s\n- openstack-tox-pep8 http://logs.openstack.org/39/663839/1/check/openstack-tox-pep8/a82c396/ : SUCCESS in 3m 54s","accounts_in_message":[],"_revision_number":1},{"id":"1e741d2588c366ac92529836e2d3da1ee8d9c2f6","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2019-06-07 17:38:10.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM, but I haven\u0027t given it a test-drive so just a +1 for now","accounts_in_message":[],"_revision_number":1},{"id":"e70b6dae970a06c6a78b87acae00b72bc8ecfc79","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-10-24 20:19:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9d2fe63b8f3d0e320033080323f57ca04e6ae7eb","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-10-24 20:23:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"86fb91bdc613d803bcba3962268d221aedb79176","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 20:31:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d75efae296894d4b8ed6a54927e2a96e : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d0a9a49372ca48a6a6e52e06ff44ff95 : SUCCESS in 4m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3373fc661f645d9a6500477e67f75b1 : SUCCESS in 7m 46s\n- openstack-tox-validate https://zuul.opendev.org/t/openstack/build/e5c101af9a054844985ef050e3fab352 : SUCCESS in 4m 57s\n- releases-tox-list-changes https://zuul.opendev.org/t/openstack/build/b79db0eefaaa41d29676b15457a82a91 : SUCCESS in 3m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f364ccb8393741dfb7b473284406616c : SUCCESS in 3m 45s","accounts_in_message":[],"_revision_number":3},{"id":"ea5c6f536581fe99b7b7f882117d0f20fb44d859","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-10-24 20:48:25.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"61078fc59a29230f5804d6d2a90548de75f5f342","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 21:03:19.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/efc05e0e154d435c842c65c51b73ad60 : SUCCESS in 4m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a26101c0b88443199220cce363a4d4c3 : SUCCESS in 4m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df993e1f3b5347639a617319b56f2cd1 : SUCCESS in 8m 48s\n- openstack-tox-validate https://zuul.opendev.org/t/openstack/build/66f4f54e003b4abfa9fc8f438e76c90d : SUCCESS in 4m 05s\n- releases-tox-list-changes https://zuul.opendev.org/t/openstack/build/3619885f3be245e7bd93db47fd426d3d : SUCCESS in 3m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f21ea535e1ce460fbce007146fadb3e2 : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":4},{"id":"a9100681e0d320a75889035566ffda7785449f57","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2019-10-25 12:41:52.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1056b96f174e230ce192a343b97f3d3aff7923cd","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-10-25 12:59:33.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"d9ac7278fb186ae4602c0893144314257804f5c6","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2019-10-28 14:12:30.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"e1ecc68c47da0c94f8d44a4f291f92f34376e0bb","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-31 19:28:09.000000000","message":"Patch Set 4: Code-Review+1\n\nTried this out locally, works pretty nice.\n\nHowever, I guess I would expect \"interactive\" to be more... interactive. Like for example, I wouldn\u0027t have to specify bugfix/feature/etc. on the CLI, but would be prompted instead, because I wouldn\u0027t know which I wanted until I had inspected the change list.\n\nOf course, that could always be changed later. We don\u0027t have to retain backward compatibility with this thing, do we?","accounts_in_message":[],"_revision_number":4},{"id":"f72198e1605dd80987f540f85a0f414fb05a3f79","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-31 19:30:29.000000000","message":"Patch Set 4:\n\n\u003e Like for example, I wouldn\u0027t have to specify bugfix/feature/etc. on the CLI, but would be prompted instead\n\n[Later] Oh, look, that\u0027s more like what interactive-release does.\n\nI guess we\u0027re converging on One Tool To Rule Them All eventually.","accounts_in_message":[],"_revision_number":4},{"id":"028ffc631682ff811ff5c9344393b4417cb22a09","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-11-14 03:32:40.000000000","message":"Patch Set 4:\n\n\u003e [Later] Oh, look, that\u0027s more like what interactive-release does.\n\nYeah ;P\n\n \u003e I guess we\u0027re converging on One Tool To Rule Them All eventually.\n\nI don\u0027t think we\u0027re quite there yet in terms of having one tool, but very few people know about interactive-release, them that do really like it ;P","accounts_in_message":[],"_revision_number":4},{"id":"52d2f450fb2c5c03cf926fe171b71343555f83f2","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-11-15 04:19:10.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"4eea486b211278d615aa786c81e650dca777af34","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-15 04:35:57.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9d70a9cee2754af094cd717e4b80e9fa : SUCCESS in 3m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f16168ce74684e39b3e83d424056b276 : SUCCESS in 4m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/218fa7e84c6c4badb9c1e6d15ac0610d : SUCCESS in 5m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9486ca0c036642349d3890e6a2b6985e : SUCCESS in 10m 21s\n- openstack-tox-validate https://zuul.opendev.org/t/openstack/build/15027e005ebb4f0b998b2d0d9aca15ac : SUCCESS in 4m 32s\n- releases-tox-list-changes https://zuul.opendev.org/t/openstack/build/e6f47842afa844c0a7c13f002dcaee10 : SUCCESS in 3m 44s","accounts_in_message":[],"_revision_number":5},{"id":"87502a57f9b61fb147ced8f86d9036706d35bb6c","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-11-15 08:43:17.000000000","message":"Patch Set 5: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"0cd71adc574b559d05e9a374348c5f8f703b5dca","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-11-15 14:38:00.000000000","message":"Patch Set 5: Code-Review-1\n\n(4 comments)\n\nUpdates appear to be lost, reintroducing some issues with this.","accounts_in_message":[],"_revision_number":5},{"id":"0ffbf923f3b5ac601ebb4e1019e4f03f015d8378","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-11-16 22:33:56.000000000","message":"Patch Set 5:\n\n\u003e (4 comments)\n \u003e \n \u003e Updates appear to be lost, reintroducing some issues with this.\n\nSorry I didn\u0027t notice you\u0027d updated and just rebased my local branch.  I\u0027ll fix things up next week,","accounts_in_message":[],"_revision_number":5},{"id":"8aafe363791c63636dcb5a502d44d7972e654fe2","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-11-18 01:34:38.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ad6f0539bdcbd26f77434339ef3bdc7ee23d2313","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-18 01:44:21.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d79769826a54b0b894d324b1b5401a9 : SUCCESS in 4m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/573a0e3112ee4497b797fe5663cfe106 : SUCCESS in 4m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/53f6a7407cec4ae18364d9cfdbfe91a6 : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f7ebe7d06f04ef49eb3e06ec5784072 : SUCCESS in 8m 05s\n- openstack-tox-validate https://zuul.opendev.org/t/openstack/build/6e50e857921f404297f97c2374f19ac8 : SUCCESS in 4m 05s\n- releases-tox-list-changes https://zuul.opendev.org/t/openstack/build/921db050e6ab4cf983eba3f871f5ebce : SUCCESS in 3m 23s","accounts_in_message":[],"_revision_number":6},{"id":"7794161bfe04b0dfed84460bb6649e4ad8e2cc6a","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-11-20 14:18:56.000000000","message":"Patch Set 6: Code-Review+1\n\n(2 comments)\n\nOk with the code. Not so sure about the idea behind the 100 (as it\u0027s not written in the commit message here). Generally positive improvement, so +1-ing it.","accounts_in_message":[],"_revision_number":6},{"id":"3c8a0088c3a78e0a6679a530fecd0faa5071886b","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-11-26 22:43:39.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"5fa7fcc2ed44631a17391b04a1e224b3f8888693","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-11-27 09:26:35.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"300d2e7d248d5669cc1c9485a0d8560b40733833","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-11-27 09:27:13.000000000","message":"Patch Set 6: Code-Review+2\n\nI haven\u0027t tested it manually, so I am not +w ing this yet. The code looks good at first sight though.","accounts_in_message":[],"_revision_number":6},{"id":"ecfe5368ba5c753944e60d9e653b7cdc349c5745","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-11-27 10:16:01.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"15e6cbe41f9ffd1fb797972c79b254113fa06f62","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2019-11-29 09:58:17.000000000","message":"Patch Set 6: Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"2e07086314f3d98fcb4228786c96b4177b6e1d32","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-29 09:58:29.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"511ebda6b4b508a9f465d7254095ca41647d08f0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-29 10:12:12.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8006614747864941b0c4c1f5fe352d3f : SUCCESS in 3m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/351e4ff632b746dcadda858fc7dd31b8 : SUCCESS in 4m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9c296eb006594eec8270ee77e8019170 : SUCCESS in 4m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6789d9a007af468fa76f5a7ac98606a0 : SUCCESS in 8m 30s\n- openstack-tox-validate https://zuul.opendev.org/t/openstack/build/92ef9b6cc43e4564822a706447ae0026 : SUCCESS in 5m 37s","accounts_in_message":[],"_revision_number":6},{"id":"d598389d64b20856b4fbafa98145225dbe43948c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-29 10:12:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"4cf2670c1fb36bfe93c4a3ea81f4aa10cfa42fd1","revisions":{"2eb4f5549d922d77010163ec3bd06ca50612af3b":{"kind":"REWORK","_number":1,"created":"2019-06-07 04:43:21.000000000","uploader":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"ref":"refs/changes/39/663839/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/1"}}},"commit":{"parents":[{"commit":"601d558220b29425e17e629f6237c123e153d3e8","subject":"Merge \"Drop traits and resource-classes train placeholders\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/601d558220b29425e17e629f6237c123e153d3e8"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-07 04:39:22.000000000","tz":600},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/2eb4f5549d922d77010163ec3bd06ca50612af3b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/2eb4f5549d922d77010163ec3bd06ca50612af3b"}]},"branch":"refs/heads/master"},"960c3bd36e297cbda1ba7ad2d948f02e193f4871":{"kind":"REWORK","_number":2,"created":"2019-10-24 20:19:27.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/39/663839/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/2"}}},"commit":{"parents":[{"commit":"c51552e1bc7862c70e66cf1f4045c784daa3c71f","subject":"Merge \"Release OpenStack-Ansible Queens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/c51552e1bc7862c70e66cf1f4045c784daa3c71f"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-10-24 20:17:14.000000000","tz":-300},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/960c3bd36e297cbda1ba7ad2d948f02e193f4871"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/960c3bd36e297cbda1ba7ad2d948f02e193f4871"}]},"branch":"refs/heads/master"},"d987e772b4f0e3711750fa507ff7567f8554827f":{"kind":"REWORK","_number":3,"created":"2019-10-24 20:23:39.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/39/663839/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/3"}}},"commit":{"parents":[{"commit":"c51552e1bc7862c70e66cf1f4045c784daa3c71f","subject":"Merge \"Release OpenStack-Ansible Queens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/c51552e1bc7862c70e66cf1f4045c784daa3c71f"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-10-24 20:23:33.000000000","tz":-300},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/d987e772b4f0e3711750fa507ff7567f8554827f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/d987e772b4f0e3711750fa507ff7567f8554827f"}]},"branch":"refs/heads/master"},"e5164317ba936de49d74a75a564e2285ae52d505":{"kind":"REWORK","_number":4,"created":"2019-10-24 20:48:25.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/39/663839/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/4"}}},"commit":{"parents":[{"commit":"c51552e1bc7862c70e66cf1f4045c784daa3c71f","subject":"Merge \"Release OpenStack-Ansible Queens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/c51552e1bc7862c70e66cf1f4045c784daa3c71f"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2019-10-24 20:48:18.000000000","tz":-300},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/e5164317ba936de49d74a75a564e2285ae52d505"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/e5164317ba936de49d74a75a564e2285ae52d505"}]},"branch":"refs/heads/master"},"b18dfd6765fa1acc3d01373531a5675e66b48768":{"kind":"REWORK","_number":5,"created":"2019-11-15 04:19:10.000000000","uploader":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"ref":"refs/changes/39/663839/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/5"}}},"commit":{"parents":[{"commit":"68e240e953fe908a81861dd12454c2e751e28f29","subject":"Merge \"Transition TripleO to Queens EM\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/68e240e953fe908a81861dd12454c2e751e28f29"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-11-14 22:35:44.000000000","tz":660},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/b18dfd6765fa1acc3d01373531a5675e66b48768"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/b18dfd6765fa1acc3d01373531a5675e66b48768"}]},"branch":"refs/heads/master"},"4cf2670c1fb36bfe93c4a3ea81f4aa10cfa42fd1":{"kind":"REWORK","_number":6,"created":"2019-11-18 01:34:38.000000000","uploader":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"ref":"refs/changes/39/663839/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/releases","ref":"refs/changes/39/663839/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/releases refs/changes/39/663839/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/releases refs/changes/39/663839/6"}}},"commit":{"parents":[{"commit":"2c0feab157f4ca3f98234c53c6dfb4da3a23cc54","subject":"Merge \"Skip jobs on data file only changes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/2c0feab157f4ca3f98234c53c6dfb4da3a23cc54"}]}],"author":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-06-06 11:39:32.000000000","tz":600},"committer":{"name":"Tony Breeds","email":"tony@bakeyournoodle.com","date":"2019-11-18 01:17:19.000000000","tz":660},"subject":"Add --interactive to new-releases","message":"Add --interactive to new-releases\n\nShamelessly steal^Wcopy some of the code from interactive-release so\nthat after validating the release we list the changes that will be\nreleased.  This gives us the ability to decide that the release\ncontains no functional changes and elect to not create that release.\n\nNOTE: I chose not to use interactive-release as it seems not to\ncorrectly handle first releases in a series (because it doesn\u0027t load all\nrelease history.  It also doesn\u0027t use some of the new features (like\nseries_status).  Adding --interactive to new-release gets us a long way\nto deprecating interactive-release but we aren\u0027t quire there yet.\n\nChange-Id: I25bbb4d7df9ae618500dd37f4b0cbc32c0bbd153\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/4cf2670c1fb36bfe93c4a3ea81f4aa10cfa42fd1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/releases/commit/4cf2670c1fb36bfe93c4a3ea81f4aa10cfa42fd1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}