)]}'
{"deliverables/stein/openstack-ansible.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a66a41d46ca60361c5fd6fc541cde2788ea33e87","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    projects:"},{"line_number":77,"context_line":"      - repo: openstack/openstack-ansible"},{"line_number":78,"context_line":"        hash: b22016a76db48a9c37cef298b83b2f1ecd4152f8"},{"line_number":79,"context_line":"  - version: 19.0.12"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/openstack-ansible"},{"line_number":82,"context_line":"        hash: a49c9fe89b2880f84fc7a0edbf33a6363c540662"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_1fc19a81","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":20},"updated":"2020-04-06 11:04:32.000000000","message":"Not sure what\u0027s `Bump SHAs for stable/stein` [1] but it seems to introduced some sort of new feature into a stable branch.\n\n```\nfeatures:\n  - |\n    Get ceph keyrings from files, if variable``ceph_keyrings_dir`` is defined\n    the keyrings will be extracted from files. All files in the directory\n    must have ``.keyring`` extention and be named with its corresponding\n    ``ceph_client`` name. For example, if ``cinder_ceph_client`` is ``cinder``\n    the cinder keyring file must be named ``cinder.keyring``.\n    Each file must contain username and the key and nothing more, below\n    an example for cinder.keyring content.\n    .. code-block:: text\n    [client.cinder]\n    key \u003d XXXXXXXXXXX\n```\n\nIntroduce new features on stable branches is something that we want to avoid, however openstack-ansible don\u0027t seem to follow the stable branch policy [2][3], so I think we can go further with these changes.\n\nHence if these changes really introduced a new feature then we should release a minore version (19.1.0 rather than 19.0.\n12).\n\nThoughts?\n\n[1] https://github.com/openstack/openstack-ansible/commit/f47f73c2b006f69c1f0e414729b607873d490e8b\n[2] https://github.com/openstack/governance/blob/master/reference/projects.yaml#L2154,L2258\n[3] https://governance.openstack.org/tc/reference/tags/stable_follows-policy.html","commit_id":"5fc2e81d9f60097b3b9d2d11d68d68bb5b19e0b7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"65d985be22e54599ac553a8505deedeb6e755245","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    projects:"},{"line_number":77,"context_line":"      - repo: openstack/openstack-ansible"},{"line_number":78,"context_line":"        hash: b22016a76db48a9c37cef298b83b2f1ecd4152f8"},{"line_number":79,"context_line":"  - version: 19.0.12"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/openstack-ansible"},{"line_number":82,"context_line":"        hash: a49c9fe89b2880f84fc7a0edbf33a6363c540662"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_776561e1","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":20},"in_reply_to":"df33271e_1fc19a81","updated":"2020-04-06 21:34:38.000000000","message":"This is a normal ansible thing. They need to update the sha\u0027s in the deployment project to pick up the corresponding projects at the correct location.\n\nSomeone from the team can probably explain it better than that, but that\u0027s the jist of it. :)","commit_id":"5fc2e81d9f60097b3b9d2d11d68d68bb5b19e0b7"}]}