)]}'
{"openstack_releases/cmds/list_unreleased_changes.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b149fc3e0610db1c7c2d6a0c63eeb0f5e32f4b0e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            branch \u003d \u0027master\u0027"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        if branch !\u003d \u0027master\u0027:"},{"line_number":269,"context_line":"            # Remove previously checkout repo (master)"},{"line_number":270,"context_line":"            # to avoid git clone issues"},{"line_number":271,"context_line":"            shutil.rmtree(os.path.join(workdir, repo), True)"},{"line_number":272,"context_line":"            # Check out the repo again to the right branch if we"},{"line_number":273,"context_line":"            # didn\u0027t get it the first time."},{"line_number":274,"context_line":"            gitutils.clone_repo("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b726e9b6","line":271,"range":{"start_line":269,"start_character":12,"end_line":271,"end_character":60},"updated":"2020-07-27 19:52:25.000000000","message":"I don\u0027t think we want to do this. This adds unnecessary delay, not to mention the potential for data corruption if one of our variables ends up being wrong.\n\nThe cloning operation will check if the repo is already present here:\n\nhttps://opendev.org/openstack/releases/src/commit/62c2fc43176363f8738effef20b72468d5190e34/tools/clone_repo.sh#L158\n\nThat\u0027s fine. Then it just knows that it does not need to attempt to do a full clone again.\n\nThen later on, it will make sure to fetch the latest:\n\nhttps://opendev.org/openstack/releases/src/commit/62c2fc43176363f8738effef20b72468d5190e34/tools/clone_repo.sh#L175-L177\n\nAnd then whether it had freshly cloned earlier or not, it goes into the local clone and checks out the requested branch:\n\nhttps://opendev.org/openstack/releases/src/commit/62c2fc43176363f8738effef20b72468d5190e34/tools/clone_repo.sh#L187\n\nSo we should not need to start from scratch.","commit_id":"893bd687cafa04a319f66a2d54fc37469d1fe909"}]}