)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"78e7272e48e61dd49cc19cedcfc6aefdccd08a6d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Needs depends-on to merge first for puppet-tripleo metadata bump"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/754347"},{"line_number":12,"context_line":"Change-Id: Ia2b655987b646b6d431892e22942ef1dc5849808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_cb3cd993","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2020-09-25 10:32:02.000000000","message":"we need this to merge for validate to pass\n\nhttps://3612101d6c142bf9c77a-c96c299047b55dcdeaefef8e344ceab6.ssl.cf1.rackcdn.com/754346/2/check/openstack-tox-validate/8ca5c7f/job-output.txt","commit_id":"9ce4280d799e6b0ceaa11809d43aadeb4b7da94c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e95f0027e51b80fb2c37ce9eea55977a99651232","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Needs depends-on to merge first for puppet-tripleo metadata bump"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/754347"},{"line_number":12,"context_line":"Change-Id: Ia2b655987b646b6d431892e22942ef1dc5849808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_5f723f13","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"9f560f44_bf827bfd","updated":"2020-09-25 14:07:55.000000000","message":"Please hold this patch with a -1 if needed and if you think that everything is not done on your side. Feel free to remove your vote when you think you are done, thanks.","commit_id":"9ce4280d799e6b0ceaa11809d43aadeb4b7da94c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1779414bb2c0e348abb06d11ec9331cc53a206","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Needs depends-on to merge first for puppet-tripleo metadata bump"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/754347"},{"line_number":12,"context_line":"Change-Id: Ia2b655987b646b6d431892e22942ef1dc5849808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_bf827bfd","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"9f560f44_cb3cd993","updated":"2020-09-25 13:59:18.000000000","message":"just discussed with weshay some more, we will go ahead with this.\n\nGoing to remove the depends-on but we will have to wait for that to merge before this will validate either way.","commit_id":"9ce4280d799e6b0ceaa11809d43aadeb4b7da94c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2a0b90addbc27e1b2918599ef5bf4715f36badca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marios Andreou \u003cmarios@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-28 10:11:00 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TripleO Victoria rc1 release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Needs the puppet-tripleo metadata bumpat [1] to merge first for validate"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_bcca724b","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":28},"updated":"2020-09-28 08:38:31.000000000","message":"http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017604.html\n\nthis isn\u0027t a proper rc1 since we aren\u0027t cutting the branch yet.\n\njust a tripleo release that coincides with the general victoria rc1 end of last week.","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"234b4ed532d8efbf0a034ade066ccbefc9a57c25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marios Andreou \u003cmarios@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-28 10:11:00 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TripleO Victoria rc1 release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Needs the puppet-tripleo metadata bumpat [1] to merge first for validate"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_1a643e48","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":28},"in_reply_to":"9f560f44_bcca724b","updated":"2020-09-28 10:59:26.000000000","message":"Thanks for the heads up.","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"}],"deliverables/victoria/os-net-config.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"234b4ed532d8efbf0a034ade066ccbefc9a57c25","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/os-net-config"},{"line_number":17,"context_line":"        hash: bca47783bc80999711084eefe499a6a1a9f3628e"},{"line_number":18,"context_line":"  - version: 12.6.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/os-net-config"},{"line_number":21,"context_line":"        hash: 933aaf80b14a100b1e5456b82536f8baf62ff01c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_9aab2e1c","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"updated":"2020-09-28 10:59:26.000000000","message":"test-requirements\u0027 bumps are in a grey area, a bugfix version would be enough too, however it\u0027s not a big deal and I think we can continue with a minor version.","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6681c6900963b76e6e46245a471c9cf545475670","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/os-net-config"},{"line_number":17,"context_line":"        hash: bca47783bc80999711084eefe499a6a1a9f3628e"},{"line_number":18,"context_line":"  - version: 12.6.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/os-net-config"},{"line_number":21,"context_line":"        hash: 933aaf80b14a100b1e5456b82536f8baf62ff01c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_b436f901","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"in_reply_to":"9f560f44_20d3d039","updated":"2020-09-29 06:11:16.000000000","message":"ACK and thank you for taking the time to explain","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0c7cb158b7b4d8f0597f75f5839bdc2381dd1cfd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/os-net-config"},{"line_number":17,"context_line":"        hash: bca47783bc80999711084eefe499a6a1a9f3628e"},{"line_number":18,"context_line":"  - version: 12.6.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/os-net-config"},{"line_number":21,"context_line":"        hash: 933aaf80b14a100b1e5456b82536f8baf62ff01c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d559f928","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"in_reply_to":"9f560f44_9aab2e1c","updated":"2020-09-28 11:18:26.000000000","message":"I used \u0027feature\u0027 for the release mainly because for all the projects that seems to be the precedent here e.g. this one goes 12.4 .5 .6.0 ... \n\nhmmm perhaps it makes more sense to use \u0027bugfix\u0027 * but then why not for all of these why just os-net-config in particular. \n\n\n* to be clear that would bump the .patch in maj.min.patch right?","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"13700371ad9d7e1e663fac70eb8c2e5c29a52efc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/os-net-config"},{"line_number":17,"context_line":"        hash: bca47783bc80999711084eefe499a6a1a9f3628e"},{"line_number":18,"context_line":"  - version: 12.6.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/os-net-config"},{"line_number":21,"context_line":"        hash: 933aaf80b14a100b1e5456b82536f8baf62ff01c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_20d3d039","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"in_reply_to":"9f560f44_d559f928","updated":"2020-09-28 16:08:39.000000000","message":"\u003e I used \u0027feature\u0027 for the release mainly because for all the\n \u003e projects that seems to be the precedent here e.g. this one goes\n \u003e 12.4 .5 .6.0 ... \n\nNo problem\n\n \u003e \n \u003e hmmm perhaps it makes more sense to use \u0027bugfix\u0027 * but then why not\n \u003e for all of these why just os-net-config in particular.\n\nNo, you can leave as it is, everything LGTM, I was more thinking out loud :) it seems to me that other tripleo\u0027s  projects are legit to deliver a minor version. Different supports have been added so a minor version is fine for them.\n\n \u003e \n \u003e \n \u003e * to be clear that would bump the .patch in maj.min.patch right?\n\nTo answer your question, yes that would bump the Z in X.Y.Z, but please feel free to leave as it is :)\n\nBelow are some more details about this, just for an explanation purpose.\n\nConsider X.Y.Z:\n- a major version will raise the X, it would be triggered by changes who drop the backward compatibility;\n- a minor version will raise the Y, it would be triggered by changes who introduce a new feature, a requirements who have been bumped;\n- a bugfix version will raise the Z, it would be triggered by changes who fix something.\n\nWith the changes in test-requirements (and testing requirements in general) minor and bugfix version can be used as this kind of requirements are not really used during the runtime and at the execution of the deliverable and so they don\u0027t impact the stability or the behavior of the deliverable during runtime. However these requirements can be bumped too and normally it should be reflected by a minor version by a strict semver. This is why we are in a grey area in this case.","commit_id":"43cca15e8525992f6c3bfba68d3421c64c960bf9"}]}