)]}'
{"deliverables/victoria/os-net-config.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-net-config"},{"line_number":29,"context_line":"        hash: 157df251cf9086cbc58315808ec2f59605626f81"},{"line_number":30,"context_line":"  - version: 13.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-net-config"},{"line_number":33,"context_line":"        hash: 7ba6feaac34a8bc329750bd8cf45c12593428ca8"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2f6ddf86_cd99eeda","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":19},"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/os-net-config/compare/13.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/puppet-tripleo.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    projects:"},{"line_number":27,"context_line":"      - repo: openstack/puppet-tripleo"},{"line_number":28,"context_line":"        hash: 4125e22dbc92bd54d64f0e119dd2a3ca5ef0d2a4"},{"line_number":29,"context_line":"  - version: 13.6.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/puppet-tripleo"},{"line_number":32,"context_line":"        hash: 856f4d9c2ef44ac738ce671d48f81d19d431e54c"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"90f88353_63542a2d","line":29,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/puppet-tripleo/compare/13.5.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"199b0388164638ebdb1ffa07d94702654086d759","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - version: 13.6.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/puppet-tripleo"},{"line_number":32,"context_line":"        hash: 856f4d9c2ef44ac738ce671d48f81d19d431e54c"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/victoria"},{"line_number":35,"context_line":"    location: 13.4.0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"de518819_0b577ad8","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"updated":"2021-04-06 15:48:33.000000000","message":"this is wrong... https://opendev.org/openstack/puppet-tripleo/commits/branch/stable/victoria \n\nIt tags at https://opendev.org/openstack/puppet-tripleo/commit/856f4d9c2ef44ac738ce671d48f81d19d431e54c\n\nit should be pointing instead to https://opendev.org/openstack/puppet-tripleo/commit/3a20150c009ce44f23eb0325abcb0ea01b3936a8\n\nsame issue discussed for train @ https://review.opendev.org/c/openstack/releases/+/784445/1#message-98a8c2640e195c10da9d95faf42ce90f9a9b23b8 \n\nI will fix it by re-tagging puppet-tripleo and then releasing a v13.6.1 :/","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/python-tripleoclient.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/python-tripleoclient"},{"line_number":29,"context_line":"        hash: 9644bea71e121a35b7348b2175b4526d78001401"},{"line_number":30,"context_line":"  - version: 14.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/python-tripleoclient"},{"line_number":33,"context_line":"        hash: c3017fbee3b1f515b0909518324e399f15e22c8a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0c86c199_b6e3a6c9","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/python-tripleoclient/compare/14.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-ansible.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-ansible"},{"line_number":29,"context_line":"        hash: fec1bacbe91c392b36a947e849ac4ebaeacc186d"},{"line_number":30,"context_line":"  - version: 2.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-ansible"},{"line_number":33,"context_line":"        hash: ac991db493587dcbcd9fad398ae99732bff07f81"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"610d07cb_62061f94","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/tripleo-ansible/compare/2.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-common.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":29,"context_line":"        hash: 0d12d835266569db082f731bce07ffdf7a64fe49"},{"line_number":30,"context_line":"  - version: 13.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":33,"context_line":"        hash: 81a5626997de34177fa84de3991370ebcc409d6e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c10c7592_fa48807f","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/tripleo-common/compare/13.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-heat-templates.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-heat-templates"},{"line_number":29,"context_line":"        hash: a414b1e0046ab11306ce9bae8c6c9c4c072834e7"},{"line_number":30,"context_line":"  - version: 13.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-heat-templates"},{"line_number":33,"context_line":"        hash: 856e7452765f95b418d5907b80fca990bde1c971"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"de1467ea_15aa0a13","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/tripleo-heat-templates/compare/13.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-image-elements.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f805e3dc26e91c8d81a59c5a89d5e648ea359df9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - version: 12.3.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e64b2177_ada01d92","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":54},"updated":"2021-03-30 08:20:25.000000000","message":"This one fail because he have 2 problems...\n\nThe first one victoria have never been branched... I think that we should start with that.\n\nThe second one problem is that this sha is already in use on wallaby and the version 13.0.0,\nso either you use a previous commit and we branch on it either we need some tricks like did on tripleo-ipsec etc... (gitreview file etc...)\n\nhttps://opendev.org/openstack/releases/src/branch/master/deliverables/wallaby/tripleo-image-elements.yaml#L10-L13","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c8d006502fcca29837dd8742e24ebdd53f7a789a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - version: 12.3.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dce90023_22b3f07c","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":54},"in_reply_to":"5f874767_cd5afe93","updated":"2021-03-30 16:03:55.000000000","message":"\u003e thank you for taking the time to comment here Herve this is very helpful\n\nMy pleasure Marios!\n\n\u003e \n\u003e I am very sorry for the missing branch I completely messed that up and missed this repo\n\nThat\u0027s not your fault, some pieces were missing on our side.\n\n\u003e \n\u003e Great that the new check has detected the duplicate tag here... so seems there is nothing new to release on that.\n\nWork for me, I think that we can simply drop 12.3.0 here.\n\n\u003e \n\u003e Can we simply add the stable/victoria branch on this review? I can use the first victoria tag here, which is 12.1.0 is that acceptable for the release tooling? I guess tox validate will tell us soon enough...\n\nYes we can add the stable branch here. I guess that our tooling won\u0027t complain as the we branch on an existing tag. My 2 cents on that!\n\n\u003e \n\u003e I will update here to do that ^^^ and just remove the 12.3.0 from here we don\u0027t need to make a release if there is nothing to release\n\nExcellent, we wait for your next PS.","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7666a4dd9ded1b5e61e41bb919767db2d7b293b0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - version: 12.3.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34d647d4_1cbb0583","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":54},"in_reply_to":"b82dc943_9a6ccdef","updated":"2021-03-30 16:51:13.000000000","message":"Ok no problem, let\u0027s go with 12.2.1","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c16a31cade36935a6d0831a9c284bf1a67fae609","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - version: 12.3.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b82dc943_9a6ccdef","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":54},"in_reply_to":"dce90023_22b3f07c","updated":"2021-03-30 16:08:53.000000000","message":"thanks for the quick reply\n\nit seems i can\u0027t use the 12.2.1 the tooling requires it to be the \u0027latest released\u0027 so will use the 12.2.0 instead \n\n1 errors found\ndeliverables/victoria/tripleo-image-elements.yaml: validate_stable_branches: stable branches must be created from the latest tagged release, and 12.1.0 for stable/victoria does not match 12.2.0","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be7f833e5d85ee20f82251a37471ffad4aba1b4a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - version: 12.3.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f874767_cd5afe93","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":54},"in_reply_to":"e64b2177_ada01d92","updated":"2021-03-30 15:44:48.000000000","message":"thank you for taking the time to comment here Herve this is very helpful\n\nI am very sorry for the missing branch I completely messed that up and missed this repo\n\nGreat that the new check has detected the duplicate tag here... so seems there is nothing new to release on that.\n\nCan we simply add the stable/victoria branch on this review? I can use the first victoria tag here, which is 12.1.0 is that acceptable for the release tooling? I guess tox validate will tell us soon enough...\n\nI will update here to do that ^^^ and just remove the 12.3.0 from here we don\u0027t need to make a release if there is nothing to release","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f3f12a90114259db59775054f74d2bb73f3b3a8f","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        hash: c1a598f643748f84b802dbb12fdaf74a1819bba6"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/victoria"},{"line_number":20,"context_line":"    location: 12.2.0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8308a162_b51f6d83","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":20},"updated":"2021-03-31 12:28:29.000000000","message":"LGTM","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-puppet-elements.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b6ff5c1887f932c1fe9590295fd29017dd8c6a4d","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":29,"context_line":"        hash: 0c080b2bc3b3d7ac2795209de3b4830a7ed9ea12"},{"line_number":30,"context_line":"  - version: 13.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":33,"context_line":"        hash: 5ecf624b6aaeb6c29b8a2b5ce04b75bcd00cf81b"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87e41c6d_c6a0f9bf","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":17},"updated":"2021-03-30 15:59:40.000000000","message":"going to revise this one too there is only one commit so let\u0027s just make it 13.1.1 instead of 13.2.0\n\nhttps://github.com/openstack/tripleo-puppet-elements/compare/13.1.0...stable/victoria","commit_id":"dc615ffcc9555f615c7d1baf1ee94e667fd7a2b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":29,"context_line":"        hash: 0c080b2bc3b3d7ac2795209de3b4830a7ed9ea12"},{"line_number":30,"context_line":"  - version: 13.1.1"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":33,"context_line":"        hash: 5ecf624b6aaeb6c29b8a2b5ce04b75bcd00cf81b"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7724adf2_7ec0d10a","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/tripleo-puppet-elements/compare/13.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}],"deliverables/victoria/tripleo-validations.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c02409fb6f84b53831f4e6aab88517160265ff11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/tripleo-validations"},{"line_number":29,"context_line":"        hash: 3977997c352d7195ff3ea6d16b3a7b364b4bd379"},{"line_number":30,"context_line":"  - version: 13.2.0"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-validations"},{"line_number":33,"context_line":"        hash: d2904eb2d5516f2bf5350c4fc12ea1ad3240c778"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"30994d86_d333e38a","line":30,"updated":"2021-03-30 16:12:15.000000000","message":"https://github.com/openstack/tripleo-validations/compare/13.1.0...stable/victoria","commit_id":"735399292685bd7eeee29a33f779e172280c577f"}]}