)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"588b5a3573c955ac717d0be8716b9a154d821082","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.opendev.org/c/openstack/releases/+/785670"},{"line_number":14,"context_line":"[2] https://review.opendev.org/c/openstack/puppet-tripleo/+/788506"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia064530696cb5c47b009967f665900c2dd06d44e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fc6b702f_4c4399eb","line":15,"updated":"2021-05-04 12:34:15.000000000","message":"some notes for reviewers aid:\n \nhttps://github.com/openstack/os-net-config/compare/14.0.0...master\nhttps://github.com/openstack/puppet-tripleo/compare/14.0.0...master\nhttps://github.com/openstack/python-tripleoclient/compare/16.0.0...master\nhttps://github.com/openstack/tripleo-ansible/compare/3.0.0...master\nhttps://github.com/openstack/tripleo-common/compare/14.0.0...master\nhttps://github.com/openstack/tripleo-heat-templates/compare/14.0.0...master\nhttps://github.com/openstack/tripleo-image-elements/compare/13.0.0...master\nhttps://github.com/openstack/tripleo-puppet-elements/compare/14.0.0...master\nhttps://github.com/openstack/tripleo-validations/compare/14.0.0...master\n \nfor some of these it warrants a major bump. For puppet-tripleo in particular please see the discussion at [1]. More generally for TripleO we bump major at the start of the cycle, i.e. on the first release of that new branch and then keep that major number to represent that release.\n \nThis is why we are bumping the .minor here since the first wallaby release for all of these was done with [2] and we bumped major for all the repos at that point.\n \nFor tripleoclient and tripleo-common, we branched earlier with [3] - due to some discussion there [4] we decided to *bump major again* so those two are the exception.\n \nIf there is pushback against this proposal as it stands, then we can consider bumping major again for those repos that warrant it (see the compare links above, not all do), but not for puppet-tripleo per discussion at [1].\n \nthanks for your reviews.\n \n[1] https://review.opendev.org/c/openstack/puppet-tripleo/+/788506/2#message-45ed9c45e94395a3fe5e308b939357c4c22978d5\n[2] https://review.opendev.org/c/openstack/releases/+/771830\n[3] https://review.opendev.org/c/openstack/releases/+/785670\n[4] https://review.opendev.org/c/openstack/releases/+/785670/2#message-841556ade61982c2c7ad27bc361c25d44b06cd3b","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/puppet-tripleo.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/puppet-tripleo"},{"line_number":12,"context_line":"        hash: 58135e095ce1726257bf5e9a1a28f8987c5688f1"},{"line_number":13,"context_line":"  - version: 14.1.0"},{"line_number":14,"context_line":"    projects:"},{"line_number":15,"context_line":"      - repo: openstack/puppet-tripleo"},{"line_number":16,"context_line":"        hash: b8d1045be6cc427d202297377370f7337ea0bb84"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b52ecf3e_5c87a418","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"Quickly looking at the patches it seems a major version bump would be more appropriate. reno/semver also suggest that [1][2]. But according to Marios\u0027 comment[3], this is how the team wants it. So this is OK.\n\n[1] https://zuul.opendev.org/t/openstack/build/76592fa784af4b1fa5c326ceea98d909/log/tox/list-changes-results.log#534\n[2] https://zuul.opendev.org/t/openstack/build/76592fa784af4b1fa5c326ceea98d909/log/tox/list-changes-results.log#1589-1602\n[3] https://review.opendev.org/c/openstack/releases/+/789558/1#message-588b5a3573c955ac717d0be8716b9a154d821082","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/python-tripleoclient.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/python-tripleoclient"},{"line_number":17,"context_line":"        hash: 50afcda1d0180b2848b5a7345ae775eb8cf6fd50"},{"line_number":18,"context_line":"  - version: 16.1.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/python-tripleoclient"},{"line_number":21,"context_line":"        hash: f2f40a98e4ad0f994a05001a4bd295d1a4fdd160"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"edd1ab29_632ac264","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"Minor version bump (or even the release) is not needed here, given only a single commit that modifies the .gitreview file [1], but if I understand correctly Marios\u0027 comment, this is intentionally 16.1.0 (instead of 16.0.1)\n\n[1] https://zuul.opendev.org/t/openstack/build/76592fa784af4b1fa5c326ceea98d909/log/tox/list-changes-results.log#2209","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/tripleo-common.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":17,"context_line":"        hash: 25e1e24273d7741624382da4cc9f739482ea6ac4"},{"line_number":18,"context_line":"  - version: 15.1.0"},{"line_number":19,"context_line":"    projects:"},{"line_number":20,"context_line":"      - repo: openstack/tripleo-common"},{"line_number":21,"context_line":"        hash: 6c200096dbad355a1d04d876c99e7968a900b942"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9a0d93f_78656ea3","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"Just as with python-tripleoclient, minor version bump is not needed here I think (should be 15.0.1), but same applies as there, the team wants here a minor version bump, if I understand correctly.","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"ea7563eb5b7af599975505ff91d49bb659ef8c00","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        hash: 6c200096dbad355a1d04d876c99e7968a900b942"},{"line_number":22,"context_line":"branches:"},{"line_number":23,"context_line":"  - name: stable/wallaby"},{"line_number":24,"context_line":"    location: 15.0.0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e0b47adc_779b7493","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":20},"updated":"2021-05-04 17:48:00.000000000","message":"Version update not needed?","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d05e536da698c9c703a5b7f3ee0be407cf3cef7d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        hash: 6c200096dbad355a1d04d876c99e7968a900b942"},{"line_number":22,"context_line":"branches:"},{"line_number":23,"context_line":"  - name: stable/wallaby"},{"line_number":24,"context_line":"    location: 15.0.0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"82af3fe7_3c02c25c","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":20},"in_reply_to":"e0b47adc_779b7493","updated":"2021-05-05 06:15:59.000000000","message":"Thanks for checking\n no we don\u0027t need to bump because we already released stable wallaby for tripleo-common on tag 15.0.0 there https://review.opendev.org/c/openstack/releases/+/785670\n\n\nexplained there https://review.opendev.org/c/openstack/releases/+/789558/1#message-588b5a3573c955ac717d0be8716b9a154d821082 (python-tripleoclient and tripleo-common are the exception as we branched those already for our testing)","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/tripleo-heat-templates.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/tripleo-heat-templates"},{"line_number":33,"context_line":"        hash: 5a4904114380def42b4c3e988db7ea0a7035bd2e"},{"line_number":34,"context_line":"  - version: 14.1.0"},{"line_number":35,"context_line":"    projects:"},{"line_number":36,"context_line":"      - repo: openstack/tripleo-heat-templates"},{"line_number":37,"context_line":"        hash: 5fd7b3c9f6d326260c4af54cffbdc9248e16a7c1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"effbc53b_3b42e1d5","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"According to reno/semver this should be major version bump, but if I understand correctly the team wants it this way, only minor version bump.","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/tripleo-image-elements.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    projects:"},{"line_number":12,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":13,"context_line":"        hash: d072a79acf52a87333fa663059eb769009b8fb4e"},{"line_number":14,"context_line":"  - version: 13.1.0"},{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-image-elements"},{"line_number":17,"context_line":"        hash: c69ead8b45d28befc693a5d0583868cef501ff25"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7be2d78f_c5a7be9d","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"This also seems to be better versioned as 13.0.1, meaning that only bump patch version, as there is only CI related changes. But again, as far as I understand the team wants it this way.","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}],"deliverables/wallaby/tripleo-puppet-elements.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d071ca0cf1edc4e2d79d9e642e3cf84092afe694","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    projects:"},{"line_number":12,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":13,"context_line":"        hash: ad31a402117851eddb288f43c39e7944127376bd"},{"line_number":14,"context_line":"  - version: 14.1.0"},{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-puppet-elements"},{"line_number":17,"context_line":"        hash: 5c4be3e15876f3a1e3fd8a6a4737decf18914161"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"36f94237_a0a95491","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":19},"updated":"2021-05-05 14:50:44.000000000","message":"Same as above, according to the single change, this more looks like 14.0.1, but as I understand the team wants it like this.","commit_id":"468f5a171ad5cc75bdd6ac8823eda866f583b5f7"}]}