)]}'
{"deliverables/train/cinder.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"090455ec59f3aaef1ef5e41cbfe229477ca4fafd","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: a75f8633b4e8e4256f1309cb2fdc0699f8a3c3e0"},{"line_number":58,"context_line":"  - version: 15.5.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: daa211e28e790e3047444f0dcb5a0d26adb92dac"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aa959ce6_e3c9a0f8","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"updated":"2021-05-11 11:13:03.000000000","message":"Just to double-check: there are patches that might warrant minor version bump in my opinion, for example: I5e35de28007558267f9215cbac03a38d7c74612c and I2a521118598de336148a56c1d5352107ece80721. Are you sure that version bump is good as it is?","commit_id":"e995b050703bd70ed942c07fb066240ed5ae9568"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ce6571f6856b606c69b50c30f0fd171115f63565","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: a75f8633b4e8e4256f1309cb2fdc0699f8a3c3e0"},{"line_number":58,"context_line":"  - version: 15.5.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: daa211e28e790e3047444f0dcb5a0d26adb92dac"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"67061a2a_d2a6860f","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"4b9bf004_2010449b","updated":"2021-05-12 12:56:57.000000000","message":"I agree with Elod, IMO a minor version is required by I2a521118 due to the new config option even if the main goal of this patch is to fix something.","commit_id":"e995b050703bd70ed942c07fb066240ed5ae9568"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3e94312a11eb9eddac65bd606665c5812e43e132","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: a75f8633b4e8e4256f1309cb2fdc0699f8a3c3e0"},{"line_number":58,"context_line":"  - version: 15.5.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: daa211e28e790e3047444f0dcb5a0d26adb92dac"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f033f68c_ddc21529","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"67061a2a_d2a6860f","updated":"2021-05-12 14:07:44.000000000","message":"I agree with Brian given that it is in a driver but if there are strong opinions from the community here I am fine with a minor version bump.","commit_id":"e995b050703bd70ed942c07fb066240ed5ae9568"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"514d383b342cec900905b6067b223baa5372746a","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: a75f8633b4e8e4256f1309cb2fdc0699f8a3c3e0"},{"line_number":58,"context_line":"  - version: 15.5.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: daa211e28e790e3047444f0dcb5a0d26adb92dac"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4b9bf004_2010449b","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"aa959ce6_e3c9a0f8","updated":"2021-05-11 18:31:45.000000000","message":"Thanks for the careful review.  I can see an argument for I2a521118 because it exposes a new configuration option for the driver.  But it\u0027s confined to a single driver and not cinder itself, so I think of it as more of a bugfix.\n\nI\u0027ll ping Sean and Jay to take another look and see what they think.","commit_id":"e995b050703bd70ed942c07fb066240ed5ae9568"}]}