)]}'
{"deliverables/stein/tripleo-ansible.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e87c215e326dcdcf71f2bd8f737248206a9570f1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ansible"},{"line_number":17,"context_line":"        hash: 6bbc8dfc2f8dd8f8c04ab963d63617e7ec9ef1b8"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a3cb81af_625518da","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"updated":"2021-07-01 10:23:58.000000000","message":"seems this will create stable/stein again, in past we removed it due to  issues in CI https://review.opendev.org/c/openstack/releases/+/718468, without adding is it complaining?\nanyway with making it EOL i assume both promotion and upstream jobs are going to be dropped so even if branch get\u0027s created shouldn\u0027t be an issue. \n\nalso not sure if branch deletion is now automated or not, in past it used to be manual and work was being done to automate.","commit_id":"f64317de07bc1f6de88869ea2e0a16482d17404d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6370faa3e348280e8fa0869689e50c571a621de8","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ansible"},{"line_number":17,"context_line":"        hash: 6bbc8dfc2f8dd8f8c04ab963d63617e7ec9ef1b8"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eaae6baf_c19935a1","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"in_reply_to":"3b2650f7_be063e82","updated":"2021-07-05 15:19:10.000000000","message":"ack OK i will remove this thank you Yatin and Herve for the review and comments","commit_id":"f64317de07bc1f6de88869ea2e0a16482d17404d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"71a7b485d6dc4031a7405bf60d659b1666738729","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ansible"},{"line_number":17,"context_line":"        hash: 6bbc8dfc2f8dd8f8c04ab963d63617e7ec9ef1b8"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3b2650f7_be063e82","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"in_reply_to":"a3cb81af_625518da","updated":"2021-07-02 13:54:11.000000000","message":"During Wallaby we added some tools to handle branches deletions, however, we need to run it manually in specific circumstances (series EOLing, etc...). We no longer rely on the infra team to manage this point, we only inform them before just in case.\n\nSo, adding these lines isn\u0027t an issue for our tooling, however it is totally useless at this point because we will add it to remove it just after.","commit_id":"f64317de07bc1f6de88869ea2e0a16482d17404d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"11b5e12b4a6bdd088a5dc922fe08fdfedfeb0f24","unresolved":true,"context_lines":[{"line_number":2,"context_line":"artifact-link-mode: none"},{"line_number":3,"context_line":"launchpad: tripleo"},{"line_number":4,"context_line":"release-model: cycle-with-intermediary"},{"line_number":5,"context_line":"team: tripleo"},{"line_number":6,"context_line":"type: other"},{"line_number":7,"context_line":"repository-settings:"},{"line_number":8,"context_line":"  openstack/tripleo-ansible: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"49c932f3_021f77eb","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":13},"updated":"2021-07-19 18:02:34.000000000","message":"This one is also the team\u0027s repository. Could you please add the EOL tag to this one as well? Thanks in advance :)","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"199be12fa1958ccbe82e89a00de9970ff358a65d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"artifact-link-mode: none"},{"line_number":3,"context_line":"launchpad: tripleo"},{"line_number":4,"context_line":"release-model: cycle-with-intermediary"},{"line_number":5,"context_line":"team: tripleo"},{"line_number":6,"context_line":"type: other"},{"line_number":7,"context_line":"repository-settings:"},{"line_number":8,"context_line":"  openstack/tripleo-ansible: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8cb9a25a_e47e7060","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":13},"in_reply_to":"21eac017_ea7556e5","updated":"2021-07-20 12:39:25.000000000","message":"ohh, I missed that...  and the fact that there\u0027s no stable/stein for tripleo-ansible. sorry, my bad :X","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b33489dbde1e65d9426529ddb2c20c1ee822aff9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"artifact-link-mode: none"},{"line_number":3,"context_line":"launchpad: tripleo"},{"line_number":4,"context_line":"release-model: cycle-with-intermediary"},{"line_number":5,"context_line":"team: tripleo"},{"line_number":6,"context_line":"type: other"},{"line_number":7,"context_line":"repository-settings:"},{"line_number":8,"context_line":"  openstack/tripleo-ansible: {}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"21eac017_ea7556e5","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":13},"in_reply_to":"49c932f3_021f77eb","updated":"2021-07-20 11:28:23.000000000","message":"no there is no stable/stein branch created for this project https://github.com/openstack/tripleo-ansible/branches \n\nI had it in v1 of this patch but removed after the discussion there https://review.opendev.org/c/openstack/releases/+/798925/1/deliverables/stein/tripleo-ansible.yaml#20","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"}],"deliverables/stein/tripleo-image-elements.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"11b5e12b4a6bdd088a5dc922fe08fdfedfeb0f24","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - hash: aa19a7f92af8d7683b84221550f3850ceec85363"},{"line_number":16,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":17,"context_line":"    version: 10.1.0"},{"line_number":18,"context_line":"  - projects:"},{"line_number":19,"context_line":"      - hash: a7679feb869ab8cca1f8a434d47ed8bf633307f7"},{"line_number":20,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"    version: 10.2.0"},{"line_number":22,"context_line":"  - projects:"},{"line_number":23,"context_line":"      - hash: 97dc7498602607c5e4d8e61de37713da4df7fd16"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"028f2fba_ec46330a","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"updated":"2021-07-19 18:02:34.000000000","message":"I see, that you are trying to create here the branch, but I think this is not necessary: the purpose of EOL is to remove the branch to not to be able to push patches against. If the branch does not exist then we don\u0027t need to do anything.","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b33489dbde1e65d9426529ddb2c20c1ee822aff9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - hash: aa19a7f92af8d7683b84221550f3850ceec85363"},{"line_number":16,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":17,"context_line":"    version: 10.1.0"},{"line_number":18,"context_line":"  - projects:"},{"line_number":19,"context_line":"      - hash: a7679feb869ab8cca1f8a434d47ed8bf633307f7"},{"line_number":20,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"    version: 10.2.0"},{"line_number":22,"context_line":"  - projects:"},{"line_number":23,"context_line":"      - hash: 97dc7498602607c5e4d8e61de37713da4df7fd16"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1bf72f3f_16b50825","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"in_reply_to":"028f2fba_ec46330a","updated":"2021-07-20 11:28:23.000000000","message":"I don\u0027t understand what you mean here can you please explain again? \n\nThere *is* a stable/stein for this project already https://github.com/openstack/tripleo-image-elements/tree/stable/stein (as seen below line 43/47 tagged at 10.4.0 ).\n\nI don\u0027t follow what you mean about \u0027trying to create here the branch\u0027.","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"199be12fa1958ccbe82e89a00de9970ff358a65d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - hash: aa19a7f92af8d7683b84221550f3850ceec85363"},{"line_number":16,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":17,"context_line":"    version: 10.1.0"},{"line_number":18,"context_line":"  - projects:"},{"line_number":19,"context_line":"      - hash: a7679feb869ab8cca1f8a434d47ed8bf633307f7"},{"line_number":20,"context_line":"        repo: openstack/tripleo-image-elements"},{"line_number":21,"context_line":"    version: 10.2.0"},{"line_number":22,"context_line":"  - projects:"},{"line_number":23,"context_line":"      - hash: 97dc7498602607c5e4d8e61de37713da4df7fd16"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a2125ad0_7914365c","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"in_reply_to":"1bf72f3f_16b50825","updated":"2021-07-20 12:39:25.000000000","message":"I don\u0027t know how this comment ended up here, as I\u0027m commented it for tripleo-ipsec.yaml :-o\nweird... very weird... :S","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"}],"deliverables/stein/tripleo-ipsec.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"11b5e12b4a6bdd088a5dc922fe08fdfedfeb0f24","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - version: stein-eol"},{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ipsec"},{"line_number":17,"context_line":"        hash: b5559c8c8669638f311f1c57d2d2a87f0202cddf"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c675f0d3_8136221f","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":54},"updated":"2021-07-19 18:02:34.000000000","message":"This is wrong, this is from master branch. Besides, tripleo-ipsec does not have a stable/stein branch [1]. Please remove this.\n\nhttps://opendev.org/openstack/tripleo-ipsec","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b33489dbde1e65d9426529ddb2c20c1ee822aff9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - version: stein-eol"},{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ipsec"},{"line_number":17,"context_line":"        hash: b5559c8c8669638f311f1c57d2d2a87f0202cddf"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6fd5798a_22e05f03","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":54},"in_reply_to":"c675f0d3_8136221f","updated":"2021-07-20 11:28:23.000000000","message":"ack thank you removing this","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"199be12fa1958ccbe82e89a00de9970ff358a65d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/tripleo-ipsec"},{"line_number":17,"context_line":"        hash: b5559c8c8669638f311f1c57d2d2a87f0202cddf"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/stein"},{"line_number":20,"context_line":"    location: stein-eol"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f9ed0319_ec9abb39","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":23},"updated":"2021-07-20 12:39:25.000000000","message":"The misplaced comment was originally meant to this section.","commit_id":"4fc83972993aa98595e670d3c1a2fbf2f095abec"}]}