)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2bda20264a9629bba53d9ad61c1df4519c2b44f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2428141a_a3221b57","updated":"2021-11-03 22:06:59.000000000","message":"Carlos, \n\nWe added a \"minor\" version bump when we released corresponding code in the ussuri branch: https://review.opendev.org/c/openstack/releases/+/802075/1/deliverables/ussuri/manila-ui.yaml\n\nCan you bump this up to 5.1.0 instead?","commit_id":"d6fe85be74b099bece285a1c5d009a3330308595"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8d12318cbd90ca1933b2af475f453df483f87eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c30a9cb_fccae54a","in_reply_to":"2428141a_a3221b57","updated":"2021-11-05 20:07:57.000000000","message":"Thanks for the review. Updated in the latest PS","commit_id":"d6fe85be74b099bece285a1c5d009a3330308595"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e99d7359f75a8bd6ba5d6eb2d2cb9b3c0e1f1524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2aaaf7dc_d3b8bef4","updated":"2021-11-07 14:23:33.000000000","message":"Just to comment with a \u0027stable maintainer hat\u0027 on: patch [1] that removes nova networking is a \u0027feature\u0027 and also introduced backward incompatibility. This is clearly a patch that shouldn\u0027t be backported to older branches and against the stable policy as this could cause pain for consumers.\n\nThen from release management point of view: the mentioned change ([1]) would require a MAJOR version bump as it introduces backward compatibility, which is only possible on master branch. This also indicates that the given patch should not be backported.\n\nI do understand that the deprecation happened in Ocata, but I think these kind of changes are really for new feature releases and not to introduce on stable releases.\n\n[1] I92e87282020047c7fad055cae92f2382c4193597","commit_id":"5564a5cdb56776375bbed4916ff204b21f808776"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dbb3664c9f516177470c1d4866425b974f5ff4b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f2f3faa_43dda362","updated":"2021-11-05 21:08:34.000000000","message":"Thank you Carlos - The version bump LGTM!","commit_id":"5564a5cdb56776375bbed4916ff204b21f808776"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db9cccfebe7e05907d8ecf6b017b83f72c8f9913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b08eb120_b1a0c0a9","in_reply_to":"2aaaf7dc_d3b8bef4","updated":"2021-11-08 18:43:41.000000000","message":"Hi Elod, \n\nAs the commit message in I92e87282020047c7fad055cae92f2382c4193597 suggests - the team considers the commit to be dead code removal. \n\nThe code that was removed was behind conditions that wouldn\u0027t be triggered since deployments wouldn\u0027t have nova networks; Nova hard-dropped the nova-networking option in Stein. Manila removed all nova-networking support in Ocata as you note. Hence, this should have no impact on consumers. Removing this dead code was necessary refactoring to enhance some form handling for neutron networking (https://review.opendev.org/c/openstack/manila-ui/+/796547).\n\nRationalizing this a bit more:\n\nmanila-ui is a horizon plugin - horizon allows speaking to a cloud that\u0027s older than it is, sure - but, we don\u0027t expect someone running the wallaby to run against a cloud that\u0027s as old as Ocata. There are other things that will break if they attempt to. Fundamentally - here\u0027s where we request a particular micro-version of the manila API: https://opendev.org/openstack/manila-ui/src/branch/stable/wallaby/manila_ui/api/manila.py#L31 --- a version that\u0027s only available since the Rocky release (https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html). So, categorically, manila-ui from this branch *cannot* support anyone that\u0027s using it to speak to an Ocata cloud. \n\nSo are we looking at a theoretical impact on backwards incompatibility here?","commit_id":"5564a5cdb56776375bbed4916ff204b21f808776"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"eb9c5e4a413869d25e185f973b35559a006e2316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcd6efdf_49df098d","in_reply_to":"b08eb120_b1a0c0a9","updated":"2021-11-08 19:53:37.000000000","message":"Hi Goutham,\n\nThanks for explaining the details behind the patch. As it is about \u0027dead code removal\u0027, I understand now the situation and thus the release looks OK to me.","commit_id":"5564a5cdb56776375bbed4916ff204b21f808776"}]}