)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6067b259a641d0a033c2034cfd177a406b3f3d16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a66403e_7f06a53d","updated":"2022-02-17 18:59:03.000000000","message":"@Elod: see inline comment.","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"4bd5e2623b23692ff442c595bb152417bbb86b61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ef32c42_e0500c1c","updated":"2022-02-17 17:06:35.000000000","message":"Can you check my comment, please? Did I misunderstand the content of the release?","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cae45284ec90ad4af43a1416bfff35223aec6329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6458d415_2b356cb7","updated":"2022-03-04 17:25:33.000000000","message":"Sorry about the delay responding to this; see comment inline.","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f2201c739443cc3f16ae69a457d6adac2736764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7059c75_45ed57e8","updated":"2022-02-17 16:30:50.000000000","message":"Verified release versions and hashes.","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"}],"deliverables/wallaby/os-brick.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"4bd5e2623b23692ff442c595bb152417bbb86b61","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8ec5422d_f203ee83","line":30,"updated":"2022-02-17 17:06:35.000000000","message":"Hmm, there is a change that has some default config change [1] if I understand correctly. If that is true, then this is not fortunate to release on stable branches. Especially not with a PATCH version bump :S (Though there is no other option as 4.4.0 is used in xena)\n\n[1] https://zuul.opendev.org/t/openstack/build/7a7db2589be847ccb6f5bee32975875c/log/tox/list-changes-results.log#1500-1503","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"da9347a4651dff6ca3148f46e12dbf4839a8b94a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e3cb2822_64a421f6","line":30,"in_reply_to":"5e3c3bd0_7f4a4aaf","updated":"2022-02-22 16:58:31.000000000","message":"Thanks @Brian for the explanation. So this kind of need an exception from stable policy then as I understand. Which is OK to me, if cinder team is also OK with it. \n(About the prelude: maybe the Upgrade Notes are enough, no need for a prelude).\nAnd by the way, sorry for not commenting these to the first release patch (stable/xena).\n\nMaybe one thing:\n@Sean if you are around: could you please review this patch from Cinder / stable-maint-core / and release manager perspectives as well? o: )","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6067b259a641d0a033c2034cfd177a406b3f3d16","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5e3c3bd0_7f4a4aaf","line":30,"in_reply_to":"8ec5422d_f203ee83","updated":"2022-02-17 18:59:03.000000000","message":"Yeah, I don\u0027t know what to do about this one.  We aren\u0027t changing the default value, but by switching to file locks, the default value is no longer appropriate (which I guess sort of amounts to the same thing as changing the default?).  The problem is that there isn\u0027t a sensible default value for this option:\n\n  # Directory to use for lock files.  For security, the specified directory\n  # should only be writable by the user running the processes that need locking.\n  # Defaults to environment variable OSLO_LOCK_PATH. If external locks are used,\n  # a lock path must be set. (string value)\n  #lock_path \u003d \u003cNone\u003e\n\nAnd you\u0027re right that only being able to use a patch version bump is a problem.  At least it shows up right at the top of the release notes:\n\nhttps://docs.openstack.org/releasenotes/os-brick/wallaby.html\n\nThe only other thing I can think of is that we could add a prelude to the release notes (though it would say, \"Make sure you read the Upgrade Notes\").","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cae45284ec90ad4af43a1416bfff35223aec6329","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfe05c1b_01dfab2c","line":30,"in_reply_to":"a94e39cb_dcaa079c","updated":"2022-03-04 17:25:33.000000000","message":"Thanks Sean and Elod.  Here\u0027s the situation.\n\nThe instructions:\n\"In the [oslo_concurrency] section, configure the lock path:\"\noccur in these installation guides:\n\nNova: Install and configure a controller node\nNova: Install and configure a compute node\nCinder: Install and configure controller node\nCinder: Install and configure a storage node\n\n... back through at least Pike (all branches before pike have been deleted from os-brick so we can\u0027t possibly backport this change farther than that).  So anyone following the instructions will have a value set for this option, which is used for some other functionality (not just this particular change). Hence it\u0027s unlikely that anyone will be running os-brick in an environment where lock_path isn\u0027t already set.\n\nSo to answer Jeremy\u0027s question from the release team meeting, the impact to someone who hasn\u0027t hit the bug addressed by this backported fix *and* who doesn\u0027t read the release notes should be basically no impact because they\u0027ve already been setting that option for other functionality.","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"5a1b0c3d03dc3a5ad2470b7103dee425dc01ac55","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"87fa26df_b39542d1","line":30,"in_reply_to":"dfe05c1b_01dfab2c","updated":"2022-03-04 19:13:45.000000000","message":"Thanks for checking the things thoroughly and for sharing the details here. Considering all these I\u0027m OK to +2 the patch!","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"29a77a02725760f414f6e05a44b509909c6b29e6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff5b4cae_5dd78aee","line":30,"in_reply_to":"e3cb2822_64a421f6","updated":"2022-02-26 13:35:23.000000000","message":"I think the good thing here is most deployers will probably not need to care about this setting. It\u0027s only an issue when running nova and cinder services on the same node, which even then folks can do without setting this and things will work *most* of the time. At least that\u0027s what I remember of it.\n\nNormally we would not want to make a change like this on a stable branch. But sometimes changes are necessary to address real world needs, so there\u0027s certainly been precedence for making exceptions with things like this. So my take is, while not ideal, this should be an OK change to make. Especially with it included in the release notes. It would be great if we could bump the minor release version, but this should be OK as 4.3.3.","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e15a31d20f21c57a9b9cecfcf9230c65e574dec","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 0c7f5fcfe50d6f51896e76818330af156907fcd2"},{"line_number":30,"context_line":"  - version: 4.3.3"},{"line_number":31,"context_line":"    projects:"},{"line_number":32,"context_line":"      - repo: openstack/os-brick"},{"line_number":33,"context_line":"        hash: d09dc9e51c783fde574f160476ed10efc21eee9a"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a94e39cb_dcaa079c","line":30,"in_reply_to":"ff5b4cae_5dd78aee","updated":"2022-02-28 14:27:50.000000000","message":"Thanks for sharing your view on this Sean! This is a good input for the cinder team as well, i think, to re-evaluate this (as discussed with Brian on last release meeting [1]).\n\n[1] https://meetings.opendev.org/meetings/releaseteam/2022/releaseteam.2022-02-25-14.00.log.html#l-205","commit_id":"6eff2d4f2fac09725c91ead2bc7cbb44dfbca171"}]}