)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9c23fb08f89dd586ea6df90eca810d427a7c0346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2014272_9f078174","updated":"2022-03-01 03:16:00.000000000","message":"@Sean, Can we merge this to unblock downstream jobs? tox targets can\u0027t run with current released 2.3.0. ","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"a4c318150603428301efc2181e756a824ed42d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59d9aa18_26596817","updated":"2022-02-28 13:16:48.000000000","message":"Agree with Sean that the most ideal will be bump version when actual function changes, but for heat wallaby release, not sure how long that means. So +1 to agree on targeting downstream CI automation breakdown if that\u0027s appropriate and acceptable to release rule.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c0874372f76a9035825088f3721e33f722e6eb99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c48154a9_14542898","updated":"2022-03-01 04:06:35.000000000","message":"As is discussed locally, having release for the updated tox.ini is not aligned with the current workflow for cycle-with-intermediary .\n\nFor cycle-with-intermediary, we create multiple releases during the cycle and cut off the branch from the last release. Because tox.ini is updated after the branch cutoff, there is no trigger to get a release including the updated tox.ini .","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"086d1770ffd1d53f449c5f7a7e6293de39026e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48e47bcf_d3e053c7","updated":"2022-03-01 04:17:20.000000000","message":"I\u0027m removing -1 because this is the only solution we have now, but this is not really specific to this release or to python-heatclient and I\u0027m afraid we need to repeat the same in the future, unless we come up with the way to fix misalignment of current release workflow and usage of tox.ini a released version.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e2758cb4b53cd2826d0a7d26bd69cd3ca36a89bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c30f622_d19d6d61","updated":"2022-03-01 20:39:47.000000000","message":"Not sure why this is only an issue for python-heatclient, but fair enough.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6a099b6fc89f6038d50dd1c7fac08f3fed194890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0a649ae_c271c199","updated":"2022-02-28 12:37:01.000000000","message":"There are no functional changes included to be released. This should wait until there are actual changes merged to stable/wallaby.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"eeaf471bf64c32f3d7825cf20261c6ca72a3de6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60e5622f_b86a146c","updated":"2022-03-01 03:45:40.000000000","message":"While I can see the merit in only releasing tags on functional changes, we introduced the tox change to prevent CI failures.\nhttps://github.com/openstack/python-heatclient/commit/3c5a604949dcc5a94c1c814861e8b910832cc53f\n\nIt would be great to not have to diverge downstream / upstream repos for the sake of tox. \n\nI personally think there is no harm in releasing as per this review, and we keep this issue in mind moving forward to avoid situations like this in the future.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a9a49ef29d9585cfb2aca71b7c64098bd18a5b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f56a5357_575f47d8","in_reply_to":"c0a649ae_c271c199","updated":"2022-02-28 12:43:53.000000000","message":"Though there are no functional changes, https://github.com/openstack/python-heatclient/commit/3c5a604949dcc5a94c1c814861e8b910832cc53f required by tox targets merged quite late and breaks downstream CI automation.","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b8d6e8f40aaf6cfeb5d0cc4efe762c6bb4418208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e606cac_84b6ec9f","in_reply_to":"c48154a9_14542898","updated":"2022-03-01 04:17:12.000000000","message":"We do distribute source for a release and downstream runs tox jobs on it. Unless they provide a local constraints file it uses the upstream ones. I agree this is global problem across all client releases that should be addressed.\n\nThough this is a tactical solution to address that problem for python-heatclient, I don\u0027t see any reason to block this patch (we\u0027ve had plenty of releases without any functionality addition).","commit_id":"d6bf23ff1154f55867541fc161b48aac706692ba"}]}