)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6474120c679a348091e54c08d35942a91f8324f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a06fe77b_e0d854ff","updated":"2022-04-14 21:23:34.000000000","message":"Haven\u0027t looked too closely, but there are a few pending reviews to stable/victoria: https://review.opendev.org/q/project:openstack/cinder+status:open+branch:stable/victoria\n\nWe may want to get those in and released quickly before transitioning to EM.","commit_id":"e347c4794cd9c1763c0201fa6f03090ec7a75038"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"53c2a1fe1b8df8e9347dfe9f44e1577ed74c3a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f3fed5c_35e2359c","updated":"2022-04-15 06:20:47.000000000","message":"We are planning to get some changes in before the final release, as we finalize the changes and plan to get them in, I will update the hashes here.","commit_id":"e347c4794cd9c1763c0201fa6f03090ec7a75038"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9391387a04101860419fc18a7a538c6c4bdeee62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"858141f3_826af1fd","updated":"2022-04-26 15:40:49.000000000","message":"See my comment inline + could you prepare a separate release patch for the final stable victoria release, as the validator does not like a release+em tagging together.","commit_id":"20d2f30171e3eac9033d794cc6a004d33410e47d"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"dd2478a233beaa133b7f913859b2a8acfbfc6548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"848512bf_33c7407c","in_reply_to":"858141f3_826af1fd","updated":"2022-04-26 16:31:45.000000000","message":"Can do, thanks for the suggestion.","commit_id":"20d2f30171e3eac9033d794cc6a004d33410e47d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"cece86ff25bbf9b32de95de38b4487107c590802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fcd7038e_372d794e","updated":"2022-04-26 17:14:06.000000000","message":"Thanks Jon for the update! This will pass whenever the parent patch merges. LGTM.","commit_id":"7b77716e8c898bc15d7feb92604dd226994a4728"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cb0b0c53648bfdc1b97b7e7e30a8911e48a2adbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8859b0b_1ba761f0","updated":"2022-04-26 17:37:00.000000000","message":"Verified all hashes, the only change is for cinder where we have new bugfixes for which we are doing a release in a separate patch. As Elod mentioned, the validate job will pass when the base patch releasing 17.4.0 victoria merges. LGTM.","commit_id":"7b77716e8c898bc15d7feb92604dd226994a4728"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"eb2b76fd192bf492f4272692394445c1a926ca6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f1319dc9_ff30cc76","updated":"2022-04-27 11:38:17.000000000","message":"Zuul jobs are passing, LGTM.","commit_id":"92f1b3c13f5c68e2e31a1b9680f25b0e4f0ce1ce"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f8374957ad435465afe3173afe4267c28ddcddae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a6f450c_c1f0ffbd","updated":"2022-04-27 11:26:09.000000000","message":"recheck - parent patch has merged.","commit_id":"92f1b3c13f5c68e2e31a1b9680f25b0e4f0ce1ce"}],"deliverables/victoria/cinder.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5b95cbf85b1b89bf57ed3f3f8317ac8dbc4ba0f4","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    projects:"},{"line_number":45,"context_line":"      - repo: openstack/cinder"},{"line_number":46,"context_line":"        hash: a6ffb102af7625c53da40358268955b177516aa5"},{"line_number":47,"context_line":"  - version: 17.4.0"},{"line_number":48,"context_line":"    projects:"},{"line_number":49,"context_line":"      - repo: openstack/cinder"},{"line_number":50,"context_line":"        hash: 3aa3968342ff16fba8e4426f5301f670aa72fc51"},{"line_number":51,"context_line":"  - version: victoria-em"},{"line_number":52,"context_line":"    projects:"},{"line_number":53,"context_line":"      - repo: openstack/cinder"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c93dc890_3d616e88","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":54},"updated":"2022-04-26 15:23:21.000000000","message":"Question for release team: I\u0027m not too sure about whether we require this release before the victoria EM (as the EM is already the final release).\nThe commit in question for this extra release is https://github.com/openstack/cinder/commit/d7bb194d092a9f48c09b539ef6153294273147e5","commit_id":"20d2f30171e3eac9033d794cc6a004d33410e47d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8541e0de721026569225f33e7aabdfa35fbe6ccb","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    projects:"},{"line_number":45,"context_line":"      - repo: openstack/cinder"},{"line_number":46,"context_line":"        hash: a6ffb102af7625c53da40358268955b177516aa5"},{"line_number":47,"context_line":"  - version: 17.4.0"},{"line_number":48,"context_line":"    projects:"},{"line_number":49,"context_line":"      - repo: openstack/cinder"},{"line_number":50,"context_line":"        hash: 3aa3968342ff16fba8e4426f5301f670aa72fc51"},{"line_number":51,"context_line":"  - version: victoria-em"},{"line_number":52,"context_line":"    projects:"},{"line_number":53,"context_line":"      - repo: openstack/cinder"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e8e3ae24_7ace9b77","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":54},"in_reply_to":"79fddb62_16cace98","updated":"2022-04-26 17:34:07.000000000","message":"Yes it does and you\u0027ve also answered my followup question as to if it should be a separate release patch. Thanks Elod.","commit_id":"20d2f30171e3eac9033d794cc6a004d33410e47d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9391387a04101860419fc18a7a538c6c4bdeee62","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    projects:"},{"line_number":45,"context_line":"      - repo: openstack/cinder"},{"line_number":46,"context_line":"        hash: a6ffb102af7625c53da40358268955b177516aa5"},{"line_number":47,"context_line":"  - version: 17.4.0"},{"line_number":48,"context_line":"    projects:"},{"line_number":49,"context_line":"      - repo: openstack/cinder"},{"line_number":50,"context_line":"        hash: 3aa3968342ff16fba8e4426f5301f670aa72fc51"},{"line_number":51,"context_line":"  - version: victoria-em"},{"line_number":52,"context_line":"    projects:"},{"line_number":53,"context_line":"      - repo: openstack/cinder"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"79fddb62_16cace98","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":54},"in_reply_to":"c93dc890_3d616e88","updated":"2022-04-26 15:40:49.000000000","message":"Everything that is a bug fix (and not a CI, test, etc) worth a release - in my opinion - before we transition to EM. The linked patch looks OK to me to release (I also reviewed the stable/victoria patch o:)). So I think it\u0027s OK. (not just because my fellow colleague backported it... :))\n\nas I see 3 bugfixes will be part of the release:\n\n$ git log --oneline --no-merges 17.3.0..HEAD\nd7bb194d0 Fix: Schema validation for attachment create API\n1034c9aec Add warning message about slow volume backend\n9a28bce3e NetApp ONTAP: Fix sub-clone zapi call\n\nThese all looks OK to me. Does this answer help, Rajat?","commit_id":"20d2f30171e3eac9033d794cc6a004d33410e47d"}]}