)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"faba13c39314c57731228b839b6504cac4c51475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b13772e_ec0c509d","updated":"2022-05-30 15:44:32.000000000","message":"I\u0027ve no experience with xstatic packaging \u0026 versioning. Nevertheless, it looks OK to me, I have only one question inline.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"c58cbdd4e405ae1f2fa3544afe0a0ea98224abe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10a71662_9a433bee","updated":"2022-05-30 15:08:06.000000000","message":"Thanks, LGTM.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"}],"deliverables/_independent/xstatic-angular.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"faba13c39314c57731228b839b6504cac4c51475","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"57521086_55c77efc","line":23,"updated":"2022-05-30 15:44:32.000000000","message":"nit: As I understand Xstatic codes are delivered with the exact same version number as the original package (AngularJS 1.8.2 this time). The last number should be the incremented build number I guess. But....\n\n* 1.8.2.0 had a build number (in xstatic/pkg/angular/__init__.py) \u00271\u0027, still the version had 0 as last number\n* now we have a build number (in ^^^ __init__.py) \u00272\u0027. do we want to release it as 1.8.2.2 based on that? why not just increment.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e46e69aa549b99af1a472cf0f33037e57ef5488","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d47c81b9_ec542e90","line":23,"in_reply_to":"57521086_55c77efc","updated":"2022-05-31 13:29:23.000000000","message":"This project is not often released so I don\u0027t really remember the previous releases.\n\nThe proposed version LGTM is seems aligned with the version targeted in the init file:\n- https://opendev.org/openstack/xstatic-angular/src/branch/master/xstatic/pkg/angular/__init__.py#L14\n- https://opendev.org/openstack/xstatic-angular/src/branch/master/xstatic/pkg/angular/__init__.py#L16\n\nPlease refer to https://opendev.org/openstack/xstatic-angular/commit/375ee8e424d913b3759b67e9263a38a56c84942c","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8b6fa22bad36a61109a61b4a376f87d926dff395","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7c73d75f_7012793f","line":23,"in_reply_to":"8f29f7a2_3689eeaa","updated":"2022-06-08 19:09:42.000000000","message":"Thanks Akihiro!","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ade97e367f489f992a006962ea4ada64c17acdc5","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ecd2caf9_f18834c1","line":23,"in_reply_to":"9c5a6c81_b809a31c","updated":"2022-05-31 15:18:33.000000000","message":"Ok, thanks for the answer. then this LGTM.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e27eaf1d98cdbabd3357065735adb87b5f17fa54","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8f29f7a2_3689eeaa","line":23,"in_reply_to":"c58f2309_bbd29c09","updated":"2022-06-06 14:48:32.000000000","message":"Thanks for all the details Akihiro! Nice insight to the history of the build numbers here :)","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cbad90c4667616793c9a8bc78fa1ddf7bb02761d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9c5a6c81_b809a31c","line":23,"in_reply_to":"d47c81b9_ec542e90","updated":"2022-05-31 14:39:49.000000000","message":"The build number just has to increase. As long as it is monotonic, it doesn\u0027t matter what the value is.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c74d46ae73f319fe904552b794e119a30f3af08d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":21,"context_line":"        hash: 150699b9ded48aceb7e3d8a721622acb3b6801bf"},{"line_number":22,"context_line":"        tarball-base: XStatic-Angular"},{"line_number":23,"context_line":"  - version: 1.8.2.2"},{"line_number":24,"context_line":"    projects:"},{"line_number":25,"context_line":"      - repo: openstack/xstatic-angular"},{"line_number":26,"context_line":"        hash: 375ee8e424d913b3759b67e9263a38a56c84942c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c58f2309_bbd29c09","line":23,"in_reply_to":"ecd2caf9_f18834c1","updated":"2022-06-06 07:40:01.000000000","message":"I have follow-up commnets.\n\nIn general, the build number (4th digit in the version number) in the release should match BUILD in xstatic/pkg/angular/__init__.py. The build number usually starts from 0.\n\nHowever, when we prepared Angular 1.8.2, BUILD number in xstatic/pkg/angular/__init__.py started with 1 by mistake. In addition, we cut a PyPI release as 1.8.2.0. (It had to be 1.8.2.1 if BUILD \u003d 1).\n\nI updated the contents of xstatic-angular with the upstream recently. The contents published by the upstream have been changed a bit (still with the same version number 1.8.2). There is a change in the contents, so we must increase the build number at least.\n\nConsidering this, I recommeneded to use a new build number we did not use before, so the build number 2 is used now.","commit_id":"491cc41ccc4eb4a62da601a4369c963df7591952"}]}