)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fddc50a25e6a102d9076c0ce3abf5a3af3e94edb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c723e7b_beec80a3","updated":"2022-07-06 20:08:13.000000000","message":"I have 2 questions inline, so to highlight them i\u0027m giving -1.","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"700d564159fb3844d15b1ccd935321c6329c0bb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a8288d3_7abf6a9e","updated":"2022-07-25 10:34:16.000000000","message":"Thanks for the updates! LGTM.","commit_id":"18bb3c9a6c6c48c92d11b5913561a17f827a565e"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fd98f0555a9fa0fef83ec43963b631476b6a7413","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8918764_edd9f745","updated":"2022-07-28 14:27:24.000000000","message":"recheck - gate should be OK now","commit_id":"18bb3c9a6c6c48c92d11b5913561a17f827a565e"}],"deliverables/xena/cinder.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fddc50a25e6a102d9076c0ce3abf5a3af3e94edb","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: 59b8b516c4c68fdb44247724624ceb3a8928acdb"},{"line_number":58,"context_line":"  - version: 19.1.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: 845099818f6c296243990a4fabe5e039ff8feb2c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1369da3e_68ad73ba","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"updated":"2022-07-06 20:08:13.000000000","message":"reno suggests MINOR bump [1], due to \"New feature\" release note [2]. though this is marked as feature, reading the comments of stable cores on the patch [3] the team considers it as a bug fix. Anyway, still, this fixes some kind of a feature-like thing i guess, so I could imagine a MINOR version bump instead. Are you sure you want to bump only the PATCH version?\n\n[1] https://zuul.opendev.org/t/openstack/build/df191201baf24125a0699be6229013d8/log/tox/list-changes-results.log#176\n[2] https://zuul.opendev.org/t/openstack/build/df191201baf24125a0699be6229013d8/log/tox/list-changes-results.log#523-528\n[3] https://review.opendev.org/c/openstack/cinder/+/829630","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"cdfe3f08a8d896b23cb6586f7a0b986782311ee7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: 59b8b516c4c68fdb44247724624ceb3a8928acdb"},{"line_number":58,"context_line":"  - version: 19.1.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: 845099818f6c296243990a4fabe5e039ff8feb2c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d137fd50_e81fe0e7","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"0855408c_36e5bb11","updated":"2022-07-13 10:25:27.000000000","message":"ACK, i\u0027m OK with the PATCH version bump, in this case.","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"e8e17d522399e374ed5586f8de2d85ba9d2790a5","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: 59b8b516c4c68fdb44247724624ceb3a8928acdb"},{"line_number":58,"context_line":"  - version: 19.1.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: 845099818f6c296243990a4fabe5e039ff8feb2c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c542102c_4d8eeb32","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"1369da3e_68ad73ba","updated":"2022-07-06 20:55:42.000000000","message":"This is an excellent point, I bumped only the patch version to be conservative.  This is the first group of releases I\u0027ve done so I\u0027m still learning. Rajat, if you can outline the logic we follow in a case like this, I will apply that moving forward.","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a1314ad3276034413b2c4d03f9295d9469b33f22","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    projects:"},{"line_number":56,"context_line":"      - repo: openstack/cinder"},{"line_number":57,"context_line":"        hash: 59b8b516c4c68fdb44247724624ceb3a8928acdb"},{"line_number":58,"context_line":"  - version: 19.1.1"},{"line_number":59,"context_line":"    projects:"},{"line_number":60,"context_line":"      - repo: openstack/cinder"},{"line_number":61,"context_line":"        hash: 845099818f6c296243990a4fabe5e039ff8feb2c"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0855408c_36e5bb11","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":19},"in_reply_to":"c542102c_4d8eeb32","updated":"2022-07-12 18:54:06.000000000","message":"Regarding the patch in question, it is actually a bug fix since it is fixing the replication issue and not actually implementing/backporting the replication feature to Xena. You can see the driver matrix showing pure already supports replication[1] It\u0027s unfortunate that the wordings of the commit message and releasenote are such that it can be misinterpreted as a feature, not to mention lack of a bug report and a bug link added to releasenote.\n\nLooking at other changes, mostly are bug fix so don\u0027t see anything that should require a minor bump.\n\nIn conclusion, we can do a minor bump if it\u0027s not harmful but to be honest, there are no features backported so i would still prefer a patch version bump.\n\n[1] https://docs.openstack.org/cinder/xena/reference/support-matrix.html#operation_volume_replication","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"}],"deliverables/xena/cinderlib.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fddc50a25e6a102d9076c0ce3abf5a3af3e94edb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"  - version: 4.1.1"},{"line_number":14,"context_line":"    projects:"},{"line_number":15,"context_line":"      - repo: openstack/cinderlib"},{"line_number":16,"context_line":"        hash: 4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"63de1a73_0693b229","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"updated":"2022-07-06 20:08:13.000000000","message":"This is another interesting question.\n\nNote that our validator warns us to an introduced *new dependency* [1] (which is not allowed according to stable policy). In fact, importlib_metadata already exists [2] in requirements.txt but for specific python versions (\u003cpy38). Since in xena the supported runtimes are py36 AND py38 [3] this could affect ubuntu based deployments, while for centos based ones the problem does not exist.\n\nSo I\u0027m asking again cinder stable cores/team, whether they want to release this anyway (in that case I suggest a MINOR version bump at least)?\n\n[1] https://zuul.opendev.org/t/openstack/build/1fc0d7d14c964e7285fb6da76744395a/log/tox/validate-request-results.log#26725\n[2] https://opendev.org/openstack/cinderlib/src/commit/4fc56c815b0e9e4d3706dca14bbe54fbb4866272/requirements.txt#L6\n[3] https://governance.openstack.org/tc/reference/runtimes/xena.html","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"700d564159fb3844d15b1ccd935321c6329c0bb6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"  - version: 4.1.1"},{"line_number":14,"context_line":"    projects:"},{"line_number":15,"context_line":"      - repo: openstack/cinderlib"},{"line_number":16,"context_line":"        hash: 4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"570b82be_ca302ad0","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"in_reply_to":"354448d0_9fed804a","updated":"2022-07-25 10:34:16.000000000","message":"Thanks for the answer Rajat, this looks OK for now. Just one comment: so now we don\u0027t release cinder-lib, but in the future, if there will be a need (due to for example a bug fix) then we will also face this issue (if that patch is not reverted).","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a1d8f67da3a8d209179c88bf5cf3784b177477be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"  - version: 4.1.1"},{"line_number":14,"context_line":"    projects:"},{"line_number":15,"context_line":"      - repo: openstack/cinderlib"},{"line_number":16,"context_line":"        hash: 4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"68f81442_4c8ca1dc","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"in_reply_to":"63de1a73_0693b229","updated":"2022-07-06 20:15:00.000000000","message":"meanwhile, i realized, that i was wrong: importlib_metadata is there, but the introduced new dependency is importlib_resources. So in that case, both CentOS and Ubuntu distro based deployments could be affected. So my question still holds, does the team want to release this anyway, giving an exception for stable policy?","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ebe943df62202e48f495a069e5046b65e2af808","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"  - version: 4.1.1"},{"line_number":14,"context_line":"    projects:"},{"line_number":15,"context_line":"      - repo: openstack/cinderlib"},{"line_number":16,"context_line":"        hash: 4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"354448d0_9fed804a","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":18},"in_reply_to":"68f81442_4c8ca1dc","updated":"2022-07-20 18:20:10.000000000","message":"Elod, Brian and I looked at this and we also weren\u0027t sure about it but Brian noticed that this fix is not even needed in the release since it was proposed to fix a gate issue. So we decided to remove the cinderlib release as there are no changes there that needs to be released. Hope the new revision looks good for release.","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"}],"deliverables/xena/os-brick.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fddc50a25e6a102d9076c0ce3abf5a3af3e94edb","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    projects:"},{"line_number":24,"context_line":"      - repo: openstack/os-brick"},{"line_number":25,"context_line":"        hash: 19a4820f5c4ccca10d50d08198873b1515ee257b"},{"line_number":26,"context_line":"  - version: 5.0.3"},{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: b31b109f0f95c0102300bbda15b011f3623a2873"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df26717c_a7d326e5","line":26,"range":{"start_line":26,"start_character":13,"end_line":26,"end_character":18},"updated":"2022-07-06 20:08:13.000000000","message":"this looks OK","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3b9f08c0dbf32a873617f3fa8c50f699dbdddfc9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    projects:"},{"line_number":24,"context_line":"      - repo: openstack/os-brick"},{"line_number":25,"context_line":"        hash: 19a4820f5c4ccca10d50d08198873b1515ee257b"},{"line_number":26,"context_line":"  - version: 5.0.3"},{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: b31b109f0f95c0102300bbda15b011f3623a2873"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c33b502_c70f1e44","line":26,"range":{"start_line":26,"start_character":13,"end_line":26,"end_character":18},"in_reply_to":"df26717c_a7d326e5","updated":"2022-07-25 10:35:04.000000000","message":"still looks OK.","commit_id":"fd13216ae4ee0c62acea7471a4ccd8b3457e51c5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"700d564159fb3844d15b1ccd935321c6329c0bb6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  - version: 5.0.3"},{"line_number":27,"context_line":"    projects:"},{"line_number":28,"context_line":"      - repo: openstack/os-brick"},{"line_number":29,"context_line":"        hash: 3aa5d295821d6bb39a24f465b740f9ac4fb884d1"},{"line_number":30,"context_line":"branches:"},{"line_number":31,"context_line":"  - location: 5.0.0"},{"line_number":32,"context_line":"    name: stable/xena"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a5e8ea7c_ffa94595","line":29,"updated":"2022-07-25 10:34:16.000000000","message":"still OK with the new hash as well.","commit_id":"18bb3c9a6c6c48c92d11b5913561a17f827a565e"}]}