)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac73d6ea7063de490508a1f1e62aa8ca4652eea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f042c701_0be603c7","updated":"2022-10-12 02:41:21.000000000","message":"recheck puppet-manila patch was merged","commit_id":"626bd14b5e8539ff01e60ae4347dcec07b809b8d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b14e4015ec38a8dac5c5fd3c835684e4ec2c7435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"adf72182_d8635e9a","updated":"2022-10-14 14:18:03.000000000","message":"(Giving -1 to highlight my question)","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"d551204526ddd099bf0b0e96542fa10614c7d969","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f0ba793_cfab4edf","updated":"2022-10-13 13:17:18.000000000","message":"Here we are a bit between the two models -- one that uses release candidates to do a single release (cycle-with-rc), and the one that does multiple full releases (cycle-with-intermediary).\n\nI personally think cycle-with-intermediary is a better match for what you are doing, since you are not using RCs.","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"d966b0a6a5b6ac01694f1fc06c2609c0562ec80f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"abd3801f_bc83984f","updated":"2022-10-13 10:20:39.000000000","message":"If you are not using RCs it feels like the release model should be updated to cycle-with-intermediary (like it was in Yoga) ?","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f902b36e23ace8ee735fc2e73a5c51a74611ad3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a53bf41a_9979a191","updated":"2022-10-14 14:17:32.000000000","message":"The hashes are all OK, my concern is only the versions (see my comment inline).","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b15b58f499ab9948f2e6044f03f6654aee9e8c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"86423d76_066adb77","in_reply_to":"abd3801f_bc83984f","updated":"2022-10-13 13:07:38.000000000","message":"If that suit the current plan then I\u0027m ok with changing it.\n\nIn the past we used cycle-with-interediary and created release per milestone but we agreed with creating a single release per cycle. When we made that switch, I changed the release model from cycle-with-intermediary because my understanding was that the previous model requires at least one intermediate release during a cycle but that might be wrong.","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"8317a9f69d2f0f96d312e02ac866d88750f43570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8e271c5_ac9df126","updated":"2022-10-20 10:32:09.000000000","message":"I would prefer if we updated the model back to cycle-with-intermediary as it is closer to what\u0027s being done here. But we can do that as a separate change imho","commit_id":"72702fa94813fa7a2d7ce74545e5eeb99ae0b0a1"}],"deliverables/zed/puppet-aodh.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f902b36e23ace8ee735fc2e73a5c51a74611ad3b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - projects:"},{"line_number":8,"context_line":"      - hash: a1f3b1b006d0134dc36082a45501ef25ea2d6625"},{"line_number":9,"context_line":"        repo: openstack/puppet-aodh"},{"line_number":10,"context_line":"    version: 21.0.0"},{"line_number":11,"context_line":"repository-settings:"},{"line_number":12,"context_line":"  openstack/puppet-aodh: {}"},{"line_number":13,"context_line":"branches:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"41ee8f60_9b64f455","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":19},"updated":"2022-10-14 14:17:32.000000000","message":"You state in the commit message title that this patch is the RC1 patch. Could you use rc1 version instead, like 21.0.0.0rc1 here (and similarly to all the versions in this release patch)? (probably this is what Thierry also wants to point out)\n\nIf this is really aimed to be an RC1 release and later on goes out as Final versions, then I guess cycle-with-rc is the right model for Puppet OpenStack. But that is maybe just my opinion.","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b1f132e280b6272c1e66de28db9fb5ccfedc5ba","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - projects:"},{"line_number":8,"context_line":"      - hash: a1f3b1b006d0134dc36082a45501ef25ea2d6625"},{"line_number":9,"context_line":"        repo: openstack/puppet-aodh"},{"line_number":10,"context_line":"    version: 21.0.0"},{"line_number":11,"context_line":"repository-settings:"},{"line_number":12,"context_line":"  openstack/puppet-aodh: {}"},{"line_number":13,"context_line":"branches:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b7e4348d_9251641e","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":19},"in_reply_to":"41ee8f60_9b64f455","updated":"2022-10-17 01:45:05.000000000","message":"Here we intend to release GA rather than RC1(because we didn\u0027t create explicit release we created rc1 release in the past), so I modified the commit message to mention GA rather than RC1. We probably can create rc1/ga following the other projects but that\u0027s not what we have done in the past releases. AFAIK \"rc\" release is not generally done in Puppet modules so I tend to keep the existing release model (directly create GA without rc).","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"97b82dfac4e41fcec0885d950bc9ac15e6e8c874","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - projects:"},{"line_number":8,"context_line":"      - hash: a1f3b1b006d0134dc36082a45501ef25ea2d6625"},{"line_number":9,"context_line":"        repo: openstack/puppet-aodh"},{"line_number":10,"context_line":"    version: 21.0.0"},{"line_number":11,"context_line":"repository-settings:"},{"line_number":12,"context_line":"  openstack/puppet-aodh: {}"},{"line_number":13,"context_line":"branches:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b4a0e4a3_3b5683b3","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":19},"in_reply_to":"b7e4348d_9251641e","updated":"2022-10-19 12:27:39.000000000","message":"ACK","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f902b36e23ace8ee735fc2e73a5c51a74611ad3b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  openstack/puppet-aodh: {}"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/zed"},{"line_number":15,"context_line":"    location: 21.0.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9491a770_c8826a5e","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":20},"updated":"2022-10-14 14:17:32.000000000","message":"In case the above version(s) are changed to .0rc1 then the branch cut should be adjusted as well to those versions.","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3c644fd0f3889f4e09dde5dddf2779daec5c0ec3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  openstack/puppet-aodh: {}"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/zed"},{"line_number":15,"context_line":"    location: 21.0.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bcf56ee1_72c02f1a","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":20},"in_reply_to":"9491a770_c8826a5e","updated":"2022-10-19 12:28:43.000000000","message":"(N/A, they were not changed.)","commit_id":"70c327cc705d761751c5a4e5be9f0a83cf3b5086"}]}