)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f8a81c1efccdfe5b57d21265f961fac02dfcc38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab64299c_7f28609c","updated":"2023-01-26 08:45:56.000000000","message":"Just one hour please, looking whether we also merged another CVE fix : https://launchpad.net/bugs/1981813","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b43986ce0e92c9988e0ec3c1f6aeb5f525f8205e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30f8775d_92bd8115","updated":"2023-01-26 10:19:31.000000000","message":"LGTM","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45d19573_d4edebfa","updated":"2023-01-26 09:08:43.000000000","message":"Okay, I may feel that bumping those releases with .y numbers is maybe semantically wrong, but I don\u0027t wanna hold this release for a nit and I found patches that actually seem to be like feature-ish.","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d06798dbadbc919eed81ded4f49277e51c1d142e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c33c869_a5ef33a1","updated":"2023-01-26 10:21:08.000000000","message":"Well, I wanted to discuss the patch [1], that changes default behavior (the discussion has been started on nova meeting last week). I\u0027d rather removed that from the release, but given that other cores did not find issue with it, I don\u0027t want to hold this critical release based on that, so LGTM:\n* MINOR version bump ✔ (nova tends to use MINOR bumps in somewhat critical changes, changes having bigger impact, to attract attention from package consumers)\n* release approved by PTL ✔\n\n[1] https://zuul.opendev.org/t/openstack/build/a32abca1ea514af3af1d9366152daae8/log/tox/list-changes/list-changes-results.log#2420-2455\n","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d13ab40d7b11f1480f95bc6afb898cee1680144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"152e7995_7cf031bc","updated":"2023-01-26 09:16:37.000000000","message":"looks good to me","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"}],"deliverables/xena/nova.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    projects:"},{"line_number":50,"context_line":"      - repo: openstack/nova"},{"line_number":51,"context_line":"        hash: 3872647092353229302919d305758f3fc777277f"},{"line_number":52,"context_line":"  - version: 24.2.0"},{"line_number":53,"context_line":"    projects:"},{"line_number":54,"context_line":"      - repo: openstack/nova"},{"line_number":55,"context_line":"        hash: ac3728e1239fe2aeffc2a06bbeab6a24eff28ae9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13b3f6f3_025c0cad","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":19},"updated":"2023-01-26 09:08:43.000000000","message":"I was torn with bumping this release with a minor version but given the difference [1], let\u0027s do this.\n\nhttps://opendev.org/openstack/nova/compare/24.1.1...ac3728e1239fe2aeffc2a06bbeab6a24eff28ae9\n\n\nhttps://opendev.org/openstack/nova/commit/c3092e3ee791d9e291f829cc3eaa8123560a13ef seems a good candidate for considering a minor version taggging :\n\n\"Minor version Y (x.Y.z | x \u003e 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.\"\nhttps://docs.openstack.org/pbr/latest/user/semver.html","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  - version: 24.2.0"},{"line_number":53,"context_line":"    projects:"},{"line_number":54,"context_line":"      - repo: openstack/nova"},{"line_number":55,"context_line":"        hash: ac3728e1239fe2aeffc2a06bbeab6a24eff28ae9"},{"line_number":56,"context_line":"branches:"},{"line_number":57,"context_line":"  - name: stable/xena"},{"line_number":58,"context_line":"    location: 24.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"38a29796_972702bc","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":54},"updated":"2023-01-26 09:08:43.000000000","message":"verified the SHA1 hash. LGTM as we also release https://bugs.launchpad.net/nova/+bug/1981813\nhttps://opendev.org/openstack/nova/commits/branch/stable/xena","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"}],"deliverables/yoga/nova.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    projects:"},{"line_number":46,"context_line":"      - repo: openstack/nova"},{"line_number":47,"context_line":"        hash: 6b9c55ac5d3399a444efd38e055ee91f7b70c3d4"},{"line_number":48,"context_line":"  - version: 25.1.0"},{"line_number":49,"context_line":"    projects:"},{"line_number":50,"context_line":"      - repo: openstack/nova"},{"line_number":51,"context_line":"        hash: e0723453eaff0346630419413d5b6bff55aa3791"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c5a9fc5d_d34ab280","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":19},"updated":"2023-01-26 09:08:43.000000000","message":"same consideration than for xena release. Let\u0027s do a MINOR release bump.\n\n(same patch worth considering for a minor upgrade https://opendev.org/openstack/nova/commit/041939361e393b808724b8590eb76b3aa075814e )","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  - version: 25.1.0"},{"line_number":49,"context_line":"    projects:"},{"line_number":50,"context_line":"      - repo: openstack/nova"},{"line_number":51,"context_line":"        hash: e0723453eaff0346630419413d5b6bff55aa3791"},{"line_number":52,"context_line":"branches:"},{"line_number":53,"context_line":"  - name: stable/yoga"},{"line_number":54,"context_line":"    location: 25.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"42d1bbd4_63cd13de","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":54},"updated":"2023-01-26 09:08:43.000000000","message":"seems correct SHA1 : \nhttps://opendev.org/openstack/nova/commits/branch/stable/yoga","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"}],"deliverables/zed/nova.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      - repo: openstack/nova"},{"line_number":42,"context_line":"        hash: 2db7cbf7d0a6692a885968bec67f48e7262ceec3"},{"line_number":43,"context_line":"    diff-start: 25.0.0"},{"line_number":44,"context_line":"  - version: 26.1.0"},{"line_number":45,"context_line":"    projects:"},{"line_number":46,"context_line":"      - repo: openstack/nova"},{"line_number":47,"context_line":"        hash: 9bca7f34a0d1e546bff8e226cbe45ccbc520c878"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f179da6d_f6222868","line":44,"range":{"start_line":44,"start_character":13,"end_line":44,"end_character":19},"updated":"2023-01-26 09:08:43.000000000","message":"here, the MINOR upgrade is debatable :\nhttps://opendev.org/openstack/nova/compare/26.0.0...9bca7f34a0d1e546bff8e226cbe45ccbc520c878\n\nThat being said, given https://opendev.org/openstack/nova/commit/6e8ed78470edbae7b58d75e9e9f4f62bdb30a170 adds a new config option, we can technically consider applying a MINOR release too.","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c3e3587f8888adcdcead4a2eae732d2d28b0355","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  - version: 26.1.0"},{"line_number":45,"context_line":"    projects:"},{"line_number":46,"context_line":"      - repo: openstack/nova"},{"line_number":47,"context_line":"        hash: 9bca7f34a0d1e546bff8e226cbe45ccbc520c878"},{"line_number":48,"context_line":"branches:"},{"line_number":49,"context_line":"  - name: stable/zed"},{"line_number":50,"context_line":"    location: 26.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"69c9fe67_f4c96ad6","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":54},"updated":"2023-01-26 09:08:43.000000000","message":"SHA1 looks good too https://opendev.org/openstack/nova/commits/branch/stable/zed","commit_id":"c0430665e29c5291189603ccab86de9d85f26338"}]}
