)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6640bed8ab22a46b6fa29f03c09c1c3954ef557e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90095417_a087c874","updated":"2023-04-20 18:13:22.000000000","message":"Apart from the inline comment, we don\u0027t need this patch to depend on the EOL patches so can you separate it out from the chain? because we don\u0027t know when those will merge and this is a priority","commit_id":"ce5b1bc614b1c4fada619f8ad4457b837af76509"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f46919f8e403cd0d3209a5f547b2228497069400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"600112e7_0bac3a58","updated":"2023-04-20 18:20:12.000000000","message":"one question inline","commit_id":"33889b6814f1c94f1c44ef88fec90150faf9a895"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"514ad3aa6074f1da8a1cbc1da556ab76b1bdd822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"efc06c50_facaca42","updated":"2023-04-21 11:22:30.000000000","message":"Giving -1 to highlight my questions.","commit_id":"ef536acf1b888bcfc3ce3a17b14499cd42eedcd4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ca9cee41ba7a9c92057ec2a5b70c99974b305245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37ae2149_7ef163fc","updated":"2023-04-20 18:31:26.000000000","message":"Hashes look correct.\nMinor version bump in cinder because we\u0027ve backward incompatible change.\nPatch version bump in cinderlib, we introduce a new requirement but 4.2.0 is taken by yoga so we can only do 4.1.1\n\nLGTM.","commit_id":"ef536acf1b888bcfc3ce3a17b14499cd42eedcd4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"514ad3aa6074f1da8a1cbc1da556ab76b1bdd822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4c6b0a2_842cab8d","in_reply_to":"37ae2149_7ef163fc","updated":"2023-04-21 11:22:30.000000000","message":"backward incompatible change would require MAJOR version bump, this also shows that such change is not allowed according to stable policy. Moreover, API changes are prohibited in stable policy (requires MAJOR version bump as well). So in general, that patch should be reverted. Has the team assessed and accepted that this patch is OK to backport?","commit_id":"ef536acf1b888bcfc3ce3a17b14499cd42eedcd4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3fcd11ce98d10a3dfdbb2d4db563f12b4ef8520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94753635_664491db","updated":"2023-04-21 15:08:05.000000000","message":"@Elod: for cinderlib, the change that needed a new dependency was necessary to pass OpenStack CI, but on consideration, \"normal\" users won\u0027t need it, so we won\u0027t do a new cinderlib release.\n\nFor cinder, it\u0027s a really minor backward incompatibility associated with a data loss situation.  Most requests will continue to succeed, it\u0027s just the dangerous ones that will now fail.  The QA team was OK with this change:\nhttps://lists.openstack.org/pipermail/openstack-discuss/2023-March/032554.html","commit_id":"c4f91373dfb16ad97fcd57ca43c2b31379e9330c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7123164db25bf683ab7180fbb9a9d7d341dc224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8076625_e863bfa1","updated":"2023-04-25 10:24:22.000000000","message":"Hash and version looks correct. LGTM.","commit_id":"c4f91373dfb16ad97fcd57ca43c2b31379e9330c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"5e9fb009ea79c77e26a761105907c1642a63a067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3aca61de_9c031107","in_reply_to":"94753635_664491db","updated":"2023-04-25 09:33:46.000000000","message":"ACK, thanks for the answer. LGTM.","commit_id":"c4f91373dfb16ad97fcd57ca43c2b31379e9330c"}],"deliverables/xena/cinder.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6640bed8ab22a46b6fa29f03c09c1c3954ef557e","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    projects:"},{"line_number":64,"context_line":"      - repo: openstack/cinder"},{"line_number":65,"context_line":"        hash: 323d1d5fa52cbcae12a172b56a186b23677ec28b"},{"line_number":66,"context_line":"  - version: 19.2.1"},{"line_number":67,"context_line":"    projects:"},{"line_number":68,"context_line":"      - repo: openstack/cinder"},{"line_number":69,"context_line":"        hash: cd172e5dad8e866293f88c3f25c8e182175fd903"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eea1267e_da458e83","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":19},"updated":"2023-04-20 18:13:22.000000000","message":"I think this should be 19.3.0 since the multiattach change is backward incompatible","commit_id":"ce5b1bc614b1c4fada619f8ad4457b837af76509"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"1f070ca197731c6425b88f797753dbd9acef8bc7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    projects:"},{"line_number":64,"context_line":"      - repo: openstack/cinder"},{"line_number":65,"context_line":"        hash: 323d1d5fa52cbcae12a172b56a186b23677ec28b"},{"line_number":66,"context_line":"  - version: 19.2.1"},{"line_number":67,"context_line":"    projects:"},{"line_number":68,"context_line":"      - repo: openstack/cinder"},{"line_number":69,"context_line":"        hash: cd172e5dad8e866293f88c3f25c8e182175fd903"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"10c7ae98_8afbdcff","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":19},"in_reply_to":"eea1267e_da458e83","updated":"2023-04-20 18:30:33.000000000","message":"Done","commit_id":"ce5b1bc614b1c4fada619f8ad4457b837af76509"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ca9cee41ba7a9c92057ec2a5b70c99974b305245","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    projects:"},{"line_number":64,"context_line":"      - repo: openstack/cinder"},{"line_number":65,"context_line":"        hash: 323d1d5fa52cbcae12a172b56a186b23677ec28b"},{"line_number":66,"context_line":"  - version: 19.2.1"},{"line_number":67,"context_line":"    projects:"},{"line_number":68,"context_line":"      - repo: openstack/cinder"},{"line_number":69,"context_line":"        hash: cd172e5dad8e866293f88c3f25c8e182175fd903"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"af626cab_4dc10eef","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":19},"in_reply_to":"eea1267e_da458e83","updated":"2023-04-20 18:31:26.000000000","message":"Done","commit_id":"ce5b1bc614b1c4fada619f8ad4457b837af76509"}],"deliverables/xena/cinderlib.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f46919f8e403cd0d3209a5f547b2228497069400","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/xena"},{"line_number":15,"context_line":"    location: 4.1.0"},{"line_number":16,"context_line":"release-notes: https://docs.openstack.org/releasenotes/cinderlib/xena.html"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"63e37555_78089cae","line":13,"updated":"2023-04-20 18:20:12.000000000","message":"I\u0027m not sure if this[1] is a functional change or not but if it is, we will need to do cinderlib release as well\n\n [1] https://github.com/openstack/cinderlib/commit/4fc56c815b0e9e4d3706dca14bbe54fbb4866272","commit_id":"33889b6814f1c94f1c44ef88fec90150faf9a895"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"514ad3aa6074f1da8a1cbc1da556ab76b1bdd822","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/xena"},{"line_number":15,"context_line":"    location: 4.1.0"},{"line_number":16,"context_line":"release-notes: https://docs.openstack.org/releasenotes/cinderlib/xena.html"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"51f58f80_9a9d32c7","line":13,"in_reply_to":"241c90f2_13276d67","updated":"2023-04-21 11:22:30.000000000","message":"In general to introduce new dependencies on stable branches is not allowed according to stable policy, however, here we are adding new requirement: importlib_resources. same question applies here then in case of the cinder change.","commit_id":"33889b6814f1c94f1c44ef88fec90150faf9a895"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ca9cee41ba7a9c92057ec2a5b70c99974b305245","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/xena"},{"line_number":15,"context_line":"    location: 4.1.0"},{"line_number":16,"context_line":"release-notes: https://docs.openstack.org/releasenotes/cinderlib/xena.html"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"241c90f2_13276d67","line":13,"in_reply_to":"63e37555_78089cae","updated":"2023-04-20 18:31:26.000000000","message":"Done","commit_id":"33889b6814f1c94f1c44ef88fec90150faf9a895"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"24c311c687a5c587df842bdfb16a48dd1a4afa1a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    projects:"},{"line_number":11,"context_line":"      - repo: openstack/cinderlib"},{"line_number":12,"context_line":"        hash: e13887ec984603fe2b3b43668bfc6eac121c2cfd"},{"line_number":13,"context_line":"branches:"},{"line_number":14,"context_line":"  - name: stable/xena"},{"line_number":15,"context_line":"    location: 4.1.0"},{"line_number":16,"context_line":"release-notes: https://docs.openstack.org/releasenotes/cinderlib/xena.html"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"817b6861_d326914c","line":13,"in_reply_to":"63e37555_78089cae","updated":"2023-04-20 18:30:52.000000000","message":"Done","commit_id":"33889b6814f1c94f1c44ef88fec90150faf9a895"}]}