)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"10ec15bf240fa82f6466c65a316eb68fa064ebe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b316b14_93a3e44e","updated":"2023-09-06 09:22:36.000000000","message":"Giving -1 to highlight my comment","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"22091c87e398c036b903dc3e8b78134f859324ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5003348_45da39f6","updated":"2023-09-06 10:32:37.000000000","message":"reply inline","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"38cb6b2b67f00e2fdc297797e1aa655e249583b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"287de50c_b6dab459","updated":"2023-09-11 07:26:46.000000000","message":"Thanks for the update. hash and version LGTM.","commit_id":"0f4d07c7ad851a8bf4a3f1737aa29c9c9ef28082"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d1259e67c01e04a096d44d3ba89e8c084d52c304","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"594e5baa_6c719756","updated":"2023-09-11 07:30:54.000000000","message":"Yepp, thanks, too. LGTM","commit_id":"0f4d07c7ad851a8bf4a3f1737aa29c9c9ef28082"}],"deliverables/antelope/cinder.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"10ec15bf240fa82f6466c65a316eb68fa064ebe3","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db398c07_e7226a4e","line":42,"updated":"2023-09-06 09:22:36.000000000","message":"22.1.1 might be enough, as I don\u0027t see a patch in the list [1] that should be highlighted with a MINOR bump.\n\n[1]\n\n81af154d8 2023-07-18 22:03:10 -0500 Fix a regression in restoring to sparse volumes\nf542dd07b 2023-06-05 13:03:08 +0000 Fix glance metadata properties filtering\n14687515f 2023-06-01 14:42:07 +0000 Make paramiko import optional\nced3bcbe1 2023-05-24 10:32:12 +0000 HPE 3PAR: Few issues with new WSAPI (of 2023)\nefd742409 2023-04-25 12:56:55 +0000 RBD: Skip update_features when features \u003d 0","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6cbb601908d10191a5bd234b7b532cf89146b246","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d79646dd_a667ae2b","line":42,"in_reply_to":"0f48432c_d3d1de8a","updated":"2023-09-06 11:43:11.000000000","message":"As you wrote, in general, stable releases should be with PATCH version bumps. In some cases teams decide to bump MINOR version due to some (exceptional) \"featurish\" backports, or some bug fix that is handled by a newly introduced config option, or a significant CVE fix. (not even mentioning the case when the operator need to do an extra action when upgrading to the new release). Something that is worth to be highlighted to package consumers.\n\nIn an ideal world, only simple bug fixes should be included on stable branches, unfortunately we know, that it is not possible every time.\n\nI hope this is somewhat answers your question o:)","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"38d6b602381948d02f27aa91cb482da0e3563026","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0f48432c_d3d1de8a","line":42,"in_reply_to":"38d0e12f_8aa60d23","updated":"2023-09-06 10:37:34.000000000","message":"Maybe the idea is, if a feature is backported (in an unusual situation) we do a minor version bump but please correct my understanding if I\u0027m wrong","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"774a463f32fb67d1bb253c266f986e2a399684e7","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fc7994f1_bf2b0a0d","line":42,"in_reply_to":"d79646dd_a667ae2b","updated":"2023-09-06 11:46:08.000000000","message":"Yes, that does answer my question and thanks for the explanation.\nI\u0027m good with a patch version bump.","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"22091c87e398c036b903dc3e8b78134f859324ed","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"38d0e12f_8aa60d23","line":42,"in_reply_to":"db398c07_e7226a4e","updated":"2023-09-06 10:32:37.000000000","message":"I think the version bump policy is different for main projects and libraries\nFor example, Cinder does a MAJOR version bump with new release whereas os-brick (non-client lib) does a MINOR version bump every new release (unless we have any major change)\n\nIn this case, all these patches are bug fixes, for which we would do a PATCH bump in os-brick but not sure if we want to do a PATCH bump for Cinder as well? Since features are not backportable, what qualifies as a MINOR version bump for a project like Cinder in stable branch?\nI\u0027m not disagreeing to your point but just wanted more clarity so we can propose future release patches more carefully.","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"38cb6b2b67f00e2fdc297797e1aa655e249583b3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    projects:"},{"line_number":40,"context_line":"      - repo: openstack/cinder"},{"line_number":41,"context_line":"        hash: ba4e53095e89d9c0a5f7a13f6516fce034f75970"},{"line_number":42,"context_line":"  - version: 22.2.0"},{"line_number":43,"context_line":"    projects:"},{"line_number":44,"context_line":"      - repo: openstack/cinder"},{"line_number":45,"context_line":"        hash: bdf0a3d52681fcfd6aa85bb01491f3a3f5557127"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b9efdec_709b9073","line":42,"in_reply_to":"fc7994f1_bf2b0a0d","updated":"2023-09-11 07:26:46.000000000","message":"Done","commit_id":"142955d46cc38f70fd5b87e068f15a59792078cf"}]}
