)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0954f50a2f7ec3753e1fad0a2c0fcbded9ded199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d312cf35_7a7f2cbe","updated":"2023-11-02 10:08:59.000000000","message":"Hello,\n\nSee my inline questions, just to be sure that we want to continue with that.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f3c2ab2475ea5eaa5c654c7e5591dc4944971562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7b90a1d_d034fc30","updated":"2023-11-08 13:30:55.000000000","message":"LGTM (Kolla team is not listed among the projects that follow stable policy \u0026 we agreed in the past that for the monthly releases kolla will bump MINOR versions regardless of the content.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"152717339a06b8de053c080df4c6b595205f4c55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43bbb1f7_49597101","updated":"2023-11-06 15:01:19.000000000","message":"thanks for feedbacks","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}],"deliverables/antelope/kayobe.yaml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"05b71718f5455fc5d95e40ec084e5dd4c8c4cfba","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        hash: f525c6a563ebe36cd0c1016deb4fa16529eec51f"},{"line_number":43,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":44,"context_line":"        hash: 59b65e1bea140f11d9ab99da64a917cefd99900c"},{"line_number":45,"context_line":"  - version: 14.2.0"},{"line_number":46,"context_line":"    projects:"},{"line_number":47,"context_line":"      - repo: openstack/kayobe"},{"line_number":48,"context_line":"        hash: 70831664afc4eecf9507be064de082ac4ad5fc85"},{"line_number":49,"context_line":"      - repo: openstack/kayobe-config"},{"line_number":50,"context_line":"        hash: 8b7900c185a773bc410a153816a76c9b1c30f27d"},{"line_number":51,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":52,"context_line":"        hash: 98721b81e0e68493db53c559c94cb591b6ae401a"},{"line_number":53,"context_line":"branches:"},{"line_number":54,"context_line":"  - name: stable/2023.1"},{"line_number":55,"context_line":"    location: 14.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"05277337_24d4103d","line":52,"range":{"start_line":45,"start_character":2,"end_line":52,"end_character":54},"updated":"2023-10-31 15:37:06.000000000","message":"all look good","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"057992e930ddd31582fe4324a345cfb03f976f26","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        hash: f525c6a563ebe36cd0c1016deb4fa16529eec51f"},{"line_number":43,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":44,"context_line":"        hash: 59b65e1bea140f11d9ab99da64a917cefd99900c"},{"line_number":45,"context_line":"  - version: 14.2.0"},{"line_number":46,"context_line":"    projects:"},{"line_number":47,"context_line":"      - repo: openstack/kayobe"},{"line_number":48,"context_line":"        hash: 70831664afc4eecf9507be064de082ac4ad5fc85"},{"line_number":49,"context_line":"      - repo: openstack/kayobe-config"},{"line_number":50,"context_line":"        hash: 8b7900c185a773bc410a153816a76c9b1c30f27d"},{"line_number":51,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":52,"context_line":"        hash: 98721b81e0e68493db53c559c94cb591b6ae401a"},{"line_number":53,"context_line":"branches:"},{"line_number":54,"context_line":"  - name: stable/2023.1"},{"line_number":55,"context_line":"    location: 14.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"028f2118_5aa4079d","line":52,"range":{"start_line":45,"start_character":2,"end_line":52,"end_character":54},"in_reply_to":"05277337_24d4103d","updated":"2023-10-31 16:12:52.000000000","message":"Done","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}],"deliverables/yoga/kayobe.yaml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"05b71718f5455fc5d95e40ec084e5dd4c8c4cfba","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    projects:"},{"line_number":77,"context_line":"      - repo: openstack/kayobe"},{"line_number":78,"context_line":"        hash: c4fa262a53f3df6da5c5e7d1e5a3e3f33e5c3100"},{"line_number":79,"context_line":"  - version: 12.9.0"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/kayobe"},{"line_number":82,"context_line":"        hash: 7f9aeab176c7be1ff4ab31f94535670263b8d0d8"},{"line_number":83,"context_line":"branches:"},{"line_number":84,"context_line":"  - name: stable/yoga"},{"line_number":85,"context_line":"    location: 12.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d61682dc_bcaa3641","line":82,"range":{"start_line":79,"start_character":1,"end_line":82,"end_character":54},"updated":"2023-10-31 15:37:06.000000000","message":"Looks good. No changes to kayobe-config or kayobe-config-dev since last tagged releases.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0954f50a2f7ec3753e1fad0a2c0fcbded9ded199","unresolved":true,"context_lines":[{"line_number":79,"context_line":"  - version: 12.9.0"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/kayobe"},{"line_number":82,"context_line":"        hash: 7f9aeab176c7be1ff4ab31f94535670263b8d0d8"},{"line_number":83,"context_line":"branches:"},{"line_number":84,"context_line":"  - name: stable/yoga"},{"line_number":85,"context_line":"    location: 12.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b77a8c58_48726dba","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":54},"updated":"2023-11-02 10:08:59.000000000","message":"New features have been added on stable branch, do you want to continue with that?\nAlso some changes can impact upgrades.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0a0e0d0eefb0aad96bd1486fe6217be3ced4db8a","unresolved":true,"context_lines":[{"line_number":79,"context_line":"  - version: 12.9.0"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/kayobe"},{"line_number":82,"context_line":"        hash: 7f9aeab176c7be1ff4ab31f94535670263b8d0d8"},{"line_number":83,"context_line":"branches:"},{"line_number":84,"context_line":"  - name: stable/yoga"},{"line_number":85,"context_line":"    location: 12.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7d9c5db9_cf292fb9","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":54},"in_reply_to":"b77a8c58_48726dba","updated":"2023-11-03 10:02:54.000000000","message":"All looks good to me. I\u0027d argue some of these changes labelled as features are a form of bugfix since they have been added to workaround issues.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"057992e930ddd31582fe4324a345cfb03f976f26","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    projects:"},{"line_number":77,"context_line":"      - repo: openstack/kayobe"},{"line_number":78,"context_line":"        hash: c4fa262a53f3df6da5c5e7d1e5a3e3f33e5c3100"},{"line_number":79,"context_line":"  - version: 12.9.0"},{"line_number":80,"context_line":"    projects:"},{"line_number":81,"context_line":"      - repo: openstack/kayobe"},{"line_number":82,"context_line":"        hash: 7f9aeab176c7be1ff4ab31f94535670263b8d0d8"},{"line_number":83,"context_line":"branches:"},{"line_number":84,"context_line":"  - name: stable/yoga"},{"line_number":85,"context_line":"    location: 12.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b34bcf74_7d531a5e","line":82,"range":{"start_line":79,"start_character":1,"end_line":82,"end_character":54},"in_reply_to":"d61682dc_bcaa3641","updated":"2023-10-31 16:12:52.000000000","message":"Done","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}],"deliverables/yoga/kolla-ansible.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0954f50a2f7ec3753e1fad0a2c0fcbded9ded199","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    projects:"},{"line_number":55,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":56,"context_line":"        hash: e885a17d36da3503d2eec040a2d5b232c9d3ae43"},{"line_number":57,"context_line":"  - version: 14.10.0"},{"line_number":58,"context_line":"    projects:"},{"line_number":59,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":60,"context_line":"        hash: 74471edc638c6cd69df330979bde65f48e84533e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b2190fd0_f6c0a7dc","line":57,"range":{"start_line":57,"start_character":13,"end_line":57,"end_character":20},"updated":"2023-11-02 10:08:59.000000000","message":"New features have been added here and one deprecated role has been renamed, are you sure you want to continue to release this kind of changes on a stable branch?\n\nI think the renamed role is not a backward compat change.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}],"deliverables/zed/kayobe.yaml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"05b71718f5455fc5d95e40ec084e5dd4c8c4cfba","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        hash: 6accbcf6654423ee0a48ba8382b7fd7e0c2b00fa"},{"line_number":51,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":52,"context_line":"        hash: 662aada627a8b2e01ce6c979cb339fcaeb34a2d2"},{"line_number":53,"context_line":"  - version: 13.3.0"},{"line_number":54,"context_line":"    projects:"},{"line_number":55,"context_line":"      - repo: openstack/kayobe"},{"line_number":56,"context_line":"        hash: b5f566ffecf8945ac128a397f58534d56b2aae5c"},{"line_number":57,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":58,"context_line":"        hash: 0f89c564bb675bdabb58b7756eb20c76437d630f"},{"line_number":59,"context_line":"branches:"},{"line_number":60,"context_line":"  - name: stable/zed"},{"line_number":61,"context_line":"    location: 13.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1799f7e4_f5f23fdd","line":58,"range":{"start_line":53,"start_character":1,"end_line":58,"end_character":54},"updated":"2023-10-31 15:37:06.000000000","message":"Looks good to me","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"057992e930ddd31582fe4324a345cfb03f976f26","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        hash: 6accbcf6654423ee0a48ba8382b7fd7e0c2b00fa"},{"line_number":51,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":52,"context_line":"        hash: 662aada627a8b2e01ce6c979cb339fcaeb34a2d2"},{"line_number":53,"context_line":"  - version: 13.3.0"},{"line_number":54,"context_line":"    projects:"},{"line_number":55,"context_line":"      - repo: openstack/kayobe"},{"line_number":56,"context_line":"        hash: b5f566ffecf8945ac128a397f58534d56b2aae5c"},{"line_number":57,"context_line":"      - repo: openstack/kayobe-config-dev"},{"line_number":58,"context_line":"        hash: 0f89c564bb675bdabb58b7756eb20c76437d630f"},{"line_number":59,"context_line":"branches:"},{"line_number":60,"context_line":"  - name: stable/zed"},{"line_number":61,"context_line":"    location: 13.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6a2e04e2_5d77b77b","line":58,"range":{"start_line":53,"start_character":1,"end_line":58,"end_character":54},"in_reply_to":"1799f7e4_f5f23fdd","updated":"2023-10-31 16:12:52.000000000","message":"Done","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}],"deliverables/zed/kolla-ansible.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0954f50a2f7ec3753e1fad0a2c0fcbded9ded199","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - version: 15.3.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":32,"context_line":"        hash: 1de8b13f336ad4900c1c02638f4cab1e6db8fae3"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/zed"},{"line_number":35,"context_line":"    location: 15.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dbd30c33_ae47d322","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"updated":"2023-11-02 10:08:59.000000000","message":"New features have been added here and one deprecated role has been renamed, are you sure you want to continue to release this kind of changes on a stable branch?\n\nI think the renamed role is not a backward compat change.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3a8947946d1b237e534f03c7e2300281a5333b8b","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - version: 15.3.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":32,"context_line":"        hash: 1de8b13f336ad4900c1c02638f4cab1e6db8fae3"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/zed"},{"line_number":35,"context_line":"    location: 15.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"738d4e5c_085ad964","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"in_reply_to":"3aa46fba_3258324a","updated":"2023-11-03 14:00:20.000000000","message":"can you explain how this is not backwards compatible and what you think will break?\n\nI can\u0027t find anything here at least:\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2038314\n\nalso not in the linked horizon docs: https://docs.openstack.org/horizon/yoga/configuration/settings.html#openstack-keystone-default-role\n\nThanks","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d59b7286f13bde032dd475941b1d70813aff0def","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - version: 15.3.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":32,"context_line":"        hash: 1de8b13f336ad4900c1c02638f4cab1e6db8fae3"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/zed"},{"line_number":35,"context_line":"    location: 15.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8caac9ab_721a03b3","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"in_reply_to":"738d4e5c_085ad964","updated":"2023-11-03 14:35:26.000000000","message":"The renamed role will not affect existing deployments, also deployers can still override the variable in their config. Deploying new clouds in a sane way is a good thing.\n\nThe features are also useful additions in order to improve the deployment experience.\n\nSo yes, we want to release with these changes.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"58205719300a2cd00e1110d69e00a7e4627b9953","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - version: 15.3.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":32,"context_line":"        hash: 1de8b13f336ad4900c1c02638f4cab1e6db8fae3"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/zed"},{"line_number":35,"context_line":"    location: 15.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aa46fba_3258324a","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"in_reply_to":"c23465c5_5471cd2c","updated":"2023-11-02 14:18:54.000000000","message":"My previous comment was related to the release note printed there \u003d\u003e https://zuul.opendev.org/t/openstack/build/ecc4e042cbfc4538b19fae5822ba2d51/log/job-output.txt#10082\n\nFeatures are listed there \u003d\u003e https://zuul.opendev.org/t/openstack/build/ecc4e042cbfc4538b19fae5822ba2d51/log/job-output.txt#10064","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4ec9e9da8cffa84a3ebeb9f86ca1f3d60d8a5e93","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - version: 15.3.0"},{"line_number":30,"context_line":"    projects:"},{"line_number":31,"context_line":"      - repo: openstack/kolla-ansible"},{"line_number":32,"context_line":"        hash: 1de8b13f336ad4900c1c02638f4cab1e6db8fae3"},{"line_number":33,"context_line":"branches:"},{"line_number":34,"context_line":"  - name: stable/zed"},{"line_number":35,"context_line":"    location: 15.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c23465c5_5471cd2c","line":32,"range":{"start_line":32,"start_character":14,"end_line":32,"end_character":54},"in_reply_to":"dbd30c33_ae47d322","updated":"2023-11-02 12:47:24.000000000","message":"I did not see a renamed role. If you are talking about Idede07a5f0fd1a3ee63e1c54a263e358e95b3a86, this is a workaround necessary due to an ansible bug, it is fully backwards compatible as consumers are not expected to touch that file at all.\n\nI also do not see any really new features, some things make deployments more configurable, but I think those are valid for a deployment project.","commit_id":"4c3c486cb2e1c65b6eec667396e2d01b89e958f6"}]}
