)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"172b42c9_874bdd9a","updated":"2024-03-12 05:25:27.000000000","message":"small nits and a update I think can be added, rest lgtm.","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"bb310b29d3fdbe310c1376c9c84b080a0fa51f80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04b8d6ff_e12e0ab6","updated":"2024-03-12 16:26:54.000000000","message":"-1 to signal that an update is on the way (as Sylvain said on IRC he wants to fix the nits)","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b3a9b4c_43a6dcde","updated":"2024-03-12 10:41:26.000000000","message":"not sure if formatting is too relevant, so not blocking this, would be fine with amending in a followup, too","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"350f5aca8fa128b136c36bcc7bf9d73561cbd41a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b4dce2b_25d82d7d","updated":"2024-03-12 09:18:26.000000000","message":"thanks for updates, LGTM","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2574f46bda47ae4ba58dd0e43e459592f983acd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e28c96fe_a82b50c4","updated":"2024-03-12 09:51:17.000000000","message":"thanks! LGTM:\n\nhttps://2d058ecf9d33e69f1842-df3a6d916dbcc54368929fa122458369.ssl.cf1.rackcdn.com/912480/2/check/openstack-tox-docs/3590503/docs/caracal/highlights.html#nova","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2d0142bbbf6fb8e35554b8c67b693767e704f3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afda5cb6_a76c6740","updated":"2024-03-12 16:29:32.000000000","message":"two small things","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3bfaed7_117bd220","updated":"2024-03-12 16:47:10.000000000","message":"Just nits, your choice, but the content itself seems good.","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dda78c1edb4b85ec4a817b75ed0b6504214c7355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29d484fc_46fb1214","updated":"2024-03-12 16:41:13.000000000","message":"My nits were fixed, looks good to me","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4005b1ba19218915912b5f2da6c3d844bcc7916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f14562ba_02783dff","updated":"2024-03-12 17:33:54.000000000","message":"lgtm, thanks","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c6f6546e4a7c809cb4721d424e34ad7aef02fc71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5db34266_66430dbe","updated":"2024-03-12 18:02:19.000000000","message":"I think most of the cores looked at the highlights, so we can now merge this.","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2652c7a5bb862d9abd51f773bfae3842a419ef41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"310177c7_8acaea61","updated":"2024-03-12 19:49:26.000000000","message":"LGTM, Let\u0027s merge this! (femtonits can be fixed in the RC patches ;))\n\nhttps://e3446ce1e3833e4fbda0-a0bbf4c39e205b934526f70ffa70564a.ssl.cf5.rackcdn.com/912480/4/check/openstack-tox-docs/4ea2e21/docs/caracal/highlights.html#nova","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd7a3cecbd7471598a45bbf31855bb80d3a9b4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41406a87_6fd60dbf","updated":"2024-03-12 18:07:56.000000000","message":"One femtonit but no need to fix before merge unless there\u0027s something else I think.","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b20e420d1b718b0426fda2974380a01f07d253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3f97398_844d56ab","updated":"2024-03-12 23:12:29.000000000","message":"i dont see nova rendred in the doc preview site\n\nhttps://3ed3fdad7e043512893b-c05366c464c48f7f4bb0c1fbbad299a5.ssl.cf1.rackcdn.com/912480/4/gate/openstack-tox-docs/b2639a7/docs/caracal/index.html#service-projects\n\nso im not sure this is even correct? amy i looking in the wrong place because nova is not listed under service project","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fcff315ac33825f732512cbab53799c3eeb0974e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"55cf3c62_91de2e0c","updated":"2024-03-12 23:22:32.000000000","message":"i guess its rendered here https://3ed3fdad7e043512893b-c05366c464c48f7f4bb0c1fbbad299a5.ssl.cf1.rackcdn.com/912480/4/gate/openstack-tox-docs/b2639a7/docs/caracal/highlights.html instead\n\nthere are some issues inline this is already merged","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"}],"deliverables/caracal/nova.yaml":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option."},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    Instances using vGPUs can now be correctly `live-migrated`__ if both of the"},{"line_number":19,"context_line":"    compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the source mediated"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3bd016ac_8bfac8d1","line":16,"updated":"2024-03-12 05:25:27.000000000","message":"w.r.t addiition to nova-manage, this seems big for operators to me, should we add this too ?\nhttps://review.opendev.org/c/openstack/nova/+/903916/4/releasenotes/notes/ironic-shards-5641e4b1ab5bb7aa.yaml","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f84d86b79ad6297e02e546d861f7d0118f69d3a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option."},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    Instances using vGPUs can now be correctly `live-migrated`__ if both of the"},{"line_number":19,"context_line":"    compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the source mediated"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fda4d2bc_ba3faa94","line":16,"in_reply_to":"3bd016ac_8bfac8d1","updated":"2024-03-12 09:01:22.000000000","message":"Done","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"96f395f5_9994d8c6","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":13},"updated":"2024-03-12 05:25:27.000000000","message":"Instances","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f84d86b79ad6297e02e546d861f7d0118f69d3a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1bc9915a_393eae57","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":13},"in_reply_to":"96f395f5_9994d8c6","updated":"2024-03-12 09:01:22.000000000","message":"Done","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":34,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"560df379_c366395d","line":31,"range":{"start_line":30,"start_character":75,"end_line":31,"end_character":12},"updated":"2024-03-12 05:25:27.000000000","message":"18% to 20% ?","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d3bb5aed4d16e5cc706f26dacfdca25d33ea24f6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":34,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"60091ae1_e5909881","line":31,"range":{"start_line":30,"start_character":75,"end_line":31,"end_character":12},"in_reply_to":"013e75fa_bf543264","updated":"2024-03-12 09:30:52.000000000","message":"ooh, I wrote `18% ` instead of 10%. hence you gave ref to rel-note, my bad.\n\nbut actually I just refering to cosmetic stuff, and wanted to ask, instead of `between 10% and 20%` should we say `between 10 to 20%` or `between 10-20%`.\nI acked earlier because I thought you are saying, in docs it will come as 10/20%.\n\nbut this do not required respin, currents seems okay too.\nthanks","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"350f5aca8fa128b136c36bcc7bf9d73561cbd41a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":34,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"013e75fa_bf543264","line":31,"range":{"start_line":30,"start_character":75,"end_line":31,"end_character":12},"in_reply_to":"2ec6020a_ecad9224","updated":"2024-03-12 09:18:26.000000000","message":"Acknowledged","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f84d86b79ad6297e02e546d861f7d0118f69d3a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":28,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Instancew using virtio-net will see an increase in performance between 10%"},{"line_number":31,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":32,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":33,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":34,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2ec6020a_ecad9224","line":31,"range":{"start_line":30,"start_character":75,"end_line":31,"end_character":12},"in_reply_to":"560df379_c366395d","updated":"2024-03-12 09:01:22.000000000","message":"Hmm, no, https://docs.openstack.org/releasenotes/nova/unreleased.html#new-features","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    ``[consoleauth]/enforce_session_timeout`` configuration option provides the"},{"line_number":37,"context_line":"    ability to automatically close a server console session when the token"},{"line_number":38,"context_line":"    expires."},{"line_number":39,"context_line":"  - Users can `boot instances with large RAM`__ by specifying either thru flavor"},{"line_number":40,"context_line":"    extra specs ``hw:maxphysaddr_mode\u003demulate`` and ``hw:maxphysaddr_bits``"},{"line_number":41,"context_line":"    or by image properties ``hw_maxphysaddr_mode`` and ``hw_maxphysaddr_bits``."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8cd29f05_7c369f99","line":39,"range":{"start_line":39,"start_character":3,"end_line":39,"end_character":4},"updated":"2024-03-12 05:25:27.000000000","message":"`| ` is missing\nthis fixies link error too at L43","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    ``[consoleauth]/enforce_session_timeout`` configuration option provides the"},{"line_number":37,"context_line":"    ability to automatically close a server console session when the token"},{"line_number":38,"context_line":"    expires."},{"line_number":39,"context_line":"  - Users can `boot instances with large RAM`__ by specifying either thru flavor"},{"line_number":40,"context_line":"    extra specs ``hw:maxphysaddr_mode\u003demulate`` and ``hw:maxphysaddr_bits``"},{"line_number":41,"context_line":"    or by image properties ``hw_maxphysaddr_mode`` and ``hw_maxphysaddr_bits``."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f0de8652_e1408270","line":39,"range":{"start_line":39,"start_character":69,"end_line":39,"end_character":73},"updated":"2024-03-12 05:25:27.000000000","message":"valid `through`","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f84d86b79ad6297e02e546d861f7d0118f69d3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    ``[consoleauth]/enforce_session_timeout`` configuration option provides the"},{"line_number":37,"context_line":"    ability to automatically close a server console session when the token"},{"line_number":38,"context_line":"    expires."},{"line_number":39,"context_line":"  - Users can `boot instances with large RAM`__ by specifying either thru flavor"},{"line_number":40,"context_line":"    extra specs ``hw:maxphysaddr_mode\u003demulate`` and ``hw:maxphysaddr_bits``"},{"line_number":41,"context_line":"    or by image properties ``hw_maxphysaddr_mode`` and ``hw_maxphysaddr_bits``."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"48045a8d_15a113a2","line":39,"range":{"start_line":39,"start_character":3,"end_line":39,"end_character":4},"in_reply_to":"8cd29f05_7c369f99","updated":"2024-03-12 09:01:22.000000000","message":"Done","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"865bc079f20be166e40142ca1401e10dd8f3a9ba","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    Hyper-V virt driver has been removed. It was deprecated in the Nova 27.2.0"},{"line_number":47,"context_line":"    (Antelope) release. This driver was untested and has no maintainers. In"},{"line_number":48,"context_line":"    addition, it has a dependency on the OpenStack Winstacker project that also"},{"line_number":49,"context_line":"    has been retired."},{"line_number":50,"context_line":"  - |"},{"line_number":51,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e06c5bdd_72aa55e6","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":20},"updated":"2024-03-12 05:25:27.000000000","message":"had","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f84d86b79ad6297e02e546d861f7d0118f69d3a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    Hyper-V virt driver has been removed. It was deprecated in the Nova 27.2.0"},{"line_number":47,"context_line":"    (Antelope) release. This driver was untested and has no maintainers. In"},{"line_number":48,"context_line":"    addition, it has a dependency on the OpenStack Winstacker project that also"},{"line_number":49,"context_line":"    has been retired."},{"line_number":50,"context_line":"  - |"},{"line_number":51,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9c925d1f_eeb070a3","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":20},"in_reply_to":"e06c5bdd_72aa55e6","updated":"2024-03-12 09:01:22.000000000","message":"Done","commit_id":"b9179cac193eac9320c5a8d1d269961645bd6be3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    deprecated. The Ironic driver now more closely models other Nova drivers by"},{"line_number":12,"context_line":"    having a single compute have exclusive control over assigned nodes. If high"},{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new `nova-manage` command ``db"},{"line_number":17,"context_line":"    ironic_compute_node_move`` can help the operators for upgrading their"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"789bf206_006fa916","line":14,"range":{"start_line":14,"start_character":67,"end_line":14,"end_character":70},"updated":"2024-03-12 10:41:26.000000000","message":"nit: double \"now\"","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    deprecated. The Ironic driver now more closely models other Nova drivers by"},{"line_number":12,"context_line":"    having a single compute have exclusive control over assigned nodes. If high"},{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new `nova-manage` command ``db"},{"line_number":17,"context_line":"    ironic_compute_node_move`` can help the operators for upgrading their"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0b00735e_1afde8d7","line":14,"range":{"start_line":14,"start_character":67,"end_line":14,"end_character":70},"in_reply_to":"789bf206_006fa916","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new `nova-manage` command ``db"},{"line_number":17,"context_line":"    ironic_compute_node_move`` can help the operators for upgrading their"},{"line_number":18,"context_line":"    computes and telling which shard they would use."},{"line_number":19,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9419ca6f_c339f9a2","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":48},"updated":"2024-03-12 10:41:26.000000000","message":"should be in double backticks","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can now target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new `nova-manage` command ``db"},{"line_number":17,"context_line":"    ironic_compute_node_move`` can help the operators for upgrading their"},{"line_number":18,"context_line":"    computes and telling which shard they would use."},{"line_number":19,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f5d504cc_ee88481d","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":48},"in_reply_to":"9419ca6f_c339f9a2","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b8f16ec5_8c92d4f5","line":28,"range":{"start_line":28,"start_character":51,"end_line":28,"end_character":78},"updated":"2024-03-12 10:41:26.000000000","message":"nit: bad quoting single backtick vs. double","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called `pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bca9b29d_d77e3f46","line":28,"range":{"start_line":28,"start_character":51,"end_line":28,"end_character":78},"in_reply_to":"b8f16ec5_8c92d4f5","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":33,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":34,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"55938470_8dc2ca22","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":66},"updated":"2024-03-12 10:41:26.000000000","message":"should be quoted in double backticks","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":33,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":34,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8de5b68b_e006d868","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":66},"in_reply_to":"55938470_8dc2ca22","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d68ce1f570eb83e2fbe39a7a5266df59429808ee","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":33,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":34,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"},{"line_number":36,"context_line":"    As a new security mechanism, a new"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa7e445_27e21924","line":33,"updated":"2024-03-12 10:41:26.000000000","message":"dito","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new `hw:virtio_packed_ring\u003dtrue` property or"},{"line_number":33,"context_line":"    their flavor contains `hw_virtio_packed_ring\u003dtrue` extra spec, provided"},{"line_number":34,"context_line":"    libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"},{"line_number":36,"context_line":"    As a new security mechanism, a new"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b08e5745_342b24a4","line":33,"in_reply_to":"7aa7e445_27e21924","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2d0142bbbf6fb8e35554b8c67b693767e704f3b","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    has been retired."},{"line_number":51,"context_line":"  - |"},{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of guests with memory"},{"line_number":54,"context_line":"    encrypted which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c22f3014_8584442a","line":54,"range":{"start_line":53,"start_character":22,"end_line":54,"end_character":13},"updated":"2024-03-12 16:29:32.000000000","message":"guests with memory encryption?","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    has been retired."},{"line_number":51,"context_line":"  - |"},{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of guests with memory"},{"line_number":54,"context_line":"    encrypted which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"95aef0ae_27e78ab4","line":54,"range":{"start_line":53,"start_character":22,"end_line":54,"end_character":13},"in_reply_to":"c22f3014_8584442a","updated":"2024-03-12 16:37:04.000000000","message":"Done","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2d0142bbbf6fb8e35554b8c67b693767e704f3b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of guests with memory"},{"line_number":54,"context_line":"    encrypted which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7cfccb4e_90e6ec0e","line":55,"range":{"start_line":55,"start_character":3,"end_line":55,"end_character":15},"updated":"2024-03-12 16:29:32.000000000","message":"...IP address or hostname for incoming...\n\n(The important piece here is that we allow non IP based configs)","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee706e8528dfe5829d1a715c297dfec2f55763dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of guests with memory"},{"line_number":54,"context_line":"    encrypted which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"feff6de6_5e5bc36e","line":55,"range":{"start_line":55,"start_character":3,"end_line":55,"end_character":15},"in_reply_to":"7cfccb4e_90e6ec0e","updated":"2024-03-12 16:37:04.000000000","message":"doh, you\u0027re right. Done.","commit_id":"db6db8a0199b077e9fd806b941c97fcbab29a323"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new ``nova-manage db ironic_compute_node_move``"},{"line_number":17,"context_line":"    command can help the operators for upgrading their computes and telling"},{"line_number":18,"context_line":"    which shard they would use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ebe7d17e_8646d514","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":38},"updated":"2024-03-12 16:47:10.000000000","message":"I would say \"when\" here, but not a huge deal.","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new ``nova-manage db ironic_compute_node_move``"},{"line_number":17,"context_line":"    command can help the operators for upgrading their computes and telling"},{"line_number":18,"context_line":"    which shard they would use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"361310ef_5e9bdd10","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":38},"in_reply_to":"ebe7d17e_8646d514","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new ``nova-manage db ironic_compute_node_move``"},{"line_number":17,"context_line":"    command can help the operators for upgrading their computes and telling"},{"line_number":18,"context_line":"    which shard they would use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"},{"line_number":21,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0406a859_beede5a3","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":26},"updated":"2024-03-12 16:47:10.000000000","message":"Also \"could\" here.","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"},{"line_number":16,"context_line":"    configuration option and a new ``nova-manage db ironic_compute_node_move``"},{"line_number":17,"context_line":"    command can help the operators for upgrading their computes and telling"},{"line_number":18,"context_line":"    which shard they would use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"},{"line_number":21,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"68198d75_b63dba25","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":26},"in_reply_to":"0406a859_beede5a3","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    if both of the compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the"},{"line_number":23,"context_line":"    source mediated device will migrate the GPU memory to another target"},{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"},{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"65045015_f84e6e73","line":25,"range":{"start_line":25,"start_character":67,"end_line":25,"end_character":75},"updated":"2024-03-12 16:47:10.000000000","message":"Maybe say \"according to the aforementioned documentation\" or something. I read this and thought \"modified how?\" but I see it\u0027s in the document you linked above, but it wasn\u0027t super clear to me when first reading this.","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    if both of the compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the"},{"line_number":23,"context_line":"    source mediated device will migrate the GPU memory to another target"},{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"},{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"65d683d2_2fdb8946","line":25,"range":{"start_line":25,"start_character":67,"end_line":25,"end_character":75},"in_reply_to":"65045015_f84e6e73","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"},{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"33dacded_87bde806","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":6},"updated":"2024-03-12 16:47:10.000000000","message":"I would say \"as of\" or \"in\" here.","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"},{"line_number":25,"context_line":"    ``[libvirt/live_migration_downtime`` config option needs to be modified."},{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"98490c2d_99847d63","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":6},"in_reply_to":"33dacded_87bde806","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new ``hw:virtio_packed_ring\u003dtrue`` property"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"20e9634f_a152858a","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":64},"updated":"2024-03-12 16:47:10.000000000","message":"This is a bit awkward to read and probably isn\u0027t what a native speaker would say. I know what you mean, but perhaps \"indicates whether the instance is confined to a specific AZ or if it can be migrated to another one.\"","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  - |"},{"line_number":27,"context_line":"    By the new 2.96 microversion, when asking the API for a server show or a"},{"line_number":28,"context_line":"    server list, it returns a new parameter called ``pinned_availability_zone``"},{"line_number":29,"context_line":"    that tells whether the instance can\u0027t move off a specific AZ."},{"line_number":30,"context_line":"  - |"},{"line_number":31,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":32,"context_line":"    and 20% if their image uses a new ``hw:virtio_packed_ring\u003dtrue`` property"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"51bfcd4f_addb7ada","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":64},"in_reply_to":"20e9634f_a152858a","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    or their flavor contains ``hw_virtio_packed_ring\u003dtrue`` extra spec,"},{"line_number":34,"context_line":"    provided libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"},{"line_number":36,"context_line":"    As a new security mechanism, a new"},{"line_number":37,"context_line":"    ``[consoleauth]/enforce_session_timeout`` configuration option provides the"},{"line_number":38,"context_line":"    ability to automatically close a server console session when the token"},{"line_number":39,"context_line":"    expires."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4d1b28c7_f580bde0","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":38},"updated":"2024-03-12 16:47:10.000000000","message":"I would remove this extra \"new\"","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    or their flavor contains ``hw_virtio_packed_ring\u003dtrue`` extra spec,"},{"line_number":34,"context_line":"    provided libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":35,"context_line":"  - |"},{"line_number":36,"context_line":"    As a new security mechanism, a new"},{"line_number":37,"context_line":"    ``[consoleauth]/enforce_session_timeout`` configuration option provides the"},{"line_number":38,"context_line":"    ability to automatically close a server console session when the token"},{"line_number":39,"context_line":"    expires."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6df18e6a_eb824758","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":38},"in_reply_to":"4d1b28c7_f580bde0","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    ``hw:maxphysaddr_mode\u003demulate`` and ``hw:maxphysaddr_bits`` or by image"},{"line_number":45,"context_line":"    properties ``hw_maxphysaddr_mode`` and ``hw_maxphysaddr_bits``."},{"line_number":46,"context_line":"  - |"},{"line_number":47,"context_line":"    Hyper-V virt driver has been removed. It was deprecated in the Nova 27.2.0"},{"line_number":48,"context_line":"    (Antelope) release. This driver was untested and has no maintainers. In"},{"line_number":49,"context_line":"    addition, it had a dependency on the OpenStack Winstacker project that also"},{"line_number":50,"context_line":"    has been retired."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7892753b_f1b30c35","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":11},"updated":"2024-03-12 16:47:10.000000000","message":"\"The Hyper-V\"","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    ``hw:maxphysaddr_mode\u003demulate`` and ``hw:maxphysaddr_bits`` or by image"},{"line_number":45,"context_line":"    properties ``hw_maxphysaddr_mode`` and ``hw_maxphysaddr_bits``."},{"line_number":46,"context_line":"  - |"},{"line_number":47,"context_line":"    Hyper-V virt driver has been removed. It was deprecated in the Nova 27.2.0"},{"line_number":48,"context_line":"    (Antelope) release. This driver was untested and has no maintainers. In"},{"line_number":49,"context_line":"    addition, it had a dependency on the OpenStack Winstacker project that also"},{"line_number":50,"context_line":"    has been retired."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"30270e99_ee46a36a","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":11},"in_reply_to":"7892753b_f1b30c35","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    addition, it had a dependency on the OpenStack Winstacker project that also"},{"line_number":50,"context_line":"    has been retired."},{"line_number":51,"context_line":"  - |"},{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of instances with memory"},{"line_number":54,"context_line":"    encryption which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address or hostname for incoming move operations (by setting"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"04126734_cc5790c9","line":52,"range":{"start_line":52,"start_character":77,"end_line":52,"end_character":78},"updated":"2024-03-12 16:47:10.000000000","message":"Maybe \":\" here?","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    addition, it had a dependency on the OpenStack Winstacker project that also"},{"line_number":50,"context_line":"    has been retired."},{"line_number":51,"context_line":"  - |"},{"line_number":52,"context_line":"    A couple of other improvements target reducing the number of bugs we have,"},{"line_number":53,"context_line":"    one automatically detecting the maximum number of instances with memory"},{"line_number":54,"context_line":"    encryption which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address or hostname for incoming move operations (by setting"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2d835b18_3391e790","line":52,"range":{"start_line":52,"start_character":77,"end_line":52,"end_character":78},"in_reply_to":"04126734_cc5790c9","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4cfaa21003c82906cc3f61c60211447082b1ee7","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    one automatically detecting the maximum number of instances with memory"},{"line_number":54,"context_line":"    encryption which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address or hostname for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a88fcc2_0aee5658","line":56,"range":{"start_line":56,"start_character":42,"end_line":56,"end_character":44},"updated":"2024-03-12 16:47:10.000000000","message":"\"and\"","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"942178bf6003196972695f099b777d0b2b6c2b15","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    one automatically detecting the maximum number of instances with memory"},{"line_number":54,"context_line":"    encryption which can run concurrently, another one allowing to specific an"},{"line_number":55,"context_line":"    IP address or hostname for incoming move operations (by setting"},{"line_number":56,"context_line":"    ``[libvirt]/migration_inbound_addr``) or yet another one defining aliases"},{"line_number":57,"context_line":"    for libvirt disks as a defined identifier to look at."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"82ec7d62_f431655b","line":56,"range":{"start_line":56,"start_character":42,"end_line":56,"end_character":44},"in_reply_to":"7a88fcc2_0aee5658","updated":"2024-03-12 18:01:23.000000000","message":"Done","commit_id":"fd853c5768eda00d823bd0e165a83d45cd5f453f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b20e420d1b718b0426fda2974380a01f07d253","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The Ironic driver ``[ironic]/peer_list`` configuration option has been"},{"line_number":11,"context_line":"    deprecated. The Ironic driver now more closely models other Nova drivers by"},{"line_number":12,"context_line":"    having a single compute have exclusive control over assigned nodes. If high"},{"line_number":13,"context_line":"    availability of a single compute service is required, operators should use"},{"line_number":14,"context_line":"    active/passive failover. Now, Ironic nova-compute services can target a"},{"line_number":15,"context_line":"    specific shard of ironic nodes by setting the ``[ironic]/shard``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cb0e4ef6_d6ce4f4c","line":12,"updated":"2024-03-12 23:12:29.000000000","message":"nit: single compute service manage compute nodes.\n\nthe is no such think as assined node in nova, i.e. there is not api resouce or mechaime to asign a comptue node to a compute service, so this is kind of confusing.","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b20e420d1b718b0426fda2974380a01f07d253","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    command can help the operators when upgrading their computes and telling"},{"line_number":18,"context_line":"    which shard they could use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"},{"line_number":21,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats\u003e`_"},{"line_number":22,"context_line":"    if both of the compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the"},{"line_number":23,"context_line":"    source mediated device will migrate the GPU memory to another target"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5eb7633e_f548037b","line":20,"updated":"2024-03-12 23:12:29.000000000","message":"nit \\`\\`text\\`\\`  if you want it to be a literal or bolded item.\n\n\\`\\` if you use single backthiks that for invokeing funtions/macros in rst","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b20e420d1b718b0426fda2974380a01f07d253","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    which shard they could use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"},{"line_number":21,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats\u003e`_"},{"line_number":22,"context_line":"    if both of the compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the"},{"line_number":23,"context_line":"    source mediated device will migrate the GPU memory to another target"},{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cb3d5361_94e390c5","line":21,"updated":"2024-03-12 23:12:29.000000000","message":"if you end in _ like that i would expect it to have a link\n\nthis looks like it should be a syntax error to me.\n\nit might be good to run sphinxlint on this","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fcff315ac33825f732512cbab53799c3eeb0974e","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    which shard they could use."},{"line_number":19,"context_line":"  - |"},{"line_number":20,"context_line":"    Instances using `vGPUs can now be correctly live-migrated"},{"line_number":21,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats\u003e`_"},{"line_number":22,"context_line":"    if both of the compute nodes support libvirt-8.6.0 and QEMU-8.1.0, as the"},{"line_number":23,"context_line":"    source mediated device will migrate the GPU memory to another target"},{"line_number":24,"context_line":"    mediated device automatically. In order to do this,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bce0a330_118a3579","line":21,"in_reply_to":"cb3d5361_94e390c5","updated":"2024-03-12 23:22:32.000000000","message":"this link does apper to be working if its not how we normally do it.\n\ni tought there was a reason why we avoid doing this but perhspas stephen fixed this in sphinx","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b20e420d1b718b0426fda2974380a01f07d253","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    Instances using virtio-net will see an increase in performance between 10%"},{"line_number":34,"context_line":"    and 20% if their image uses a new ``hw:virtio_packed_ring\u003dtrue`` property"},{"line_number":35,"context_line":"    or their flavor contains ``hw_virtio_packed_ring\u003dtrue`` extra spec,"},{"line_number":36,"context_line":"    provided libvirt version is \u003e\u003d 6.3 and QEMU \u003e\u003d 4.2."},{"line_number":37,"context_line":"  - |"},{"line_number":38,"context_line":"    As a security mechanism, a new ``[consoleauth]/enforce_session_timeout``"},{"line_number":39,"context_line":"    configuration option provides the ability to automatically close a server"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ba1ce6e_7363c3d5","line":36,"updated":"2024-03-12 23:12:29.000000000","message":"you flipped the image and flavor. hw: is a flavor extraspec hw_ is a image propety","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd7a3cecbd7471598a45bbf31855bb80d3a9b4f9","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    In addition, it had a dependency on the OpenStack Winstacker project that"},{"line_number":51,"context_line":"    also has been retired."},{"line_number":52,"context_line":"  - |"},{"line_number":53,"context_line":"    A couple of other improvements target reducing the number of bugs we have :"},{"line_number":54,"context_line":"    one automatically detecting the maximum number of instances with memory"},{"line_number":55,"context_line":"    encryption which can run concurrently, another one allowing to specific an"},{"line_number":56,"context_line":"    IP address or hostname for incoming move operations (by setting"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a74a56b4_3b9990e4","line":53,"range":{"start_line":53,"start_character":77,"end_line":53,"end_character":79},"updated":"2024-03-12 18:07:56.000000000","message":"Extra space in front of the colon here","commit_id":"7422345f5a739256781a71f2d14732c92991dc93"}]}