)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b3bf03c7560be44f1350acb1fdea0c30fa7a454a","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- adds a fix to match complete \u003cseries\u003e-eol tag when comparing with"},{"line_number":20,"context_line":"  latest version (this eliminates a bug, when the latest version is"},{"line_number":21,"context_line":"  a previous series\u0027 EOL tag, e.g. when EO{M,L}\u0027ing tagless repos)"},{"line_number":22,"context_line":"- handles the new type of \u003cbranch_id\u003e-eom and \u003cbranch_id\u003e-eol tags"},{"line_number":23,"context_line":"  (for example 2023.1-eol)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id7e003b8070796cc99516a28752f94eaca62af61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0283a7f_fd312ff0","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":26},"updated":"2024-11-01 20:12:43.000000000","message":"As you are handling this, can you fix it for tempest|plugins \u003cseries\u003e-last tag also? I am trying to release 2023.1-last tag but below validation still need release name in -last tag\n\nhttps://github.com/openstack/releases/blob/c589ae65e9d4047856c09bf49787ccfa41e76087/openstack_releases/cmds/validate.py#L1194 \n\ntempest tag for 2023.1-last -\u003e\nhttps://review.opendev.org/c/openstack/releases/+/933938","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"87f8f6518e5801a9f9d995333b3f81cf71abba5f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  latest version (this eliminates a bug, when the latest version is"},{"line_number":21,"context_line":"  a previous series\u0027 EOL tag, e.g. when EO{M,L}\u0027ing tagless repos)"},{"line_number":22,"context_line":"- handles the new type of \u003cbranch_id\u003e-eom and \u003cbranch_id\u003e-eol tags"},{"line_number":23,"context_line":"  (for example 2023.1-eol)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id7e003b8070796cc99516a28752f94eaca62af61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"af797373_772714f7","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":25},"updated":"2024-10-22 19:04:14.000000000","message":"i fear that the dot in the tag might cause issues in our tools as reno and other tools might split the \u0027versions\u0027 (including tags) by the dots. 2023-1-eol might be better than 2023.1-eol, but that also needs fixes probably at some/many places... :-/","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4e301bfceffaacb0c000a96658d2156716b4f29","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- adds a fix to match complete \u003cseries\u003e-eol tag when comparing with"},{"line_number":20,"context_line":"  latest version (this eliminates a bug, when the latest version is"},{"line_number":21,"context_line":"  a previous series\u0027 EOL tag, e.g. when EO{M,L}\u0027ing tagless repos)"},{"line_number":22,"context_line":"- handles the new type of \u003cbranch_id\u003e-eom and \u003cbranch_id\u003e-eol tags"},{"line_number":23,"context_line":"  (for example 2023.1-eol)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id7e003b8070796cc99516a28752f94eaca62af61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3e93eb91_ff29841e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":26},"in_reply_to":"34f68786_b143aeb8","updated":"2024-11-06 18:36:45.000000000","message":"sounds good, thanks.","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b35ee121d1879823ec0320cc1fd017c9db26e77f","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- adds a fix to match complete \u003cseries\u003e-eol tag when comparing with"},{"line_number":20,"context_line":"  latest version (this eliminates a bug, when the latest version is"},{"line_number":21,"context_line":"  a previous series\u0027 EOL tag, e.g. when EO{M,L}\u0027ing tagless repos)"},{"line_number":22,"context_line":"- handles the new type of \u003cbranch_id\u003e-eom and \u003cbranch_id\u003e-eol tags"},{"line_number":23,"context_line":"  (for example 2023.1-eol)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id7e003b8070796cc99516a28752f94eaca62af61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"34f68786_b143aeb8","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":26},"in_reply_to":"a0283a7f_fd312ff0","updated":"2024-11-06 09:45:14.000000000","message":"yeah, I\u0027ll patch the validator to handle 2023.1-last and 2023.1-eol as well, but i\u0027m planning to do that on a separate patch to avoid having a single huge patch.","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"465384249442aac80c99bdbdd42997a7a5830533","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  latest version (this eliminates a bug, when the latest version is"},{"line_number":21,"context_line":"  a previous series\u0027 EOL tag, e.g. when EO{M,L}\u0027ing tagless repos)"},{"line_number":22,"context_line":"- handles the new type of \u003cbranch_id\u003e-eom and \u003cbranch_id\u003e-eol tags"},{"line_number":23,"context_line":"  (for example 2023.1-eol)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id7e003b8070796cc99516a28752f94eaca62af61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7c520f41_230785a3","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":25},"in_reply_to":"af797373_772714f7","updated":"2024-11-01 11:25:48.000000000","message":"I would prefer for the branch_id in the tag name to be the same as the branch_id in the live branch and not have additional mangling there. If other tooling needs to be adopted, so be it.","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"dd140c4cbf3c55b07d5e75bfd2480197eb6c5e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49b7e3d6_8e3f4c2d","updated":"2024-11-07 09:57:33.000000000","message":"LGTM","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"465384249442aac80c99bdbdd42997a7a5830533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71d05c16_13290f94","updated":"2024-11-01 11:25:48.000000000","message":"Overriding PTL-approval flag for code change","commit_id":"ae213e1660b00dec9079c20df9f55dcf653e7ad4"}],"openstack_releases/cmds/new_release.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6f41d6e3b98dfe2ff65fab30cfe94e47aa5bd300","unresolved":true,"context_lines":[{"line_number":306,"context_line":"    add_intermediate_branch \u003d args.intermediate_branch"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    # Validate new tag can be applied"},{"line_number":309,"context_line":"    if last_version and f\u0027{series}-eol\u0027 in last_version[0]:"},{"line_number":310,"context_line":"        raise ValueError(\u0027Cannot create new release after EOL tagging.\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if last_version is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"24292c1d_4cc797ea","line":309,"updated":"2024-04-09 07:01:34.000000000","message":"Wouldn\u0027t this need to use get_stable_branch_id(series)?\n\nThe tag will be 2023.1-eol, not antelope-eol, will it?","commit_id":"14f42730257507613b09f8d51c386f1d3d4f65c8"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"55851b5289926900e4bc0ef650e0a0cd6de92ba8","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    add_intermediate_branch \u003d args.intermediate_branch"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    # Validate new tag can be applied"},{"line_number":309,"context_line":"    if last_version and f\u0027{series}-eol\u0027 in last_version[0]:"},{"line_number":310,"context_line":"        raise ValueError(\u0027Cannot create new release after EOL tagging.\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if last_version is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6610d37_472fad33","line":309,"in_reply_to":"24292c1d_4cc797ea","updated":"2024-10-22 18:09:56.000000000","message":"Done","commit_id":"14f42730257507613b09f8d51c386f1d3d4f65c8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6f41d6e3b98dfe2ff65fab30cfe94e47aa5bd300","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        new_version \u003d \u0027{}-{}\u0027.format(args.series, args.release_type)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    else:"},{"line_number":414,"context_line":"        if last_version and f\u0027{series}-eom\u0027 in last_version[0]:"},{"line_number":415,"context_line":"            raise ValueError(\u0027Cannot create new release after EOM tagging.\u0027)"},{"line_number":416,"context_line":"        increment \u003d {"},{"line_number":417,"context_line":"            \u0027bugfix\u0027: (0, 0, 1),"}],"source_content_type":"text/x-python","patch_set":1,"id":"06ced3dd_4f4968f0","line":414,"updated":"2024-04-09 07:01:34.000000000","message":"dito\n\nI also wonder if this check needs to be placed earlier in order to block the other release variants in this if-tree. we only want to allow an eol release after eom?","commit_id":"14f42730257507613b09f8d51c386f1d3d4f65c8"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"55851b5289926900e4bc0ef650e0a0cd6de92ba8","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        new_version \u003d \u0027{}-{}\u0027.format(args.series, args.release_type)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    else:"},{"line_number":414,"context_line":"        if last_version and f\u0027{series}-eom\u0027 in last_version[0]:"},{"line_number":415,"context_line":"            raise ValueError(\u0027Cannot create new release after EOM tagging.\u0027)"},{"line_number":416,"context_line":"        increment \u003d {"},{"line_number":417,"context_line":"            \u0027bugfix\u0027: (0, 0, 1),"}],"source_content_type":"text/x-python","patch_set":1,"id":"04748c1b_bbb17cb7","line":414,"in_reply_to":"06ced3dd_4f4968f0","updated":"2024-10-22 18:09:56.000000000","message":"Done","commit_id":"14f42730257507613b09f8d51c386f1d3d4f65c8"}]}