)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ed9a200a80ee77ecbe94889826bb94cebd3389f9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-04 12:16:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstackdocstheme 4.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We bump the minimum version of Sphinx and address incompatibilities with"},{"line_number":10,"context_line":"the latest versions of same."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e591ff08_2bddd682","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":24},"updated":"2024-10-04 12:20:57.000000000","message":"nit: this should be 3.4.0 o:)","commit_id":"6617d734784175caa7e6e6ef91996181c45377f0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e77956efbb528540b88f90142f6c11059366f9bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-04 12:16:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstackdocstheme 4.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We bump the minimum version of Sphinx and address incompatibilities with"},{"line_number":10,"context_line":"the latest versions of same."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e63d27ee_124d2eb3","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":24},"in_reply_to":"e591ff08_2bddd682","updated":"2024-10-04 13:46:58.000000000","message":"Done","commit_id":"6617d734784175caa7e6e6ef91996181c45377f0"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f5579d1363a63584e0d276326b97e061a9cc3d54","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstackdocstheme 4.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We bump the minimum version of Sphinx and address incompatibilities with"},{"line_number":10,"context_line":"the latest versions of same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iccbd82711f1a93287d7f4071a6ee00cc7ae83267"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3575ab60_bbe64c21","line":9,"updated":"2024-10-04 12:22:00.000000000","message":"nit: minor o:)","commit_id":"6617d734784175caa7e6e6ef91996181c45377f0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e77956efbb528540b88f90142f6c11059366f9bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstackdocstheme 4.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We bump the minimum version of Sphinx and address incompatibilities with"},{"line_number":10,"context_line":"the latest versions of same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iccbd82711f1a93287d7f4071a6ee00cc7ae83267"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d5b18ae2_055c77b0","line":9,"in_reply_to":"3575ab60_bbe64c21","updated":"2024-10-04 13:46:58.000000000","message":"No, minimum is correct here.","commit_id":"6617d734784175caa7e6e6ef91996181c45377f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"60088ddf53a27b34aabb1d854ce86dd8c1b5b148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cc9d291_e45ccec4","updated":"2024-08-30 12:35:03.000000000","message":"I\u0027m a bit hesitant, once because of the new Sphinx (MAJOR) version could cause some docs job to fail for projects (i know that it probably should be easy to fix, but the question whether we realise the broken gates at 2024.2 Dalmatian official release time O.o), the other thing is though that a major version bump on Sphinx might not be require a major version bump on openstackdocstheme, but i might be wrong with this and better to bump major version.","commit_id":"3ce98c3ec615f317e97bed2ae6df3e671a967ad7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"86b0354dc671e282f09d236a78b13660fdb5d9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"976a8dea_fce156fa","updated":"2024-09-06 12:51:53.000000000","message":"for docs builds running in the CI, upper-constraints is pinning the version of sphinx and it has been at a higher version than the minimum constraint of this lib for quite some time, so I don\u0027t expect any issue with this\n\nwhat I\u0027m not sure about, is whether this library falls under the general library freeze we have before the upcoming release","commit_id":"3ce98c3ec615f317e97bed2ae6df3e671a967ad7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ab87aafea660cb149fba942555ca13c867b0789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c38657d3_145ddf1b","in_reply_to":"3b493dd5_df852764","updated":"2024-10-04 12:15:23.000000000","message":"Good point. Let\u0027s go with 3.4.0.","commit_id":"3ce98c3ec615f317e97bed2ae6df3e671a967ad7"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e1a2eee4557ede1f027c8c08d81ca252413b6656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b493dd5_df852764","in_reply_to":"8cc9d291_e45ccec4","updated":"2024-10-04 10:14:52.000000000","message":"Dalmatian is released, so let\u0027s release this ASAP.\n\nGiving -1 to highlight my concern regarding MAJOR version bump. (requirements bumps are usually MINOR version bumps, and as the commit message states \"this will have near zero effect on anyone\", if you insist to MAJOR bump then I\u0027m OK with that, given that openstackdocstheme is so dependent on Sphinx (afaik)).","commit_id":"3ce98c3ec615f317e97bed2ae6df3e671a967ad7"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"34daa61ea854773dadfc7d785d367bd38a1b0db2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c888717_829cfb2d","updated":"2024-10-04 15:07:01.000000000","message":"Thanks, LGTM!","commit_id":"c43067dabe3cad5db815c9fbba81f7f012f22d7b"}]}
