)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ca76992a3c6646d6ddfc89c57b9be65e574d47c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37d48703_2afbaf87","updated":"2024-11-12 15:00:54.000000000","message":"Thanks Sean. Yepp, some could have been merged, but if they haven\u0027t been approved until now, then they are OK to merge after the transition. So let\u0027s proceed. Generated patch looks correct. Let\u0027s merge this.","commit_id":"94c90c0915ffac0ae91a6417129e1be473d88059"}],"deliverables/antelope/python-watcherclient.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71b3d1ae602b8e76e93e2021ec58b3fdf14e2fc0","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - version: 2023.1-eom"},{"line_number":15,"context_line":"    projects:"},{"line_number":16,"context_line":"      - repo: openstack/python-watcherclient"},{"line_number":17,"context_line":"        hash: 6dcf75021ebc79ba07b2330942777d018217c21b"},{"line_number":18,"context_line":"branches:"},{"line_number":19,"context_line":"  - name: stable/2023.1"},{"line_number":20,"context_line":"    location: 4.1.0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"63256388_7bbd494e","line":17,"updated":"2024-11-12 12:03:33.000000000","message":"+1 there are no openchanges and this is the tip of the branch\n\nhttps://review.opendev.org/q/project:openstack/python-watcherclient+is:open+branch:stable/2023.1\n\nhttps://opendev.org/openstack/python-watcherclient/src/branch/stable/2023.1","commit_id":"94c90c0915ffac0ae91a6417129e1be473d88059"}],"deliverables/antelope/watcher-dashboard.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71b3d1ae602b8e76e93e2021ec58b3fdf14e2fc0","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  - version: 2023.1-eom"},{"line_number":20,"context_line":"    projects:"},{"line_number":21,"context_line":"      - repo: openstack/watcher-dashboard"},{"line_number":22,"context_line":"        hash: b77d5c2b17418b7068665658edf58809e4f91170"},{"line_number":23,"context_line":"branches:"},{"line_number":24,"context_line":"  - name: stable/2023.1"},{"line_number":25,"context_line":"    location: 9.0.0.0rc1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6f38e046_d79e284e","line":22,"updated":"2024-11-12 12:03:33.000000000","message":"there is only one outstandign patch\n\nhttps://review.opendev.org/c/openstack/watcher-dashboard/+/875667\n\nthat woudl be woth including but it should have been done 18 months ago.\n\nthis just updates the tox file to use \n\ninstall_command \u003d pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2023.1} {opts} {packages}\n\ninstead of \n\ninstall_command \u003d pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}\n\nthis can be resolved in the unmaintaiend branch.\n\nit has been testign with the wrong constraits file since the stabel branch was created so its possible but improably that there is a conflict that woudl require addtional fixes to resolve.\ngiven that i dont think we should change it in the final EOM release but if other belvie otherwise we could try and merge it.\n\nunfortonely i do not currently have access to watcher-core so i cannot apporve that patch currently.\n\nwiht that context im +1 on thise release patch in its current form from a release liason point of view.\n\nif the release team is happy with my comments please proceed with this.","commit_id":"94c90c0915ffac0ae91a6417129e1be473d88059"}],"deliverables/antelope/watcher.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71b3d1ae602b8e76e93e2021ec58b3fdf14e2fc0","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    projects:"},{"line_number":21,"context_line":"      - repo: openstack/watcher"},{"line_number":22,"context_line":"        hash: c014f81a8647287f6dcc339321c1256f5a2e82d5"},{"line_number":23,"context_line":"branches:"},{"line_number":24,"context_line":"  - name: stable/2023.1"},{"line_number":25,"context_line":"    location: 10.0.0.0rc1"},{"line_number":26,"context_line":"  - name: unmaintained/2023.1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fbb10879_8692adaf","line":23,"updated":"2024-11-12 12:03:33.000000000","message":"this is the tip of the branch \nhttps://opendev.org/openstack/watcher/src/branch/stable/2023.1\n\n\nthere are two open changes\n\nhttps://review.opendev.org/q/project:openstack/watcher+is:open+branch:stable/2023.1\n\nthe commit message in https://review.opendev.org/c/openstack/watcher/+/934367 is kind of misleading as it actually removes a check in the code and comments out testing\n\nI\u0027m not inclined to merge this at this point and would instead leave it to the unmaintained reviews to decide if it is appropriate.\ngiven there is no context and no test coverage I can\u0027t say that it correct so im not inlcined to merge it or hold the release for it.\n\nhttps://review.opendev.org/c/openstack/watcher/+/934182 is more reasonable to include but it currently has pep8 failiures due to the bandit security checks.\n\n\n Issue: [B113:request_without_timeout] Call to requests without timeout\n   Severity: Medium   Confidence: Low\n   CWE: CWE-400 (https://cwe.mitre.org/data/definitions/400.html)\n   More Info: https://bandit.readthedocs.io/en/1.7.10/plugins/b113_request_without_timeout.html\n   Location: watcher/decision_engine/datasources/grafana.py:140:15\n138\t            raise exception.DataSourceNotAvailable(self.NAME)\n139\t\n140\t        resp \u003d requests.get(self._base_url + str(project_id) + \u0027/query\u0027,\n141\t                            params\u003dparams, headers\u003dself._headers)\n142\t        if resp.status_code \u003d\u003d HTTPStatus.OK:\n143\t            return resp\n\nso again I\u0027m inclined to say this should be defered to the the unmaintaiend team to evaluate\n\ngiven the above my incliantion is to proceed with the transition.","commit_id":"94c90c0915ffac0ae91a6417129e1be473d88059"}]}