)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c0688b667d569d1d8f276aa03c5986467e6596d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"907a54c0_ff1b3fcb","updated":"2024-11-11 15:55:35.000000000","message":"i guess the functional change is \n\nif type(req.state) \u003d\u003d list: -\u003e  if isinstance(req.state, list):\n\nwhich is not really functional but we can do this minor release if the release team wants to proceed with it.\n\nnormally i would not think this warrents a feature bump but it is technially the first release of the cycle and its technically bumping the min requriement for a test-dep but there is no runtime dep increase which is why this could normally be considerd a bugfix release.\n\ngiven its the first release for 2025.1 bumping the feature version to allow possible backport to 2024.2 is correct","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"732a27ff3218f763778cb64824bf6c98d8e5026d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0860d188_dfc59280","updated":"2024-11-11 12:23:17.000000000","message":"ill check with folks today, before approving but one open question i had about watchers release model is its technically release with RC and i was not sure if it prevents us form doing this release at m1 because its not release with intermediary.\n\ni would prefer to move to that model instead of release with RC, how do folk feel about that form the release perspective","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3a61ed3680741ce0bc666363014881ee65b32921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6880c524_7c2eefc9","in_reply_to":"0860d188_dfc59280","updated":"2024-11-11 15:41:39.000000000","message":"python-\\*clients has release model cycle-with-intermediary. note that it\u0027s not mandatory to release every milestone (in fact, recently there are many cycle-with-intermediary deliverables that release only at Milestone-3). In release team we agreed some cycles ago that python-\\*cleints should stay with cycle-with-intermediary model, as they are usually quite dependent on their service projects.\n\nThis patch is only generated because there seem to be merged and unreleased changes that contains functional code change (test code / CI related changes excluded. The \u0027functional code change\u0027 can be very minimal though). It is possible to wait for Milestone-2 or Milestone-3 with the release, but if there are code changes, then it\u0027s worth to release and let things use/test with the latest changes.","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18013a615976e47c172028497fa1326ebfe1786c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"679b5cc3_0d66be37","in_reply_to":"2b8b01b7_be440b61","updated":"2024-11-11 16:11:52.000000000","message":"i added a +1 to prevent any possible coinstallablity issues that might arrise by watcher clamping to such an old verion fo hacking.\n\ndevstack no longer installs the test-requirements so it\u0027s unlikely to manifest but better safe the sorry.","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6390059d4712fc7565324a5e5124f42cf7c21bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49a7ea4b_19527152","in_reply_to":"679b5cc3_0d66be37","updated":"2024-11-11 18:51:40.000000000","message":"ACK, agreed, thanks Sean! :)","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b7bdd8ddd8a0599dea8abe4388327c39ea933ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd9bcf71_1523f921","in_reply_to":"6880c524_7c2eefc9","updated":"2024-11-11 15:51:39.000000000","message":"oh the client is using a different model than the rest of watcher.\n\nok  i think the only change is https://github.com/openstack/python-watcherclient/commit/cd492822977160d54095f38d84e244021ad27d98\n\nthe previous release was the direct parent\n56e47c38e209010bbd9f3250ee959efaa47e61dd\n\nhttps://github.com/openstack/releases/blob/master/deliverables/dalmatian/python-watcherclient.yaml#L13C15-L13C55\n\ni dont think bumping th emin hackign version is really a funcitonla change so we could wait to m2 or later but i do not object to makign this release if it helps with ci","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9a7cf9e9a2716add96e1c36ace4d30003ac71da7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f105d248_3da8152c","in_reply_to":"907a54c0_ff1b3fcb","updated":"2024-11-11 18:52:41.000000000","message":"yepp, 1st release on a series has to be at least a MINOR bump.","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9841dc5223cddb94041849a0e2deaaf79693d5d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b8b01b7_be440b61","in_reply_to":"cd9bcf71_1523f921","updated":"2024-11-11 16:00:56.000000000","message":"yepp, it is an example of \u0027very minimal\u0027 functional code change o:) the aim is to catch every small issue during the cycle, especially at deliverables that has very low number of changes. Milestone-3 is the time when it is mandatory to release the latest state though (even if that release only contains test-only or CI releated changes).\n\nNevertheless, it depends on the team if this release is needed or not. If there won\u0027t be a +1 then the patch can be abandoned until Milestone-2/Milestone-3.","commit_id":"dd6eb5ed7ce8d93795ad5f3af543e06b93d69b22"}]}
