)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1e8f7c4aa06296224bd9f07e0959b101713ad71c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-15 18:19:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"oslo.context 5.7.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Mostly pyupgrade changes plus a little fix to stop warning spam in logs."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c63ebf5b_9aca0af8","line":7,"updated":"2024-11-18 15:39:43.000000000","message":"I think it would be better to update the commit subject to: \"Release oslo.context for Epoxy-1 milestone.\" This makes it clearer that the release is part of the Epoxy-1 milestone and adds more context.","commit_id":"6e76723244aacdcfd910734d0d970002154fcd92"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1e8f7c4aa06296224bd9f07e0959b101713ad71c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"oslo.context 5.7.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Mostly pyupgrade changes plus a little fix to stop warning spam in logs."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0dc754f6daae72897d7c7910ed96668314d14b2b"},{"line_number":12,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c0cd32a0_5e35a905","line":9,"updated":"2024-11-18 15:39:43.000000000","message":"I think it would be helpful to complement the description with the following:\n\n\"This is a library release for oslo.context for the Epoxy-1 milestone.  \nThis repository contains commits that have not yet been released in this cycle.  \n\nIf the team is ready to proceed with this release, please leave a +1 to indicate we should move forward.  \n\nIf the team needs more time for pending merges, or if there is another reason why the release should be delayed, please leave a -1 with a comment indicating the status. Then update the patch with the new commit hash once the team is ready to proceed with the release.\"\n\nThis addition makes it clearer that the release is part of the Epoxy-1 milestone and provides more context for the process.","commit_id":"6e76723244aacdcfd910734d0d970002154fcd92"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"d963ee65b83d2573e2e4fd41e898b79e3182313f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34428397_35a75eae","updated":"2024-11-18 15:34:58.000000000","message":"Thanks a lot for the patch. It looks good to merge, and the SHA corresponds to the latest commit in the repository see[1] for details.  \n\nHowever, since this will be the first release of Epoxy, it might be a good idea to slightly revise the commit message to better highlight the significance of this milestone.\n  \n[1]: https://github.com/openstack/oslo.context/commit/5c3910e369f8f675454242d16a03ec07a754b663","commit_id":"6e76723244aacdcfd910734d0d970002154fcd92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d772660622912d24c0d036bff045b9e1f62acfc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee64ebe3_c7d2574d","updated":"2024-11-18 20:17:21.000000000","message":"the usual procedure would be to update https://review.opendev.org/c/openstack/releases/+/934610 with the new SHA instead of proposing a conflicting patch, just saying","commit_id":"6e76723244aacdcfd910734d0d970002154fcd92"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"04b5820aaa2bb96b682616e98381d4bdad2dd3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07393a74_8d2f6d26","in_reply_to":"ee64ebe3_c7d2574d","updated":"2024-11-19 10:01:04.000000000","message":"Thank a lot for pointing this out! I was thinking the same, and I agree it’s better to update the SHA on Elod’s patch.","commit_id":"6e76723244aacdcfd910734d0d970002154fcd92"}]}
