)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d78e15a65b70ca3e4160f2f1bc2762ca57d32739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8adc4629_c04adca4","updated":"2024-11-25 06:41:29.000000000","message":"the code change itself lgtm, just worried a bit about the testing, but I won\u0027t hold up this change because of that","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8463dd96370b2c6c45e8aac83b239f4c3ba03773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11970b35_6e119b55","updated":"2024-11-25 09:46:20.000000000","message":"ok, thanks for the update, I guess this is fine for now. will rebase my eol stack on top\n\noverriding ptl-approval for code-only change","commit_id":"efebb17b8ad01cecf7acae71c0b9817c51db7237"}],"openstack_releases/tests/test_validate.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d78e15a65b70ca3e4160f2f1bc2762ca57d32739","unresolved":true,"context_lines":[{"line_number":876,"context_line":"        self.assertEqual(0, len(self.ctx.errors))"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    @mock.patch(\u0027openstack_releases.gitutils.get_full_branch_name\u0027)"},{"line_number":879,"context_line":"    def test_not_descendent(self, get_stable_branch_id):"},{"line_number":880,"context_line":"        get_stable_branch_id.configure_mock("},{"line_number":881,"context_line":"            return_value\u003d\u0027meiji\u0027,"},{"line_number":882,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ccb65f9_b144b14b","line":879,"range":{"start_line":879,"start_character":34,"end_line":879,"end_character":54},"updated":"2024-11-25 06:41:29.000000000","message":"also change the name within the function? the current mix seems confusing","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"bc37ccc94f651d9a3f0a99ebf18a6a52dd6096e5","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        self.assertEqual(0, len(self.ctx.errors))"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    @mock.patch(\u0027openstack_releases.gitutils.get_full_branch_name\u0027)"},{"line_number":879,"context_line":"    def test_not_descendent(self, get_stable_branch_id):"},{"line_number":880,"context_line":"        get_stable_branch_id.configure_mock("},{"line_number":881,"context_line":"            return_value\u003d\u0027meiji\u0027,"},{"line_number":882,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"944bf42d_53495cc3","line":879,"range":{"start_line":879,"start_character":34,"end_line":879,"end_character":54},"in_reply_to":"3ccb65f9_b144b14b","updated":"2024-11-25 09:37:08.000000000","message":"ah, good catch, thanks, updated to make things better readable.","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d78e15a65b70ca3e4160f2f1bc2762ca57d32739","unresolved":true,"context_lines":[{"line_number":878,"context_line":"    @mock.patch(\u0027openstack_releases.gitutils.get_full_branch_name\u0027)"},{"line_number":879,"context_line":"    def test_not_descendent(self, get_stable_branch_id):"},{"line_number":880,"context_line":"        get_stable_branch_id.configure_mock("},{"line_number":881,"context_line":"            return_value\u003d\u0027meiji\u0027,"},{"line_number":882,"context_line":"        )"},{"line_number":883,"context_line":"        deliv \u003d deliverable.Deliverable("},{"line_number":884,"context_line":"            team\u003d\u0027team\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0796f7b0_099afec1","line":881,"updated":"2024-11-25 06:41:29.000000000","message":"the return value of the new function should be either \"stable/meiji\" or \"unmaintained/meiji\". that there is no test failure due to this seems to indicate that the testing is pretty incomplete, not sure if we want to extend coverage here?\n\nalso maybe have a test for get_full_branch_name() itself?","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"bc37ccc94f651d9a3f0a99ebf18a6a52dd6096e5","unresolved":true,"context_lines":[{"line_number":878,"context_line":"    @mock.patch(\u0027openstack_releases.gitutils.get_full_branch_name\u0027)"},{"line_number":879,"context_line":"    def test_not_descendent(self, get_stable_branch_id):"},{"line_number":880,"context_line":"        get_stable_branch_id.configure_mock("},{"line_number":881,"context_line":"            return_value\u003d\u0027meiji\u0027,"},{"line_number":882,"context_line":"        )"},{"line_number":883,"context_line":"        deliv \u003d deliverable.Deliverable("},{"line_number":884,"context_line":"            team\u003d\u0027team\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1495a71_ab7dc22e","line":881,"in_reply_to":"0796f7b0_099afec1","updated":"2024-11-25 09:37:08.000000000","message":"to 1st comment: done. since meiji is a made-up name, so it did not exist before and neither exists now I think we are covered just like before.\n\nto 2nd question: to tell you the truth i tried to write some meaningful test for this change, but realized that nothing i was trying is useful and i haven\u0027t found any test for check_branch_sha function either (which somewhat makes sense, as with that we\u0027d have to fake a git repo). so i decided to stick to testing it with the eom-\u003eeol patches, which seemed to be working locally.","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8463dd96370b2c6c45e8aac83b239f4c3ba03773","unresolved":false,"context_lines":[{"line_number":878,"context_line":"    @mock.patch(\u0027openstack_releases.gitutils.get_full_branch_name\u0027)"},{"line_number":879,"context_line":"    def test_not_descendent(self, get_stable_branch_id):"},{"line_number":880,"context_line":"        get_stable_branch_id.configure_mock("},{"line_number":881,"context_line":"            return_value\u003d\u0027meiji\u0027,"},{"line_number":882,"context_line":"        )"},{"line_number":883,"context_line":"        deliv \u003d deliverable.Deliverable("},{"line_number":884,"context_line":"            team\u003d\u0027team\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8aa4ea41_f4d043c6","line":881,"in_reply_to":"b1495a71_ab7dc22e","updated":"2024-11-25 09:46:20.000000000","message":"Acknowledged","commit_id":"3bec277edba74fa302e142886d665a4611995aa3"}]}