)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"76c9015042e93c26ec5145a3241694b6e0e63b8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe782615_c09c33c4","updated":"2024-12-10 17:48:44.000000000","message":"-1 because of the list_eol_stale_branches.sh change. we will need that as is for deleting stable/2023.2 (bobcat) branches in 2025 May (as Bobcat will directly go to EOL without moving to Unmaintained)","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a2d1a65f6b8aba3eccc1462138e64311a2266f22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62301800_e8b25dff","updated":"2024-12-11 13:15:54.000000000","message":"I\u0027ve tested this and this did not work for me :/ see the comments inline.","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"06f8f2b7ad32b96a54636f002301a3bf3bf8aa00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b83acff_0176e979","updated":"2024-12-05 12:14:21.000000000","message":"Looks good to me, see small nit","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9ff0f591d47ff647462338fac1b13eca5b075828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e07b17e_44c26969","in_reply_to":"e034360d_a45465e5","updated":"2024-12-10 19:35:25.000000000","message":"ah, sorry, i somehow lost myself in the details of the first no_unmaintained_open_patches function and saw there that stable was replaced to unmaintained /o\\\n\ni\u0027m dropping the -1 now and will revisit the patch tomorrow o:) thanks for working on this o/","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2ee18f832ed0cf8740f6a4faf6df861b39c0c03a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e034360d_a45465e5","in_reply_to":"fe782615_c09c33c4","updated":"2024-12-10 17:57:08.000000000","message":"what issue do you see there? the change is written so that that script can eol both stable and unmaintained branches","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9b6136540e0c6a396347aab11eeef85a80cf185d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ed298f7d_26a71765","updated":"2024-12-13 14:16:51.000000000","message":"yepp, looks good, let\u0027s merge for now so that we can proceed.","commit_id":"54c6dd50da27b303589efca893dbb0a6ec88ccf3"}],"tools/delete_unmaintained_branch.py":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"06f8f2b7ad32b96a54636f002301a3bf3bf8aa00","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2021 Ericsson Software Technology"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"a08ad80b_4f797d6f","line":2,"updated":"2024-12-05 12:14:21.000000000","message":"This looks weird, unless you recently changed jobs :)","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"501ba34502b12807d80ef456818c22b0293bc951","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2021 Ericsson Software Technology"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca913589_133c0ba7","line":2,"in_reply_to":"438633c3_9a8f694f","updated":"2024-12-06 08:08:04.000000000","message":"If it is a substantial copy, then I remove my objection!","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0dfb05e2e9e6b813ab3020c54c24797a7d4cb0eb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2021 Ericsson Software Technology"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"438633c3_9a8f694f","line":2,"in_reply_to":"a08ad80b_4f797d6f","updated":"2024-12-05 21:15:38.000000000","message":"Well the whole file is copied from tools/delete_stable_branch.py with just minor modifications, so I think that this isn\u0027t completely wrong?\n\na better solution would of course be to parametrize the original file accordingly\n\nbut for the current quick-and-dirty solution, I would prefer to keep this","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e91b706f2f03fe6c11a33514c6ac7cc8837a403a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2021 Ericsson Software Technology"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d6a49c4_30a010b9","line":2,"in_reply_to":"ca913589_133c0ba7","updated":"2024-12-06 08:56:02.000000000","message":"Acknowledged","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"}],"tools/functions":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c979ffa6013d2eb2ce82fa6659f785b33cd75852","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    typeset series\u003d\"$1\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    typeset default\u003d$(python -c \u0027from openstack_releases import defaults; print(defaults.RELEASE)\u0027)"},{"line_number":126,"context_line":"    typeset branch_name\u003d$(python -c \"from openstack_releases import gitutils; print(gitutils.get_stable_branch_id(\\\"$series\\\"))\")"},{"line_number":127,"context_line":"    if [ \"$series\" \u003d \"$default\" ]; then"},{"line_number":128,"context_line":"        echo \"master\""},{"line_number":129,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f1dec916_3a945a62","line":126,"updated":"2024-12-11 13:42:14.000000000","message":"So I just copied this part, which is all that is really needed","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a2d1a65f6b8aba3eccc1462138e64311a2266f22","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    if [ \"$series\" \u003d \"$default\" ]; then"},{"line_number":128,"context_line":"        echo \"master\""},{"line_number":129,"context_line":"    else"},{"line_number":130,"context_line":"        echo \"stable/$branch_name\""},{"line_number":131,"context_line":"    fi"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4612f116_d7757ca8","line":130,"updated":"2024-12-11 13:15:54.000000000","message":"here ^^^","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c979ffa6013d2eb2ce82fa6659f785b33cd75852","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    if [ \"$series\" \u003d \"$default\" ]; then"},{"line_number":128,"context_line":"        echo \"master\""},{"line_number":129,"context_line":"    else"},{"line_number":130,"context_line":"        echo \"stable/$branch_name\""},{"line_number":131,"context_line":"    fi"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d1ca532b_1ac65470","line":130,"in_reply_to":"4612f116_d7757ca8","updated":"2024-12-11 13:42:14.000000000","message":"ack, thx for the pointer","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"}],"tools/list_eol_stale_branches.sh":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a2d1a65f6b8aba3eccc1462138e64311a2266f22","unresolved":true,"context_lines":[{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"for eom_series in \"${eom_series[@]}\"; do"},{"line_number":179,"context_line":"    eom_branch\u003d$(series_to_branch \"$eom_series\")"},{"line_number":180,"context_line":"    repos\u003d$(list-deliverables -r --series \"$eom_series\" --is-eol)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Show the eol stale branches for each repository."}],"source_content_type":"text/x-sh","patch_set":3,"id":"6bc209f8_793744ab","line":179,"updated":"2024-12-11 13:15:54.000000000","message":"series_to_branch (see tools/functions) gives back \"stable/series\" instead of just \"series\", and below is_stable_eol and is_unmaintained_eol expects just \"series\".\n\nso i think here we have to cut the \"stable/\" part out of the result. (e.g. similarly like in the other script:\n    # Get branch id from full branch name (stable/2023.1 -\u003e 2023.1)\n    branch_id\u003d${branch#*/}\n)","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c979ffa6013d2eb2ce82fa6659f785b33cd75852","unresolved":false,"context_lines":[{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"for eom_series in \"${eom_series[@]}\"; do"},{"line_number":179,"context_line":"    eom_branch\u003d$(series_to_branch \"$eom_series\")"},{"line_number":180,"context_line":"    repos\u003d$(list-deliverables -r --series \"$eom_series\" --is-eol)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Show the eol stale branches for each repository."}],"source_content_type":"text/x-sh","patch_set":3,"id":"d3e3aeb8_715a7512","line":179,"in_reply_to":"6bc209f8_793744ab","updated":"2024-12-11 13:42:14.000000000","message":"I just copied the code from the helper function now","commit_id":"3a8fab0c9a9d0ad955cb3d7c16ad1c7af9c4a09b"}]}