)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fa84b91a6f4cd2c81a18a1450f847b5b40b411f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06a333b1_fbb92b68","updated":"2025-03-01 04:54:41.000000000","message":"overriding PTL-approval for code-change\n\ncomment inline, but I\u0027d also be fine with keeping the stricter check","commit_id":"1241d8a6fcf0cbad39a04e29e9a1de98dea00d85"}],"openstack_releases/requirements.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fa84b91a6f4cd2c81a18a1450f847b5b40b411f","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                # There was a minimum but it has been removed."},{"line_number":72,"context_line":"                continue"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            if old_min !\u003d new_min:"},{"line_number":75,"context_line":"                # The old minimum is not in the new spec."},{"line_number":76,"context_line":"                report((\u0027Changed supported versions for dependency {} from {} \u0027"},{"line_number":77,"context_line":"                        \u0027to {} without at least incrementing minor number\u0027).format("}],"source_content_type":"text/x-python","patch_set":2,"id":"90fef82a_27bf1c5c","line":74,"updated":"2025-03-01 04:54:41.000000000","message":"iiuc the existing condition was there to allow for an extension of the allowed range without a report, like moving from `\u003e2.2.0` to `\u003e2.1.0` would have been allowed without requiring a minor version bump.\n\nI\u0027m not sure how often such a case would happen, but if we\u0027d want to still keep the existing behaviour, the solution would be to combine both conditions?\n\n```suggestion\n            if old_min !\u003d new_min and old_min.version not in req.specifier:\n```","commit_id":"1241d8a6fcf0cbad39a04e29e9a1de98dea00d85"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"524bd157fcd618bb438ecbd24b8fb3df9c7d40c9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                # There was a minimum but it has been removed."},{"line_number":72,"context_line":"                continue"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            if old_min !\u003d new_min:"},{"line_number":75,"context_line":"                # The old minimum is not in the new spec."},{"line_number":76,"context_line":"                report((\u0027Changed supported versions for dependency {} from {} \u0027"},{"line_number":77,"context_line":"                        \u0027to {} without at least incrementing minor number\u0027).format("}],"source_content_type":"text/x-python","patch_set":2,"id":"c1c99401_7db741b5","line":74,"in_reply_to":"90fef82a_27bf1c5c","updated":"2025-03-04 14:04:46.000000000","message":"thanks Jens, you are right. i\u0027ve extended the tests and code with this ^^^. Done.","commit_id":"1241d8a6fcf0cbad39a04e29e9a1de98dea00d85"}]}