)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6073954f1b60364274b514e3add18743a0ff86cd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove use of pkg_resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"She\u0027s dead, Jim (or near as damn it)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8201f2a2939c2cdbfa989de0217c0561465df05b"},{"line_number":12,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"003688b9_5781ebc7","line":9,"updated":"2025-11-10 06:35:27.000000000","message":"the patch itself seems fine, but I cannot agree with this use of language. a comment describing the need for this change that explains it for those not closely tracking the developments in the python eco system would be more appropriate","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1713ba74501cd89b12277c8df01063b52d920068","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove use of pkg_resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"She\u0027s dead, Jim (or near as damn it)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8201f2a2939c2cdbfa989de0217c0561465df05b"},{"line_number":12,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"920ae47f_f5705954","line":9,"in_reply_to":"003688b9_5781ebc7","updated":"2025-11-11 10:58:38.000000000","message":"You may well know this already, but \"He\u0027s/She\u0027s/It\u0027s dead, Jim\" [is a very well-known catchphrase from Star Trek: The Original Series](https://memory-alpha.fandom.com/wiki/He%27s_dead,_Jim), while \"near as damn it\" is colloquial [UK/IE English](https://www.merriam-webster.com/dictionary/as%20near%20as%20damn%20it). I will remove this, but I don\u0027t believe this to be in any way offensive, nor do I believe it\u0027s a bad thing to let personality show through in commit messages, and I\u0027m disappointed to have been asked to strip some of that out.","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"7dbdbb88ee8f218a5b64e737668e7f769e9d5fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9bd9f3d3_43d1ddab","updated":"2025-11-06 09:54:33.000000000","message":"Fine by me","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"236cc1c49c84bf14e76b188b1bc77f26b276a11f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3155b84e_f3007bc7","updated":"2025-10-31 17:56:23.000000000","message":"validate job needs to be tested as i think it is not covered in unit tests. otherwise this looks nice! thanks Stephen!","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e99069f14c61c99eecbbab35de301356ad23d459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf518bf3_8d5e964a","in_reply_to":"3155b84e_f3007bc7","updated":"2025-11-04 10:37:50.000000000","message":"The method is called by `validate_version_numbers` (-\u003e `find_bad_lower_bound_increases` -\u003e `get_requirements_at_ref` -\u003e `parse_requirements`). The `validate_version_numbers` function already has extensive tests in `openstack_releases/tests/test_validate.py`, including the below, so I think we\u0027re good.\n\n- `openstack_releases.tests.test_requirements.TestCompareLowerBounds.test_raised_lower`\n- `openstack_releases.tests.test_requirements.TestCompareLowerBounds.test_lower_comparator_with_lower_new_minimum_version`","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"b97da723230e569840c5c6986eff25da9e19eb04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be90d8a7_f69d51d1","in_reply_to":"cf518bf3_8d5e964a","updated":"2025-11-11 11:51:05.000000000","message":"thanks for the explanation Stephen, i agree, this should be good to go.","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"}],"openstack_releases/requirements.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"236cc1c49c84bf14e76b188b1bc77f26b276a11f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def find_bad_lower_bound_increases(workdir, repo,"},{"line_number":31,"context_line":"                                   start_version, new_version, hash,"},{"line_number":32,"context_line":"                                   report):"},{"line_number":33,"context_line":"    if (new_version.split(\u0027.\u0027)[-1] \u003d\u003d \u00270\u0027 or"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bd0c68d_a3bf8a1a","line":30,"updated":"2025-10-31 17:56:23.000000000","message":"this is the function that we are using in validator tox target / job. this needs to be tested, otherwise looks promising!","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"236cc1c49c84bf14e76b188b1bc77f26b276a11f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            continue"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            parsed_req \u003d pkg_requirements.Requirement(line)"},{"line_number":157,"context_line":"        except ValueError:"},{"line_number":158,"context_line":"            LOG.warning(\u0027failed to parse %r\u0027, line)"},{"line_number":159,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfe99006_99f9befc","line":156,"range":{"start_line":156,"start_character":42,"end_line":156,"end_character":53},"updated":"2025-10-31 17:56:23.000000000","message":"the two requirement object (parsed_req) are not the same, i mean, packaging.requirements.Requirement has less properties and methods, but it looks that the relevant ones (what we are relying on in this module) matches.","commit_id":"8b2aa34638caeb18597a1b434a38edd41b697c0c"}]}