)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e2601c181319a29b82e5458a27ecf38d051cb31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9132a77_a862bd6c","updated":"2026-04-20 07:47:48.000000000","message":"reno suggests MAJOR version bump due to upgrade notes [1], and at least the 2nd out of them looks valid. opinion? (giving -1 to highlight my question)\n\n[1]\n\n    Upgrade Notes\n    *************\n    \n    * Now all service plugins, inheriting from \"ServicePluginBase\"\n      class, will have the extension \"filter-validation\" enabled by\n      default. That enforces the API filter validation in the queries,\n      returning a \"HTTPBadRequest\" in case of using an invalid attribute.\n      This extension can be enabled or disabled using the Neutron\n      configuration variable \"[DEFAULT]filter_validation\".\n    \n    * Added new \"vpn-no-sha1-3des\" API extension that removes the\n      deprecated sha1 authentication algorithm and 3des encryption\n      algorithm from the VPN API. When this extension is loaded, the\n      default \"auth_algorithm\" for IKE and IPsec policies changes from\n      \"sha1\" to \"sha256\".","commit_id":"59b050aa9855573b37c1d7d47b19907f1ca337b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f067c02e3d5007a68809091bd585bf7f8c82114f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e8e70de_a575cd4c","in_reply_to":"3a45db09_c7f33595","updated":"2026-04-20 10:48:54.000000000","message":"In the past we were introducing new API extensions and bumping only minor version for that so for the \"vpn-no-sha1-3des\" API extension change IMO it is totally fine to just bump minor version now too.\nRegarding service plugin inheritance, as Rodolfo said - it is bugfix so I guess it is also ok to just do MINOR version bump for that.\nWith both of that, IMO it will be fine to keep version 4.0 to drop tenant_id completely.","commit_id":"59b050aa9855573b37c1d7d47b19907f1ca337b3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"29649922947be5d217614fe270a72df5838f5c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a45db09_c7f33595","in_reply_to":"41302272_8fee490b","updated":"2026-04-20 10:12:20.000000000","message":"good arguments, but I agree to bump to 4.0.0 when tenant_id will be fully replaced by project_id","commit_id":"59b050aa9855573b37c1d7d47b19907f1ca337b3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"41d082147ac1e167d3c27357bed55db61313531d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6dfdbec8_23977e58","in_reply_to":"8e8e70de_a575cd4c","updated":"2026-04-20 11:59:00.000000000","message":"ACK, thanks for all the responses. Let\u0027s release this then.","commit_id":"59b050aa9855573b37c1d7d47b19907f1ca337b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2d510d34ebe4f563ccf57511b83219e3d6a956f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41302272_8fee490b","in_reply_to":"c9132a77_a862bd6c","updated":"2026-04-20 08:37:01.000000000","message":"Yeah, I agree that these 2 release notes could sound \"big\" enough for a major version, but:\n* The `ServicePluginBase` inheritance was a bug/refactor. All service plugins should have had this base class by default. The \"filter-validation\" extension was missing in some of them and thus the API wasn\u0027t working properly --\u003e when passing wrong filters, the API was NOT returning a `HTTPBadRequest` exception, now it is.\n* The \"sha1\" default value was just this, the default value. But most probably (I hope so) was using it anymore. When an IKE or IPsec policy is created, the user can define the `auth_algorithm` via CLI command parameter.\n\nWe would like to \"reserve\" the 4.0.0 release for the \"tenant_id\" complete removal from the n-lib code.\n\nIn any case, I\u0027ll ping Neutron cores to review this comment.\n\nThanks!","commit_id":"59b050aa9855573b37c1d7d47b19907f1ca337b3"}]}
