)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c70ce1f8d43a577ce0aa97c8e1e1dad8e8d6d776","unresolved":false,"context_lines":[{"line_number":11,"context_line":"same date."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I95278eab25f331262a4c9eeac2260ca7290b5421"},{"line_number":14,"context_line":"Fixes-Bug: #254367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_627c851f","line":14,"updated":"2015-12-07 20:29:56.000000000","message":"err actually this should be:\n\nCloses-Bug: #1522153\n\nI\u0027m not sure where that bug number came from","commit_id":"d4e3b575512e5739458fee04906f782fdbca3c19"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ad2ea4ba7544095474fd41c64ab3b3b2a8efa01b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Hellmann \u003cdoug@doughellmann.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 20:31:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix git log sorting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use topological sort instead of date sort so that release notes appear"},{"line_number":10,"context_line":"in the release where they are merged, rather than the one closest to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_1d02c60b","line":7,"updated":"2015-12-07 21:15:06.000000000","message":"this should say that it fixes release notes occurring in the wrong release","commit_id":"93376c5aaaf982c9666fee6b7550bdefc94a5ff3"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e085306f45763840bd7b6b35648c5107b8134a02","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Hellmann \u003cdoug@doughellmann.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 20:31:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix git log sorting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use topological sort instead of date sort so that release notes appear"},{"line_number":10,"context_line":"in the release where they are merged, rather than the one closest to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_11bceada","line":7,"in_reply_to":"7a740942_1d02c60b","updated":"2015-12-08 00:03:31.000000000","message":"Done","commit_id":"93376c5aaaf982c9666fee6b7550bdefc94a5ff3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ad2ea4ba7544095474fd41c64ab3b3b2a8efa01b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use topological sort instead of date sort so that release notes appear"},{"line_number":10,"context_line":"in the release where they are merged, rather than the one closest to the"},{"line_number":11,"context_line":"same date."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I95278eab25f331262a4c9eeac2260ca7290b5421"},{"line_number":14,"context_line":"Closes-Bug: #1522153"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_9d3eb6d8","line":11,"updated":"2015-12-07 21:15:06.000000000","message":"this should say the commit date","commit_id":"93376c5aaaf982c9666fee6b7550bdefc94a5ff3"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e085306f45763840bd7b6b35648c5107b8134a02","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use topological sort instead of date sort so that release notes appear"},{"line_number":10,"context_line":"in the release where they are merged, rather than the one closest to the"},{"line_number":11,"context_line":"same date."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I95278eab25f331262a4c9eeac2260ca7290b5421"},{"line_number":14,"context_line":"Closes-Bug: #1522153"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_51c6f268","line":11,"in_reply_to":"7a740942_38cd5066","updated":"2015-12-08 00:03:31.000000000","message":"Done","commit_id":"93376c5aaaf982c9666fee6b7550bdefc94a5ff3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e2075e0ad44a9921ca1c25d919827fcd5bccb3b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use topological sort instead of date sort so that release notes appear"},{"line_number":10,"context_line":"in the release where they are merged, rather than the one closest to the"},{"line_number":11,"context_line":"same date."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I95278eab25f331262a4c9eeac2260ca7290b5421"},{"line_number":14,"context_line":"Closes-Bug: #1522153"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_38cd5066","line":11,"in_reply_to":"7a740942_9d3eb6d8","updated":"2015-12-07 21:15:24.000000000","message":"actually, should say commit time","commit_id":"93376c5aaaf982c9666fee6b7550bdefc94a5ff3"}],"reno/scanner.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1264bfd64fbb37d485b6b80cd2b31c2956a33d0a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return uniqueid"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"TAG_RE \u003d re.compile(\u0027tag: ([^),]+)\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_tags_on_branch(reporoot, branch):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_ffd452ec","line":82,"updated":"2015-12-08 19:37:15.000000000","message":"When I do the git log cmd in python-keystoneclient I get a few odd rows:\n\n (tag: 0.1.3)\n (0.1.2)\n (tag: 0.1.1)\n (0.1.0)\n (tag: folsom-1)\n\nSo looks like some releases don\u0027t get \"tag:\" and some tags are not release numbers.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a47952a7f23bb1820ff2eaae599747a8408ea346","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return uniqueid"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"TAG_RE \u003d re.compile(\u0027tag: ([^),]+)\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_tags_on_branch(reporoot, branch):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_4029fe88","line":82,"in_reply_to":"7a740942_7dc70764","updated":"2015-12-08 21:27:43.000000000","message":"Here\u0027s the git log --simplify-by-decoration --pretty\u003d\"%d\" for keystoneclient and nova using git version 1.7.1: http://paste.openstack.org/show/481239/","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3a3ff4ceaed5a28a08c6953f4786868c47535138","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return uniqueid"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"TAG_RE \u003d re.compile(\u0027tag: ([^),]+)\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_tags_on_branch(reporoot, branch):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_d0170343","line":82,"in_reply_to":"7a740942_9a8e7c2c","updated":"2015-12-08 20:16:58.000000000","message":"Maybe it\u0027s the ancient version of git on RHEL6 (1.7.1). I tried on ubuntu and they all have tag:.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9d7df8c34fd5930d95066eeb45bb16078535b598","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return uniqueid"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"TAG_RE \u003d re.compile(\u0027tag: ([^),]+)\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_tags_on_branch(reporoot, branch):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_7dc70764","line":82,"in_reply_to":"7a740942_d0170343","updated":"2015-12-08 21:15:49.000000000","message":"That could be it. Our build jobs all run on Ubuntu, so we\u0027re safe upstream. I\u0027m not sure what to say about RHEL6 support. I could prep another patch to expand the regex to handle that case. Can you give me a pastebin with the output for the python-keystoneclient and nova repositories? (I have no RHEL systems to test with.)","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5b90c2620a2d25f66707c6b138fc1a80f2df8502","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return uniqueid"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"TAG_RE \u003d re.compile(\u0027tag: ([^),]+)\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_tags_on_branch(reporoot, branch):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_9a8e7c2c","line":82,"in_reply_to":"7a740942_ffd452ec","updated":"2015-12-08 19:50:23.000000000","message":"I get the output I expect, see http://paste.openstack.org/show/481225/\n\nCan you post the command you\u0027re running?","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1264bfd64fbb37d485b6b80cd2b31c2956a33d0a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if branch:"},{"line_number":103,"context_line":"        tag_cmd.append(branch)"},{"line_number":104,"context_line":"    LOG.debug(\u0027running %s\u0027 % \u0027 \u0027.join(tag_cmd))"},{"line_number":105,"context_line":"    tag_results \u003d utils.check_output(tag_cmd, cwd\u003dreporoot)"},{"line_number":106,"context_line":"    LOG.debug(tag_results)"},{"line_number":107,"context_line":"    for line in tag_results.splitlines():"},{"line_number":108,"context_line":"        LOG.debug(\u0027line %r\u0027 % line)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_dfc2b652","line":105,"updated":"2015-12-08 19:37:15.000000000","message":"(suggestion) you could use --git-dir if you wanted to avoid the cwd.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1264bfd64fbb37d485b6b80cd2b31c2956a33d0a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # version."},{"line_number":136,"context_line":"    current_version \u003d _get_current_version(reporoot, branch)"},{"line_number":137,"context_line":"    LOG.debug(\u0027current repository version: %s\u0027 % current_version)"},{"line_number":138,"context_line":"    if current_version not in versions_by_date:"},{"line_number":139,"context_line":"        LOG.debug(\u0027adding %s to versions by date\u0027 % current_version)"},{"line_number":140,"context_line":"        versions_by_date.insert(0, current_version)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_ff8c52db","line":138,"updated":"2015-12-08 19:37:15.000000000","message":"why wouldn\u0027t current_version be in versions_by_date? this could use a comment.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5b90c2620a2d25f66707c6b138fc1a80f2df8502","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # version."},{"line_number":136,"context_line":"    current_version \u003d _get_current_version(reporoot, branch)"},{"line_number":137,"context_line":"    LOG.debug(\u0027current repository version: %s\u0027 % current_version)"},{"line_number":138,"context_line":"    if current_version not in versions_by_date:"},{"line_number":139,"context_line":"        LOG.debug(\u0027adding %s to versions by date\u0027 % current_version)"},{"line_number":140,"context_line":"        versions_by_date.insert(0, current_version)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_7a92b04d","line":138,"in_reply_to":"7a740942_ff8c52db","updated":"2015-12-08 19:50:23.000000000","message":"The current version from git-describe may not reflect a tag if there are unreleased commits at the head of the branch. I\u0027ll add a comment.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"}],"reno/tests/test_scanner.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1264bfd64fbb37d485b6b80cd2b31c2956a33d0a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            [\u00272.0.0\u0027, \u00271.1.0\u0027, \u00271.0.0\u0027],"},{"line_number":596,"context_line":"            list(raw_results.keys()),"},{"line_number":597,"context_line":"        )"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"class UniqueIdTest(Base):"},{"line_number":601,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_1a404c33","line":598,"updated":"2015-12-08 19:37:15.000000000","message":"This change also added sorting of \"files_and_tags\", so shouldn\u0027t this be tested, too?","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2cdfaa8a85744c6b9797c8af8da88f040ce81003","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            [\u00272.0.0\u0027, \u00271.1.0\u0027, \u00271.0.0\u0027],"},{"line_number":596,"context_line":"            list(raw_results.keys()),"},{"line_number":597,"context_line":"        )"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"class UniqueIdTest(Base):"},{"line_number":601,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_5ab81475","line":598,"in_reply_to":"7a740942_1a404c33","updated":"2015-12-08 19:51:58.000000000","message":"Some of the existing tests were failing until I added the sort call.","commit_id":"7becd75a6787de42af58d95a24bb5322bf0683a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"48666d1d670a50436dacabc590b9ef25a8546cff","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        \"\"\")"},{"line_number":778,"context_line":"        with mock.patch(\u0027reno.utils.check_output\u0027) as co:"},{"line_number":779,"context_line":"            co.return_value \u003d tag_list_output"},{"line_number":780,"context_line":"            actual \u003d scanner._get_version_tags_on_branch(\u0027reporoot\u0027, None)"},{"line_number":781,"context_line":"        self.assertEqual(self.EXPECTED, actual)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def test_keystoneclient_rhel_1_7_1(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_7ce35b34","line":780,"updated":"2015-12-09 15:38:54.000000000","message":"the code would be more understandable if a name was given to the None variable (or, if it\u0027s optional then leave it off). This applies to the call in the next test, too.","commit_id":"3f6a625083b2569664d700f0023b4ef6acf9c9b6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d282d9bdc9dcfed9a1817bb4dc78032b2fc5e742","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        \"\"\")"},{"line_number":778,"context_line":"        with mock.patch(\u0027reno.utils.check_output\u0027) as co:"},{"line_number":779,"context_line":"            co.return_value \u003d tag_list_output"},{"line_number":780,"context_line":"            actual \u003d scanner._get_version_tags_on_branch(\u0027reporoot\u0027, None)"},{"line_number":781,"context_line":"        self.assertEqual(self.EXPECTED, actual)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def test_keystoneclient_rhel_1_7_1(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_3c7dd3e7","line":780,"in_reply_to":"7a740942_7ce35b34","updated":"2015-12-09 15:45:08.000000000","message":"Done","commit_id":"3f6a625083b2569664d700f0023b4ef6acf9c9b6"}]}