)]}'
{"reno/config.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0603421dadd9cd42f6144259c31c2a41e6edc752","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # \u0027pre_release\u0027."},{"line_number":134,"context_line":"        \u0027pre_release_tag_re\u0027: \u0027\u0027\u0027"},{"line_number":135,"context_line":"            (?P\u003cpre_release\u003e\\.\\d+(?:[ab]|rc)+\\d*)$"},{"line_number":136,"context_line":"        \u0027\u0027\u0027,"},{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_510eaa3b","line":136,"updated":"2017-01-05 15:43:17.000000000","message":"We\u0027ll want to add these to the documentation, too, but I think we can do that in a separate patch.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"}],"reno/scanner.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acaf11a594df9bc8806ab7e4adc807a685b633a1","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        branch_head \u003d self._get_ref(branch)"},{"line_number":355,"context_line":"        return self._repo.get_walker(branch_head)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _get_valid_tags_on_commit(self, sha):"},{"line_number":358,"context_line":"        return [tag for tag in self._repo.get_tags_on_commit(sha)"},{"line_number":359,"context_line":"                if self.release_tag_re.match(tag)]"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_0bf61ad7","line":357,"updated":"2016-12-19 20:46:37.000000000","message":"This looks like an OK change, but I\u0027d like to consider it separately because it\u0027s more of a behavioral change than the configurable expression stuff. Is this required for the new config options to work?","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"640c429eaead35cebad9445d868ba237f7bc6e48","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        branch_head \u003d self._get_ref(branch)"},{"line_number":355,"context_line":"        return self._repo.get_walker(branch_head)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _get_valid_tags_on_commit(self, sha):"},{"line_number":358,"context_line":"        return [tag for tag in self._repo.get_tags_on_commit(sha)"},{"line_number":359,"context_line":"                if self.release_tag_re.match(tag)]"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_100535bb","line":357,"in_reply_to":"1a6eadb0_0bf61ad7","updated":"2017-01-04 14:28:49.000000000","message":"No, it\u0027s not required. I added it because checking for pre-release tags implies those tags are using the required versioning scheme. The object here was to remove the assumption and make that explicit.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acaf11a594df9bc8806ab7e4adc807a685b633a1","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                start \u003d pre_release_match.start(\u0027pre_release\u0027)"},{"line_number":405,"context_line":"                end \u003d pre_release_match.end(\u0027pre_release\u0027)"},{"line_number":406,"context_line":"            except IndexError:"},{"line_number":407,"context_line":"                raise ValueError("},{"line_number":408,"context_line":"                    (\"The pre-release tag regular expression, {!r}, is missing\""},{"line_number":409,"context_line":"                     \" a group named \u0027pre_release\u0027.\").format("},{"line_number":410,"context_line":"                        self.pre_release_tag_re.pattern"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_ab25265d","line":407,"updated":"2016-12-19 20:46:37.000000000","message":"Will this case come up for an IndexError or a KeyError?","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"640c429eaead35cebad9445d868ba237f7bc6e48","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                start \u003d pre_release_match.start(\u0027pre_release\u0027)"},{"line_number":405,"context_line":"                end \u003d pre_release_match.end(\u0027pre_release\u0027)"},{"line_number":406,"context_line":"            except IndexError:"},{"line_number":407,"context_line":"                raise ValueError("},{"line_number":408,"context_line":"                    (\"The pre-release tag regular expression, {!r}, is missing\""},{"line_number":409,"context_line":"                     \" a group named \u0027pre_release\u0027.\").format("},{"line_number":410,"context_line":"                        self.pre_release_tag_re.pattern"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_f0bfcaf8","line":407,"in_reply_to":"1a6eadb0_ab25265d","updated":"2017-01-04 14:28:49.000000000","message":"I\u0027m not sure what this comment is asking.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0603421dadd9cd42f6144259c31c2a41e6edc752","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                start \u003d pre_release_match.start(\u0027pre_release\u0027)"},{"line_number":405,"context_line":"                end \u003d pre_release_match.end(\u0027pre_release\u0027)"},{"line_number":406,"context_line":"            except IndexError:"},{"line_number":407,"context_line":"                raise ValueError("},{"line_number":408,"context_line":"                    (\"The pre-release tag regular expression, {!r}, is missing\""},{"line_number":409,"context_line":"                     \" a group named \u0027pre_release\u0027.\").format("},{"line_number":410,"context_line":"                        self.pre_release_tag_re.pattern"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_11b42280","line":407,"in_reply_to":"ba5201f7_f0bfcaf8","updated":"2017-01-05 15:43:17.000000000","message":"I was surprised a name-based lookup raised IndexError, but it seems it does.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acaf11a594df9bc8806ab7e4adc807a685b633a1","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    )"},{"line_number":412,"context_line":"                )"},{"line_number":413,"context_line":"            else:"},{"line_number":414,"context_line":"                stripped_tag \u003d tag[:start] + tag[end:]"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            stripped_tag \u003d tag"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_0ba0da8f","line":414,"updated":"2016-12-19 20:46:37.000000000","message":"Rather than dealing with indices, would it be easier to do something like:\n\n  stripped_tag \u003d self.pre_release_tag.sub(\u0027\u0027, tag).rstrip(\u0027.\u0027)\n\nI suspect this function turns into a 1-liner then.\n\nThe rstrip() is in case the expression doesn\u0027t include the literal \".\" starting that section of the version string.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"640c429eaead35cebad9445d868ba237f7bc6e48","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    )"},{"line_number":412,"context_line":"                )"},{"line_number":413,"context_line":"            else:"},{"line_number":414,"context_line":"                stripped_tag \u003d tag[:start] + tag[end:]"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            stripped_tag \u003d tag"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_f0e8aa12","line":414,"in_reply_to":"1a6eadb0_0ba0da8f","updated":"2017-01-04 14:28:49.000000000","message":"I didn\u0027t want to assume that the separator was a \u0027.\u0027, I was also looking to avoid assuming the position of the pre-release part within the string. Unless I misread the docs, my use of a named group prevented the use of sub.\n\nIf you would prefer reno to put some constraints on what can be defined as a pre-release I can rework this, it does simplify things.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0603421dadd9cd42f6144259c31c2a41e6edc752","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    )"},{"line_number":412,"context_line":"                )"},{"line_number":413,"context_line":"            else:"},{"line_number":414,"context_line":"                stripped_tag \u003d tag[:start] + tag[end:]"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            stripped_tag \u003d tag"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_113982f2","line":414,"in_reply_to":"ba5201f7_f0e8aa12","updated":"2017-01-05 15:43:17.000000000","message":"OK, that\u0027s fair.","commit_id":"c8adf65fb602f6d790a9f77a68a1cb5b53c0b3fa"}]}
