)]}'
{"reno/config.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"687f48c35aadac8fafcdde3f9315553c4091872b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            self.override(**self._contents)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def override(self, **kwds):"},{"line_number":80,"context_line":"        \"\"\"Set the values of the named configuration options."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        Take the values of the keyword arguments as the current value"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ec958a40","line":79,"updated":"2016-07-28 13:39:33.000000000","message":"I know kwargs/kwds are fairly common names, but can we use the parameter name to describe what overrides we\u0027re providing? I know this is a bit nitpicky, but I\u0027m thinking something like:\n\n    def override(self, **config_options):","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0bb61b0c9ed3e3f18469291300aab7c1a07ca2e4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            self.override(**self._contents)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def override(self, **kwds):"},{"line_number":80,"context_line":"        \"\"\"Set the values of the named configuration options."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        Take the values of the keyword arguments as the current value"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_45973690","line":79,"updated":"2016-07-28 19:07:08.000000000","message":"Of course! :)","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30740000b9fdca0ca210cf69f786c49e8f672508","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            self.override(**self._contents)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def override(self, **kwds):"},{"line_number":80,"context_line":"        \"\"\"Set the values of the named configuration options."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        Take the values of the keyword arguments as the current value"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a208a8da","line":79,"in_reply_to":"bacf61ea_ec958a40","updated":"2016-07-28 18:46:31.000000000","message":"Sure, I can change that. Is it OK to do it in a follow-up to avoid rebasing the whole series?","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0bb61b0c9ed3e3f18469291300aab7c1a07ca2e4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        arg_values \u003d {"},{"line_number":102,"context_line":"            o: getattr(parsed_args, o)"},{"line_number":103,"context_line":"            for o in self._OPTS.keys()"},{"line_number":104,"context_line":"            if hasattr(parsed_args, o)"},{"line_number":105,"context_line":"        }"},{"line_number":106,"context_line":"        self.override(**arg_values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_259202a0","line":103,"updated":"2016-07-28 19:07:08.000000000","message":"I don\u0027t think Namespace has any internal attributes:\n\n    Python 2.7.11 (default, Dec 26 2015, 17:47:15)\n    [GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin\n    Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n    \u003e\u003e\u003e import argparse\n    \u003e\u003e\u003e parser \u003d argparse.ArgumentParser()\n    \u003e\u003e\u003e parser.parse_args()\n    Namespace()\n    \u003e\u003e\u003e n \u003d _\n    \u003e\u003e\u003e vars(n)\n    {}\n\nThis too can be addressed in a follow-up patch, of course, I just feel like it\u0027s probably simpler.","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"687f48c35aadac8fafcdde3f9315553c4091872b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        arg_values \u003d {"},{"line_number":102,"context_line":"            o: getattr(parsed_args, o)"},{"line_number":103,"context_line":"            for o in self._OPTS.keys()"},{"line_number":104,"context_line":"            if hasattr(parsed_args, o)"},{"line_number":105,"context_line":"        }"},{"line_number":106,"context_line":"        self.override(**arg_values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cc924657","line":103,"updated":"2016-07-28 13:39:33.000000000","message":"Why not just do something like:\n\n    self.override(**vars(parsed_args))","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"aa90f1521bdc70459f21867201db37365057ad63","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        arg_values \u003d {"},{"line_number":102,"context_line":"            o: getattr(parsed_args, o)"},{"line_number":103,"context_line":"            for o in self._OPTS.keys()"},{"line_number":104,"context_line":"            if hasattr(parsed_args, o)"},{"line_number":105,"context_line":"        }"},{"line_number":106,"context_line":"        self.override(**arg_values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f609be2d","line":103,"in_reply_to":"bacf61ea_259202a0","updated":"2016-07-28 20:14:52.000000000","message":"OK, well, the bigger concern I had was command line options that are not configuration options.","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30740000b9fdca0ca210cf69f786c49e8f672508","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        arg_values \u003d {"},{"line_number":102,"context_line":"            o: getattr(parsed_args, o)"},{"line_number":103,"context_line":"            for o in self._OPTS.keys()"},{"line_number":104,"context_line":"            if hasattr(parsed_args, o)"},{"line_number":105,"context_line":"        }"},{"line_number":106,"context_line":"        self.override(**arg_values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_02ded43e","line":103,"in_reply_to":"bacf61ea_cc924657","updated":"2016-07-28 18:46:31.000000000","message":"Because I don\u0027t want warnings logged for properties of parsed_args that are not valid options, whether those are command line arguments that don\u0027t map to config options or internal attributes of the Namespace.","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"687f48c35aadac8fafcdde3f9315553c4091872b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.override(**arg_values)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# def parse_config_into(parsed_arguments):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"#         \"\"\"Parse the user config onto the namespace arguments."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2ca0429f","line":109,"updated":"2016-07-28 13:39:33.000000000","message":"Can we not just remove this? :)","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30740000b9fdca0ca210cf69f786c49e8f672508","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.override(**arg_values)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# def parse_config_into(parsed_arguments):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"#         \"\"\"Parse the user config onto the namespace arguments."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a2bd48d9","line":109,"in_reply_to":"bacf61ea_2ca0429f","updated":"2016-07-28 18:46:31.000000000","message":"Yeah, if it\u0027s not cleaned up by the end of the series I will submit another patch.","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"}],"reno/sphinxext.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"687f48c35aadac8fafcdde3f9315553c4091872b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # out how Sphinx passes a \"false\" flag later."},{"line_number":63,"context_line":"        # \u0027collapse-pre-releases\u0027 in self.options"},{"line_number":64,"context_line":"        opt_overrides[\u0027collapse_pre_releases\u0027] \u003d True"},{"line_number":65,"context_line":"        if \u0027earliest-version\u0027 in self.options:"},{"line_number":66,"context_line":"            opt_overrides[\u0027earliest_version\u0027] \u003d self.options.get("},{"line_number":67,"context_line":"                \u0027earliest-version\u0027)"},{"line_number":68,"context_line":"        conf.override(**opt_overrides)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0c9d7e65","line":65,"updated":"2016-07-28 13:39:33.000000000","message":"If we\u0027re checking presence here, why not use regular dictionary access below, e.g.,\n\n    opt_overrides[\u0027earliest_version\u0027] \u003d self.options[\u0027earliest-version\u0027]","commit_id":"82c8025e2ef8c250ac0098352ff11c7168f333ab"}]}