)]}'
{"releasenotes/notes/scanner-loader-context-managers-5d80d95dc3d33fe0.yaml":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2665fc10a4151f0cd8d2edb836d430d07a717af7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``reno.scanner.Scanner`` and ``reno.loader.Loader`` classes can now"},{"line_number":5,"context_line":"    be used as context managers. For example::"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6d9179aa_8e2ca48a","line":2,"updated":"2021-09-28 15:54:18.000000000","message":"Should we have a note for the bug fix, too?","commit_id":"02463bd2b2323ff69c0dfce3d8242e7c1217dd14"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0f444930a2f9e1b8050db0d3fe0ff15a243295b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``reno.scanner.Scanner`` and ``reno.loader.Loader`` classes can now"},{"line_number":5,"context_line":"    be used as context managers. For example::"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be71e9d7_b0314a3c","line":2,"in_reply_to":"6d9179aa_8e2ca48a","updated":"2021-09-28 16:27:39.000000000","message":"I wasn\u0027t sure whether to treat this as a bug fix or feature since it\u0027s a bit of both. If you\u0027re okay with me adding a note for the bugfix without tracking this as a bug (i.e. something that could conceivably be backported), I\u0027ve no issues doing so.","commit_id":"02463bd2b2323ff69c0dfce3d8242e7c1217dd14"}],"reno/tests/test_formatter.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2665fc10a4151f0cd8d2edb836d430d07a717af7","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        with mock.patch(\u0027reno.loader.Loader._load_data\u0027, _load):"},{"line_number":47,"context_line":"            # we don\u0027t need to worry about closing this after since we\u0027re not"},{"line_number":48,"context_line":"            # actually using a real Git repo here"},{"line_number":49,"context_line":"            self.ldr \u003d loader.Loader("},{"line_number":50,"context_line":"                self.c,"},{"line_number":51,"context_line":"                ignore_cache\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e91b8e08_49d33f78","line":48,"updated":"2021-09-28 15:54:18.000000000","message":"Does close() work on the patched object? It might be better to have the test code structure reflect the preferred use pattern.","commit_id":"02463bd2b2323ff69c0dfce3d8242e7c1217dd14"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0f444930a2f9e1b8050db0d3fe0ff15a243295b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        with mock.patch(\u0027reno.loader.Loader._load_data\u0027, _load):"},{"line_number":47,"context_line":"            # we don\u0027t need to worry about closing this after since we\u0027re not"},{"line_number":48,"context_line":"            # actually using a real Git repo here"},{"line_number":49,"context_line":"            self.ldr \u003d loader.Loader("},{"line_number":50,"context_line":"                self.c,"},{"line_number":51,"context_line":"                ignore_cache\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e4bd88e_0122f8aa","line":48,"in_reply_to":"e91b8e08_49d33f78","updated":"2021-09-28 16:27:39.000000000","message":"It wouldn\u0027t, since \u0027_load_data\u0027 is what sets the \u0027self.scanner\u0027 attribute that we call close on.\n\nLater: actually, \u0027self.scanner\u0027 can be unset so I should be checking for that. So yeah, let\u0027s do this properly.","commit_id":"02463bd2b2323ff69c0dfce3d8242e7c1217dd14"}]}