)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecaad6dcd59effe79b0e788b590e069244c85a8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b31d90cf_a3ee24ac","updated":"2023-03-07 08:45:33.000000000","message":"Quite OK with this change, I\u0027m quite OK with Doug point, but fwiw, Nova is impacted by the issue : we can\u0027t yet have the release notes for 2023.1, see https://review.opendev.org/c/openstack/nova/+/876553","commit_id":"3dcd5087e519955f96482f3880a23e6fc498f200"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"ade45b18adb937f56fa983f3cad255224b351ec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea7bf8fc_c1163d99","updated":"2023-03-07 13:15:33.000000000","message":"I like it, it\u0027s easy enough for non-openstack users to opt out of it or supply your own breaking sorting point.\n\nCould use tests but we kinda need the fix asap, so happy to approve as-is.","commit_id":"89a3da5230dc9c7e16d53d05f88ffb2423d5c080"}],"releasenotes/notes/openstack-stable-ordering-f5fd8801e105f13a.yaml":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1b8c943bddce014e936c3616d3112787eb39ffff","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    branches like ``stable/zed``. Two new variables have been added to"},{"line_number":10,"context_line":"    control the behaviour, ``branch_sort_re`` and ``branch_sort_prefix``."},{"line_number":11,"context_line":"    See their help text for more information."},{"line_number":12,"context_line":"upgrades:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The default sort order for branch names has been modified in order"},{"line_number":15,"context_line":"    to accomodate the way OpenStack stable branches are named. See the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a549fdf2_9abfcd5d","line":12,"updated":"2023-03-07 13:41:26.000000000","message":"The linter wants this to be \"upgrade\".","commit_id":"89a3da5230dc9c7e16d53d05f88ffb2423d5c080"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"eddab0a356960e669f2ed55e10aab78afc00efc0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    branches like ``stable/zed``. Two new variables have been added to"},{"line_number":10,"context_line":"    control the behaviour, ``branch_sort_re`` and ``branch_sort_prefix``."},{"line_number":11,"context_line":"    See their help text for more information."},{"line_number":12,"context_line":"upgrades:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The default sort order for branch names has been modified in order"},{"line_number":15,"context_line":"    to accomodate the way OpenStack stable branches are named. See the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"54f83adc_f02d3c26","line":12,"in_reply_to":"a549fdf2_9abfcd5d","updated":"2023-03-07 13:56:18.000000000","message":"Done","commit_id":"89a3da5230dc9c7e16d53d05f88ffb2423d5c080"}],"reno/config.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d1e1674111e9d91404859ddab3de92960a99b8b8","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        \"base\" of a branch. Other branches are ignored."},{"line_number":115,"context_line":"        \"\"\")),"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    Opt(\u0027openstack_branch_ordering\u0027, False,"},{"line_number":118,"context_line":"        textwrap.dedent(\"\"\"\\"},{"line_number":119,"context_line":"        By default branches are sorted alphabetically, but in"},{"line_number":120,"context_line":"        openstack-land, 2023.1 should sort after zed. This option"}],"source_content_type":"text/x-python","patch_set":1,"id":"12e73004_107245a2","line":117,"updated":"2023-03-06 14:50:01.000000000","message":"Defaulting to false will mean finding every place it is invoked in every project and ensuring the value is set to true. I don\u0027t think reno is widely used outside of OpenStack and if it is I don\u0027t think the consuming projects are likely to have as many branches as OpenStack. It should be safe to enable this behavior by default. The next release of reno could be a major version update to signal the potentially breaking change.","commit_id":"3dcd5087e519955f96482f3880a23e6fc498f200"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecaad6dcd59effe79b0e788b590e069244c85a8e","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        \"base\" of a branch. Other branches are ignored."},{"line_number":115,"context_line":"        \"\"\")),"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    Opt(\u0027openstack_branch_ordering\u0027, False,"},{"line_number":118,"context_line":"        textwrap.dedent(\"\"\"\\"},{"line_number":119,"context_line":"        By default branches are sorted alphabetically, but in"},{"line_number":120,"context_line":"        openstack-land, 2023.1 should sort after zed. This option"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b11dcdb_af7d8ef2","line":117,"in_reply_to":"12e73004_107245a2","updated":"2023-03-07 08:45:33.000000000","message":"Well, true enough, but maybe other projects would like to provide their own ordering way if so ;-)\n\n(Like, the Puppies project would like to ask reno to a have a ordering like the \u0027Cat\u0027 release is before the \u0027Dog\u0027 one :-)","commit_id":"3dcd5087e519955f96482f3880a23e6fc498f200"}],"reno/scanner.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecaad6dcd59effe79b0e788b590e069244c85a8e","unresolved":true,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"def openstack_sort_key(name):"},{"line_number":508,"context_line":"    if name.startswith(\u0027stable/2\u0027):"},{"line_number":509,"context_line":"        return \u0027stable/zzz\u0027 + name[8:]"},{"line_number":510,"context_line":"    return name"},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f76f2c44_8501ed79","line":508,"range":{"start_line":508,"start_character":23,"end_line":508,"end_character":33},"updated":"2023-03-07 08:45:33.000000000","message":"we may have a situation in the next millenium, but fair enough.","commit_id":"3dcd5087e519955f96482f3880a23e6fc498f200"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6e65487ad3cada064718c60e330eebb78c49372b","unresolved":true,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"def openstack_sort_key(name):"},{"line_number":508,"context_line":"    if name.startswith(\u0027stable/2\u0027):"},{"line_number":509,"context_line":"        return \u0027stable/zzz\u0027 + name[8:]"},{"line_number":510,"context_line":"    return name"},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"15ec3dda_00842477","line":508,"range":{"start_line":508,"start_character":23,"end_line":508,"end_character":33},"in_reply_to":"f76f2c44_8501ed79","updated":"2023-03-07 10:26:05.000000000","message":"😄","commit_id":"3dcd5087e519955f96482f3880a23e6fc498f200"}]}