)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"c057ccf5cc496a42e9f3b632dcce561a5f6e781d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db466426_0f375962","updated":"2023-03-30 11:52:53.000000000","message":"Sounds fair","commit_id":"92a20ce518a504a8d312390785088574d200b897"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ac41d00283ef4ca52dd88430323465c7b53e4999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d2d6de30_f4da6c80","updated":"2023-10-27 14:57:35.000000000","message":"This looks trivial, so LGTM.","commit_id":"92a20ce518a504a8d312390785088574d200b897"}],"reno/scanner.py":[{"author":{"_account_id":35758,"name":"Eric Arellano","display_name":"Eric Arellano","email":"ericarellano@me.com","username":"arellano"},"change_message_id":"3e3e5be55e0c4e06af48857bce65877cabc9d308","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"        # a note is removed, this step should let us ignore it."},{"line_number":1216,"context_line":"        for uniqueid, version in tracker.earliest_seen.items():"},{"line_number":1217,"context_line":"            try:"},{"line_number":1218,"context_line":"                base, sha \u003d tracker.last_name_by_id[uniqueid]"},{"line_number":1219,"context_line":"                LOG.debug(\u0027%s: sorting %s into version %s\u0027,"},{"line_number":1220,"context_line":"                          uniqueid, base, version)"},{"line_number":1221,"context_line":"                files_and_tags[version].append((base, sha))"}],"source_content_type":"text/x-python","patch_set":1,"id":"43e55ffe_0254716a","side":"PARENT","line":1218,"updated":"2023-03-07 22:25:22.000000000","message":"Here\u0027s my read of this code: \n\nA line above, we have `for uniqueid, version in tracker.earliest_seen.items()`. `earliest_seen` stores the `uniqueid` for all release notes ever encountered by going through all of Git history.`uniqueid` is the hash in the release note file path.\n\nThen, here, we\u0027re looking up that uniqueid in `last_name_by_id`, which (I think) doesn\u0027t include deleted release notes, according to my read of the comment in `_ChangeTracker.delete()`. That is consistent with the comment on lines 1223-1224 below, that we expect to have had a KeyError for deleted files.\n\n(If the file was renamed, rather than deleted, we\u0027ll have handled that okay.)\n\nIn other words, we were printing a noisy message for a very legitimate operation of deleting a release note.\n\n--\n\nYeah, I just tried this out in the Reno repo by adding a note in a commit. Then deleting it in a commit. Then `reno list`. And indeed we get the warning.","commit_id":"64f649cd72c3ee34b0af17201e4db1d2e8e3cf8c"},{"author":{"_account_id":35758,"name":"Eric Arellano","display_name":"Eric Arellano","email":"ericarellano@me.com","username":"arellano"},"change_message_id":"aa094fd37e6adedb46b41644ac7fd2357667ae80","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"        # a note is removed, this step should let us ignore it."},{"line_number":1216,"context_line":"        for uniqueid, version in tracker.earliest_seen.items():"},{"line_number":1217,"context_line":"            try:"},{"line_number":1218,"context_line":"                base, sha \u003d tracker.last_name_by_id[uniqueid]"},{"line_number":1219,"context_line":"                LOG.debug(\u0027%s: sorting %s into version %s\u0027,"},{"line_number":1220,"context_line":"                          uniqueid, base, version)"},{"line_number":1221,"context_line":"                files_and_tags[version].append((base, sha))"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d96ea5d_b75b553d","side":"PARENT","line":1218,"in_reply_to":"128488fa_c72c0315","updated":"2023-03-07 23:26:27.000000000","message":"I don\u0027t see a way to set `verbose` for Sphinx: https://docs.openstack.org/reno/latest/user/sphinxext.html. There\u0027s no config option in `config.py` for verbosity either.\n\nBut either way, this is a debug level message and not an actionable issue that users should act on. All it\u0027s saying is that the release note from a prior commit no longer exists because it was deleted (not renamed). That\u0027s useful for debug mode, but otherwise noisy.","commit_id":"64f649cd72c3ee34b0af17201e4db1d2e8e3cf8c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"18d2060c31f478a98dff6d803264f7ac3b574115","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"        # a note is removed, this step should let us ignore it."},{"line_number":1216,"context_line":"        for uniqueid, version in tracker.earliest_seen.items():"},{"line_number":1217,"context_line":"            try:"},{"line_number":1218,"context_line":"                base, sha \u003d tracker.last_name_by_id[uniqueid]"},{"line_number":1219,"context_line":"                LOG.debug(\u0027%s: sorting %s into version %s\u0027,"},{"line_number":1220,"context_line":"                          uniqueid, base, version)"},{"line_number":1221,"context_line":"                files_and_tags[version].append((base, sha))"}],"source_content_type":"text/x-python","patch_set":1,"id":"128488fa_c72c0315","side":"PARENT","line":1218,"in_reply_to":"43e55ffe_0254716a","updated":"2023-03-07 23:01:36.000000000","message":"That line is pretty old, so I don\u0027t remember why it\u0027s there. It\u0027s not just a developer debug, because I wouldn\u0027t have used stderr for that. It could be to ensure the messages show up when running as part of Sphinx, but I think the Sphinx integration configures the logger properly now so maybe it\u0027s not needed.\n\nCould you verify that building docs with Sphinx with the verbose flag set on the command line shows the messages, too?","commit_id":"64f649cd72c3ee34b0af17201e4db1d2e8e3cf8c"},{"author":{"_account_id":35758,"name":"Eric Arellano","display_name":"Eric Arellano","email":"ericarellano@me.com","username":"arellano"},"change_message_id":"23c0258493bf52feb8236c627f5cc40b45e4d523","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"        # a note is removed, this step should let us ignore it."},{"line_number":1216,"context_line":"        for uniqueid, version in tracker.earliest_seen.items():"},{"line_number":1217,"context_line":"            try:"},{"line_number":1218,"context_line":"                base, sha \u003d tracker.last_name_by_id[uniqueid]"},{"line_number":1219,"context_line":"                LOG.debug(\u0027%s: sorting %s into version %s\u0027,"},{"line_number":1220,"context_line":"                          uniqueid, base, version)"},{"line_number":1221,"context_line":"                files_and_tags[version].append((base, sha))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcaa24b4_dbce1507","side":"PARENT","line":1218,"in_reply_to":"6d96ea5d_b75b553d","updated":"2023-03-09 15:35:04.000000000","message":"Matthew suggested using `tox -e docs -- -vvvvv` and `-- -v`. It doesn\u0027t look like that causes the Reno Sphinx extension\u0027s debug logging to trigger, unfortunately.","commit_id":"64f649cd72c3ee34b0af17201e4db1d2e8e3cf8c"}]}