)]}'
{"README.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"63a0705fc379c3e63877e14e6a407e148de58e8a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"the suitability of the library."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Solution"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt`` that"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_467b4029","line":39,"updated":"2014-08-25 20:23:57.000000000","message":"nit: \u003d\u003d\u003d\u0027s don\u0027t match title length","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":36,"context_line":"the suitability of the library."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Solution"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt`` that"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_a126a266","line":39,"in_reply_to":"1abeadc6_467b4029","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt`` that"},{"line_number":43,"context_line":"are allowed in OpenStack projects (in either requirements.txt or"},{"line_number":44,"context_line":"test-requirements.txt)."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_eb997520","line":42,"updated":"2014-08-25 20:13:26.000000000","message":"nit: missing closing )?","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt`` that"},{"line_number":43,"context_line":"are allowed in OpenStack projects (in either requirements.txt or"},{"line_number":44,"context_line":"test-requirements.txt)."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_81bd26da","line":42,"in_reply_to":"1abeadc6_eb997520","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When installing with devstack, we overwrite the ``requirements.txt``"},{"line_number":50,"context_line":"and ``test-requirements.txt`` with the versions from"},{"line_number":51,"context_line":"``global-requirements.txt``. This ensures that we will get a"},{"line_number":52,"context_line":"deterministic set of requirements installed in the test system, and it"},{"line_number":53,"context_line":"won\u0027t be a guessing game based on the last piece of software to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_8c8f3775","line":50,"updated":"2014-08-25 21:25:54.000000000","message":"We should say clearly here that we do this in *every project* and not just this repository or devstack itself.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When installing with devstack, we overwrite the ``requirements.txt``"},{"line_number":50,"context_line":"and ``test-requirements.txt`` with the versions from"},{"line_number":51,"context_line":"``global-requirements.txt``. This ensures that we will get a"},{"line_number":52,"context_line":"deterministic set of requirements installed in the test system, and it"},{"line_number":53,"context_line":"won\u0027t be a guessing game based on the last piece of software to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_c1855e08","line":50,"in_reply_to":"1abeadc6_8c8f3775","updated":"2014-08-26 12:58:04.000000000","message":"sure, though I\u0027m not sure how one would logically think this would work otherwise. :)","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"request for the new requirements definition to the projects."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is intended as a time saving device for projects, as they can"},{"line_number":74,"context_line":"fast approve requirements syncs and not have to manually work about"},{"line_number":75,"context_line":"whether or not they are up to date with the global definition."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Running"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_ebc095e2","line":74,"updated":"2014-08-25 20:13:26.000000000","message":"s/work about/worry about/?","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":71,"context_line":"request for the new requirements definition to the projects."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is intended as a time saving device for projects, as they can"},{"line_number":74,"context_line":"fast approve requirements syncs and not have to manually work about"},{"line_number":75,"context_line":"whether or not they are up to date with the global definition."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Running"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_41714e43","line":74,"in_reply_to":"1abeadc6_ebc095e2","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is intended as a time saving device for projects, as they can"},{"line_number":74,"context_line":"fast approve requirements syncs and not have to manually work about"},{"line_number":75,"context_line":"whether or not they are up to date with the global definition."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Running"},{"line_number":78,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_ace31332","line":75,"updated":"2014-08-25 21:25:54.000000000","message":"Do we want to say anything here about assuming/requiring that projects *do* fast-approve those changes?","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This is intended as a time saving device for projects, as they can"},{"line_number":74,"context_line":"fast approve requirements syncs and not have to manually work about"},{"line_number":75,"context_line":"whether or not they are up to date with the global definition."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Running"},{"line_number":78,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_e1a25a99","line":75,"in_reply_to":"1abeadc6_ace31332","updated":"2014-08-26 12:58:04.000000000","message":"honestly, I think that\u0027s project specific. This is intent on why we do it, not telling projects what they do.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  python update.py path/to/project"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Entries in requirements.txt and test-requirements.txt"},{"line_number":85,"context_line":"will have their versions updated to match the entires"},{"line_number":86,"context_line":"listed here. Any entries in the target project which"},{"line_number":87,"context_line":"do not first exist here will be removed. No entries"},{"line_number":88,"context_line":"will be added."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_6bac8536","line":85,"updated":"2014-08-25 20:13:26.000000000","message":"s/entires/entries/","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Review Guidelines"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"There are a set of questions that every reviewer should ask any on any"},{"line_number":94,"context_line":"proposed requirements change (and one that proposers should pre answer"},{"line_number":95,"context_line":"to make things go smoother)."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_cb62f915","line":93,"updated":"2014-08-25 20:13:26.000000000","message":"s/any on any/on any/","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"General Review Criteria"},{"line_number":98,"context_line":"-----------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- No libraries should contain version caps"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  As a community we value early feedback of broken upstream"},{"line_number":103,"context_line":"  requirements, so version caps should be avoided except when dealing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_8c02d7b2","line":100,"updated":"2014-08-25 21:25:54.000000000","message":"I think the wiki is out of date with our current practices.\n\nnit: You\u0027re not consistent with punctuation in the bullets in this list.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47fa6d9940d14cbdb8bcb2d622996cfcfae0dcfb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"General Review Criteria"},{"line_number":98,"context_line":"-----------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- No libraries should contain version caps"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  As a community we value early feedback of broken upstream"},{"line_number":103,"context_line":"  requirements, so version caps should be avoided except when dealing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_26cf24b2","line":100,"updated":"2014-08-25 20:14:54.000000000","message":"This conflicts with the statement in the wiki:\n\nhttps://wiki.openstack.org/wiki/Requirements\n\n\"requirements with a missing upper bound on \u003c next major number are dangerous\"","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":97,"context_line":"General Review Criteria"},{"line_number":98,"context_line":"-----------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- No libraries should contain version caps"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  As a community we value early feedback of broken upstream"},{"line_number":103,"context_line":"  requirements, so version caps should be avoided except when dealing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_21c4523f","line":100,"in_reply_to":"1abeadc6_8c02d7b2","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  be working now."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For new Requirements"},{"line_number":120,"context_line":"--------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_06a5c803","line":119,"updated":"2014-08-25 20:13:26.000000000","message":"This wiki lists \"commit log message includes information about the OpenStack project(s) using the requirement\":\n\nhttps://wiki.openstack.org/wiki/Requirements\n\nSeems like this should typically be tied to a blueprint, but may not always be so.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  be working now."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For new Requirements"},{"line_number":120,"context_line":"--------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_e16c1a39","line":119,"in_reply_to":"1abeadc6_0641480b","updated":"2014-08-26 12:58:04.000000000","message":"honestly, I think this one I\u0027d rather just leave for now or a future debate, as I think the whole oslo alpha thing is a mess and something we need to do a summit session about.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  be working now."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For new Requirements"},{"line_number":120,"context_line":"--------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_411b0eca","line":119,"in_reply_to":"1abeadc6_06a5c803","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47fa6d9940d14cbdb8bcb2d622996cfcfae0dcfb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  be working now."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For new Requirements"},{"line_number":120,"context_line":"--------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_0641480b","line":119,"in_reply_to":"1abeadc6_06a5c803","updated":"2014-08-25 20:14:54.000000000","message":"This is also in the wiki:\n\n\"use of pre-release versions of things needs an explanation\"\n\nOslo seems to be the exception for this now with the alpha releases.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c31100786b04d05721c2607972e848d5ef182fa4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  can get support on if we or our users find a bug, and that we"},{"line_number":126,"context_line":"  don\u0027t have to take over and fork the library."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  Pointers to recently activity upstream and a consistent release"},{"line_number":129,"context_line":"  model appreciated."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- Is the library good code?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_861c786c","line":128,"updated":"2014-08-25 20:13:26.000000000","message":"s/recently/recent/","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  can get support on if we or our users find a bug, and that we"},{"line_number":126,"context_line":"  don\u0027t have to take over and fork the library."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  Pointers to recently activity upstream and a consistent release"},{"line_number":129,"context_line":"  model appreciated."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- Is the library good code?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_01683620","line":128,"in_reply_to":"1abeadc6_861c786c","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"695c1dee647c6b8752b08b4e0ef7bb7fc0fd06f4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  to depend on. That includes ensuring the upstream code has some"},{"line_number":137,"context_line":"  reasonable testing baked in."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  While quality is in the eye of the beholder, completely crazy code"},{"line_number":140,"context_line":"  usually stands out, and should be avoided."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Is the library python 3 compatible?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_591cfa6a","line":139,"updated":"2014-08-25 23:46:53.000000000","message":"This paragraph just seems like it could be removed and retain the same amount of value.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  to depend on. That includes ensuring the upstream code has some"},{"line_number":137,"context_line":"  reasonable testing baked in."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  While quality is in the eye of the beholder, completely crazy code"},{"line_number":140,"context_line":"  usually stands out, and should be avoided."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Is the library python 3 compatible?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_61600a36","line":139,"in_reply_to":"1abeadc6_591cfa6a","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  By adding something to OpenStack ``global-requirements.txt`` we are"},{"line_number":157,"context_line":"  basically demanding that Linux Distros package this for the next"},{"line_number":158,"context_line":"  release of OpenStack. If they already have, great. If not, we should"},{"line_number":159,"context_line":"  be cautious adding it. See *Finding Distro Status* later in this"},{"line_number":160,"context_line":"  document."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- Is the function of this library already covered by other libraries"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_eca50bb6","line":159,"updated":"2014-08-25 21:25:54.000000000","message":"change \"*Finding Distro Status* later in this document.\" to:\n\n  :ref:`finding-distro-status`\n\nSee also the comment on line 184. This form will insert the section title as a link here, and update it if the section title ever changes.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c07c11101d3dde19c3b65ac2246ddeb29b2befb6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  requirement is about replacing an existing library with one that\u0027s"},{"line_number":168,"context_line":"  better suited for our needs the submitter needs to have committed"},{"line_number":169,"context_line":"  to, and already proposed patches that convert all projects.txt use"},{"line_number":170,"context_line":"  of the old library to the new one."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"For Upgrading Requirements Versions"},{"line_number":173,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_26b004f4","line":170,"updated":"2014-08-25 20:23:48.000000000","message":"This last clause is awkward and unclear; I had to read it a couple of times to figure out what was meant.  Maybe:\n\n    If this new requirement is about replacing an existing library with one\n    that\u0027s better suited for our needs, then the submitter must have either\n    proposed patches or committed to proposing patches to convert all\n    the projects listed in ``projects.txt`` to using the new library.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  requirement is about replacing an existing library with one that\u0027s"},{"line_number":168,"context_line":"  better suited for our needs the submitter needs to have committed"},{"line_number":169,"context_line":"  to, and already proposed patches that convert all projects.txt use"},{"line_number":170,"context_line":"  of the old library to the new one."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"For Upgrading Requirements Versions"},{"line_number":173,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_0c99676e","line":170,"updated":"2014-08-25 21:25:54.000000000","message":"We should elaborate here that there needs to be agreement on the part of the projects who are using the old library to allow the updates to the new one. We could specify that their PTLs need to sign off on the requirements change here or something like that.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  requirement is about replacing an existing library with one that\u0027s"},{"line_number":168,"context_line":"  better suited for our needs the submitter needs to have committed"},{"line_number":169,"context_line":"  to, and already proposed patches that convert all projects.txt use"},{"line_number":170,"context_line":"  of the old library to the new one."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"For Upgrading Requirements Versions"},{"line_number":173,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_c1b9de7a","line":170,"in_reply_to":"1abeadc6_0c99676e","updated":"2014-08-26 12:58:04.000000000","message":"I\u0027m going to provide a more generic statement here about needing a transition plan. What that means can be decided by reviews at the time.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"63a0705fc379c3e63877e14e6a407e148de58e8a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  of the old library to the new one."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"For Upgrading Requirements Versions"},{"line_number":173,"context_line":"--------------------------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"- Why is it impossible to use the current version definition?"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_46c3408a","line":173,"updated":"2014-08-25 20:23:57.000000000","message":"nit, dashes aren\u0027t matching up with title length","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  of the old library to the new one."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"For Upgrading Requirements Versions"},{"line_number":173,"context_line":"--------------------------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"- Why is it impossible to use the current version definition?"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_614aca84","line":173,"in_reply_to":"1abeadc6_46c3408a","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"63e2ce6e8fb3a1a339e6f81daa2642b64cb7d2fa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  changed."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  Leave that decision to deployers and distros."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Finding Distro Status"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_6ce3bb05","line":184,"updated":"2014-08-25 21:25:54.000000000","message":"insert:\n\n  .. _finding-distro-status:","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  changed."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  Leave that decision to deployers and distros."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Finding Distro Status"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_417ceeb5","line":184,"in_reply_to":"1abeadc6_6ce3bb05","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c07c11101d3dde19c3b65ac2246ddeb29b2befb6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Finding Distro Status"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The OpenStack distro support policy is new software is written to the"},{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_26872411","line":188,"updated":"2014-08-25 20:23:48.000000000","message":"s/is new/is that new/\n\ns/is written/should be written/\n\ns/to the latest/to support the latest/","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Finding Distro Status"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The OpenStack distro support policy is new software is written to the"},{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_814d269c","line":188,"in_reply_to":"1abeadc6_26872411","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c07c11101d3dde19c3b65ac2246ddeb29b2befb6","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The OpenStack distro support policy is new software is written to the"},{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"},{"line_number":192,"context_line":"not cause too much pain."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_669f5c51","line":190,"updated":"2014-08-25 20:23:48.000000000","message":"Maybe this last clause (from the comma after \"releases\") should read:\n\n    with support of the last LTS of those distros a bonus.","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The OpenStack distro support policy is new software is written to the"},{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"},{"line_number":192,"context_line":"not cause too much pain."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_a144e274","line":190,"in_reply_to":"1abeadc6_669f5c51","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c07c11101d3dde19c3b65ac2246ddeb29b2befb6","unresolved":false,"context_lines":[{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"},{"line_number":192,"context_line":"not cause too much pain."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"For people unfamiliar with Linux Distro packaging you can use the"},{"line_number":195,"context_line":"following tools to search for packages:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_06e788e5","line":192,"updated":"2014-08-25 20:23:48.000000000","message":"\"We would also like to ensure that there is not too much pain for the Debian and SuSE communities.\"","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc89471403962e5bd13ff298496daf1a9c405471","unresolved":false,"context_lines":[{"line_number":189,"context_line":"latest Ubuntu and Fedora releases, with bonus points to make it easy"},{"line_number":190,"context_line":"to use on the last LTS of both of those distros. We also have active"},{"line_number":191,"context_line":"involvement by the Debian and SuSE communities that we would like to"},{"line_number":192,"context_line":"not cause too much pain."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"For people unfamiliar with Linux Distro packaging you can use the"},{"line_number":195,"context_line":"following tools to search for packages:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_c1471e76","line":192,"in_reply_to":"1abeadc6_06e788e5","updated":"2014-08-26 12:58:04.000000000","message":"Done","commit_id":"4996956943fbbb6f096fd0ca6ab60402abc5a0f7"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":25,"context_line":"We also had an issue with projects adding dependencies of python"},{"line_number":26,"context_line":"libraries without thinking through the long term implications of those"},{"line_number":27,"context_line":"libraries. Is the library actively maintained? Is the library of a"},{"line_number":28,"context_line":"compatible license? Is the library duplicative of existing libraries"},{"line_number":29,"context_line":"that we already have in requirements? Is the library python 3"},{"line_number":30,"context_line":"compatible? Is the library something that already exists in Linux"},{"line_number":31,"context_line":"Distros that we target (Ubuntu / Fedora). The answer to many of these"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_a7294d8b","line":28,"updated":"2014-08-26 15:29:27.000000000","message":"s/Is the library duplicative of/Does the library duplicate/—\"duplicative\" is not a word :)","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"We also had an issue with projects adding dependencies of python"},{"line_number":26,"context_line":"libraries without thinking through the long term implications of those"},{"line_number":27,"context_line":"libraries. Is the library actively maintained? Is the library of a"},{"line_number":28,"context_line":"compatible license? Is the library duplicative of existing libraries"},{"line_number":29,"context_line":"that we already have in requirements? Is the library python 3"},{"line_number":30,"context_line":"compatible? Is the library something that already exists in Linux"},{"line_number":31,"context_line":"Distros that we target (Ubuntu / Fedora). The answer to many of these"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_5834d4dd","line":28,"in_reply_to":"1abeadc6_a7294d8b","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Solution"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt``)"},{"line_number":43,"context_line":"that are allowed in OpenStack projects. This is enforcing for both"},{"line_number":44,"context_line":"``requirements.txt`` and ``test-requirements.txt``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_e75a6529","line":41,"updated":"2014-08-26 15:29:27.000000000","message":"s/is/are/","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Solution"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt``)"},{"line_number":43,"context_line":"that are allowed in OpenStack projects. This is enforcing for both"},{"line_number":44,"context_line":"``requirements.txt`` and ``test-requirements.txt``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_984d8c75","line":41,"in_reply_to":"1abeadc6_e75a6529","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt``)"},{"line_number":43,"context_line":"that are allowed in OpenStack projects. This is enforcing for both"},{"line_number":44,"context_line":"``requirements.txt`` and ``test-requirements.txt``."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Enforcement for Test Runs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_67465551","line":43,"updated":"2014-08-26 15:29:27.000000000","message":"s/enforcing/enforced/","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The mechanics of the solution is relatively simple. We maintain a"},{"line_number":42,"context_line":"central list of all the requirements (``global-requirements.txt``)"},{"line_number":43,"context_line":"that are allowed in OpenStack projects. This is enforcing for both"},{"line_number":44,"context_line":"``requirements.txt`` and ``test-requirements.txt``."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Enforcement for Test Runs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_d8570401","line":43,"in_reply_to":"1abeadc6_67465551","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Automatic Sync of Accepted Requirements"},{"line_number":67,"context_line":"---------------------------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"If a new requirement is proposed to OpenStack and accepted to"},{"line_number":70,"context_line":"requirements, the system then also automatically pushes a review"},{"line_number":71,"context_line":"request for the new requirements definition to the projects."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_e7f6e5f8","line":69,"updated":"2014-08-26 15:29:27.000000000","message":"This could be construed to mean that if someone proposes a new library that hitherto has not been listed, then a review request will be pushed to add that to all projects.  I think it should be rephrased to something like:\n\n    If an existing requirement is updated and accepted into requirements,\n    then the system also automatically pushes a review request for the new\n    requirements definition to all projects that use that requirement.","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Automatic Sync of Accepted Requirements"},{"line_number":67,"context_line":"---------------------------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"If a new requirement is proposed to OpenStack and accepted to"},{"line_number":70,"context_line":"requirements, the system then also automatically pushes a review"},{"line_number":71,"context_line":"request for the new requirements definition to the projects."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_f87f6064","line":69,"in_reply_to":"1abeadc6_e7f6e5f8","updated":"2014-08-26 16:34:25.000000000","message":"I did an example instead. Hopefully more clear.","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  Exceptionally unstable libraries should also be considered something"},{"line_number":106,"context_line":"  we want to replace over time with ones that aren\u0027t, or are upstream"},{"line_number":107,"context_line":"  communities where we\u0027d like to encourage getting more testing into"},{"line_number":108,"context_line":"  their normal upstream process."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- Libraries should contain a sensible known working minimum"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_47beb900","line":108,"updated":"2014-08-26 15:29:27.000000000","message":"The clause starting with \"or are upstream communities\" isn\u0027t making sense to me; I\u0027m not sure what is meant, or I\u0027d propose an alternate wording.  Could you clarify?","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  Exceptionally unstable libraries should also be considered something"},{"line_number":106,"context_line":"  we want to replace over time with ones that aren\u0027t, or are upstream"},{"line_number":107,"context_line":"  communities where we\u0027d like to encourage getting more testing into"},{"line_number":108,"context_line":"  their normal upstream process."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- Libraries should contain a sensible known working minimum"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_18ddfc70","line":108,"in_reply_to":"1abeadc6_47beb900","updated":"2014-08-26 16:34:25.000000000","message":"attempted","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a5511962ef14f86c52d236b372e99745870f9d00","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  new library to be added. Ideally the proposed code is up already in"},{"line_number":121,"context_line":"  the projects so that it\u0027s use can be seen."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"For new Requirements"},{"line_number":124,"context_line":"--------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_64bf33ab","line":123,"updated":"2014-08-26 15:06:36.000000000","message":"With these questions should we provide a template for a commit message?","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  new library to be added. Ideally the proposed code is up already in"},{"line_number":121,"context_line":"  the projects so that it\u0027s use can be seen."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"For new Requirements"},{"line_number":124,"context_line":"--------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_e7b7c5f3","line":123,"in_reply_to":"1abeadc6_64bf33ab","updated":"2014-08-26 15:29:27.000000000","message":"If we decide to use a template, we should probably document it in a secondary file and give instructions on using \"git commit -t\"","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  new library to be added. Ideally the proposed code is up already in"},{"line_number":121,"context_line":"  the projects so that it\u0027s use can be seen."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"For new Requirements"},{"line_number":124,"context_line":"--------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- Is the library actively maintained?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_f80cc03d","line":123,"in_reply_to":"1abeadc6_e7b7c5f3","updated":"2014-08-26 16:34:25.000000000","message":"I agree, separate file / separate commit and the git commit instructions.","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  don\u0027t have to take over and fork the library."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  Pointers to recent activity upstream and a consistent release model"},{"line_number":133,"context_line":"  appreciated."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"- Is the library good code?"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_a7086dda","line":133,"updated":"2014-08-26 15:29:27.000000000","message":"s/appreciated/is appreciated/","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  don\u0027t have to take over and fork the library."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  Pointers to recent activity upstream and a consistent release model"},{"line_number":133,"context_line":"  appreciated."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"- Is the library good code?"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_18c41c91","line":133,"in_reply_to":"1abeadc6_a7086dda","updated":"2014-08-26 16:34:25.000000000","message":"I think it\u0027s actually are because of the and, but fixed.","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":135,"context_line":"- Is the library good code?"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  It\u0027s expected before just telling everyone to download arbitrary 3rd"},{"line_number":138,"context_line":"  party code from the internet the submitter has taken a deep dive"},{"line_number":139,"context_line":"  into the code to get a feel on whether this code seems solid enough"},{"line_number":140,"context_line":"  to depend on. That includes ensuring the upstream code has some"},{"line_number":141,"context_line":"  reasonable testing baked in."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_0795a13f","line":138,"updated":"2014-08-26 15:29:27.000000000","message":"A little more punctuation to make this clearer:\n\n    It\u0027s expected, before just telling everyone to download arbitrary 3rd\n    party code from the internet, that the submitter has taken a deep dive","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"- Is the library good code?"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  It\u0027s expected before just telling everyone to download arbitrary 3rd"},{"line_number":138,"context_line":"  party code from the internet the submitter has taken a deep dive"},{"line_number":139,"context_line":"  into the code to get a feel on whether this code seems solid enough"},{"line_number":140,"context_line":"  to depend on. That includes ensuring the upstream code has some"},{"line_number":141,"context_line":"  reasonable testing baked in."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_d841c40c","line":138,"in_reply_to":"1abeadc6_0795a13f","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  need 3 different request mocking libraries in OpenStack."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  If this new requirement is about replacing an existing library with"},{"line_number":169,"context_line":"  one that\u0027s better suited for our needs then we also need the"},{"line_number":170,"context_line":"  transition plan to drop the old library in a reasonable amount of"},{"line_number":171,"context_line":"  time."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_4776b93f","line":169,"updated":"2014-08-26 15:29:27.000000000","message":"s/needs then/needs, then/","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  need 3 different request mocking libraries in OpenStack."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  If this new requirement is about replacing an existing library with"},{"line_number":169,"context_line":"  one that\u0027s better suited for our needs then we also need the"},{"line_number":170,"context_line":"  transition plan to drop the old library in a reasonable amount of"},{"line_number":171,"context_line":"  time."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_5855b4c4","line":169,"in_reply_to":"1abeadc6_4776b93f","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b496fc6199bb4ef2390a0c88bbd371ceee711c46","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  Everyone likes everyone else to use the latest version of their"},{"line_number":179,"context_line":"  code, however deployers really don\u0027t like to be constantly updating"},{"line_number":180,"context_line":"  things. Unless it\u0027s actually **impossible** to use the minimum"},{"line_number":181,"context_line":"  version specified in ``global-requirements.txt`` it should not be"},{"line_number":182,"context_line":"  changed."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  Leave that decision to deployers and distros."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_e79c2560","line":181,"updated":"2014-08-26 15:29:27.000000000","message":"s/``global-requirements.txt`` it/``global-requirements.txt``, it/","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9db49e0b66b6e3c0a4ad8645044188d5b562e92b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  Everyone likes everyone else to use the latest version of their"},{"line_number":179,"context_line":"  code, however deployers really don\u0027t like to be constantly updating"},{"line_number":180,"context_line":"  things. Unless it\u0027s actually **impossible** to use the minimum"},{"line_number":181,"context_line":"  version specified in ``global-requirements.txt`` it should not be"},{"line_number":182,"context_line":"  changed."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  Leave that decision to deployers and distros."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_985e6ce8","line":181,"in_reply_to":"1abeadc6_e79c2560","updated":"2014-08-26 16:34:25.000000000","message":"Done","commit_id":"ff8327fed7cd30a728cd85d6719a39afe9def073"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"During the Havana release cycle we kept running into coherency issues"},{"line_number":8,"context_line":"with trying to install all the OpenStack components into a single"},{"line_number":9,"context_line":"environment. The issue is that syncing of requirements.txt between"},{"line_number":10,"context_line":"projects was an eventually consistent problem. Some projects would"},{"line_number":11,"context_line":"update quickly, others would not. We\u0027d never have the same versions"},{"line_number":12,"context_line":"specified as requirements between packages."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_d64ef0c1","line":9,"updated":"2014-08-26 20:00:18.000000000","message":"``requirements.txt`` (for consistency)","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":16,"context_line":"system. If you don\u0027t you can easily break all of OpenStack on a"},{"line_number":17,"context_line":"requirements update."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"An example of how bad this had gotten is that python keystoneclient"},{"line_number":20,"context_line":"would typically be installed / uninstalled 6 times during the course"},{"line_number":21,"context_line":"of a devstack gate run during Havana. If the last version of python"},{"line_number":22,"context_line":"keystoneclient happened to be incompatible with some piece of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_d68350a7","line":19,"updated":"2014-08-26 20:00:18.000000000","message":"s/python keystoneclient/python-keystoneclient/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":25,"context_line":"We also had an issue with projects adding dependencies of python"},{"line_number":26,"context_line":"libraries without thinking through the long term implications of those"},{"line_number":27,"context_line":"libraries. Is the library actively maintained? Is the library of a"},{"line_number":28,"context_line":"compatible license? Does the library duplicate function of existing"},{"line_number":29,"context_line":"libraries that we already have in requirements? Is the library python"},{"line_number":30,"context_line":"3 compatible? Is the library something that already exists in Linux"},{"line_number":31,"context_line":"Distros that we target (Ubuntu / Fedora). The answer to many of these"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_d6d510b8","line":28,"updated":"2014-08-26 20:00:18.000000000","message":"s/duplicate function/duplicate the function/\n\nMinor change to make this sentence track a little better…","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":51,"context_line":"versions from ``global-requirements.txt``. This ensures that we will"},{"line_number":52,"context_line":"get a deterministic set of requirements installed in the test system,"},{"line_number":53,"context_line":"and it won\u0027t be a guessing game based on the last piece of software to"},{"line_number":54,"context_line":"install."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Enforcement in Projects"},{"line_number":57,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_56f10069","line":54,"updated":"2014-08-26 20:00:18.000000000","message":"s/to install/to be installed/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":61,"context_line":"job that ensures that they can not change any lines in global"},{"line_number":62,"context_line":"requirements to versions not in ``global-requirements.txt``. It also"},{"line_number":63,"context_line":"ensures that those projects can\u0027t add a requirement that\u0027s not already"},{"line_number":64,"context_line":"in ``global-requirements.txt``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Automatic Sync of Accepted Requirements"},{"line_number":67,"context_line":"---------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_f6fbec44","line":64,"updated":"2014-08-26 20:00:18.000000000","message":"It occurs to me that it might be worthwhile to at least point to a wiki page documenting the steps necessary to create such a test job…","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":69,"context_line":"If an updated requirement is proposed to OpenStack and accepted to"},{"line_number":70,"context_line":"``global-requirements.txt``, the system then also automatically pushes"},{"line_number":71,"context_line":"a review request for the new requirements definition to the projects"},{"line_number":72,"context_line":"that included it."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"For instance: if a review is accepted to global-requirements that"},{"line_number":75,"context_line":"increases the minimum version of python-keystoneclient, the system"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_5698201b","line":72,"updated":"2014-08-26 20:00:18.000000000","message":"s/included/include/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":71,"context_line":"a review request for the new requirements definition to the projects"},{"line_number":72,"context_line":"that included it."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"For instance: if a review is accepted to global-requirements that"},{"line_number":75,"context_line":"increases the minimum version of python-keystoneclient, the system"},{"line_number":76,"context_line":"will submit patches to all the OpenStack projects that list"},{"line_number":77,"context_line":"python-keystoneclient as a requirement or test requirement to match"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_96a2b849","line":74,"updated":"2014-08-26 20:00:18.000000000","message":"s/global-requirements/``global-requirements.txt``/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Running"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"To use this, run:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  python update.py path/to/project"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_b6afb42a","line":87,"updated":"2014-08-26 20:00:18.000000000","message":"You know, \"this\" is ambiguous here.  I\u0027d suggest changing the paragraph to read something like:\n\n    To run the requirements update manually, run::\n\nAlso, a double-colon seems to be indicated here…","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"There are a set of questions that every reviewer should ask on any"},{"line_number":100,"context_line":"proposed requirements change (and one that proposers should pre answer"},{"line_number":101,"context_line":"to make things go smoother)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"General Review Criteria"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_3663a41b","line":100,"updated":"2014-08-26 20:00:18.000000000","message":"s/one/ones/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":103,"context_line":"General Review Criteria"},{"line_number":104,"context_line":"-----------------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- No libraries should contain version caps"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  As a community we value early feedback of broken upstream"},{"line_number":109,"context_line":"  requirements, so version caps should be avoided except when dealing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_766d1c04","line":106,"updated":"2014-08-26 20:00:18.000000000","message":"Maybe s/libraries/specifications/ ?","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  Exceptionally unstable libraries should also be considered something"},{"line_number":113,"context_line":"  we want to replace over time with ones that aren\u0027t, or to push"},{"line_number":114,"context_line":"  patches to the upstream community to help them become more stable."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Libraries should contain a sensible known working minimum"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_963e38d9","line":114,"updated":"2014-08-26 20:00:18.000000000","message":"I think this might track better if it were written as:\n\n    If a library is exceptionally unstable, we should also be considering\n    whether we want to replace it over time with one that *is* stable, or\n    to contribute to the upstream community to help stabilize it.","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  we want to replace over time with ones that aren\u0027t, or to push"},{"line_number":114,"context_line":"  patches to the upstream community to help them become more stable."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Libraries should contain a sensible known working minimum"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  Bare library names are bad. If it\u0027s unknown what a working minimum"},{"line_number":119,"context_line":"  is, look at the output of pip freeze at the end of a successful"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_36180484","line":116,"updated":"2014-08-26 20:00:18.000000000","message":"s/minimum/minimum version/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  And preferably comments about what feature / blueprint requires this"},{"line_number":126,"context_line":"  new library to be added. Ideally the proposed code is up already in"},{"line_number":127,"context_line":"  the projects so that it\u0027s use can be seen."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"For new Requirements"},{"line_number":130,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_41293c88","line":127,"updated":"2014-08-26 20:00:18.000000000","message":"- Commit message should refer to consuming project(s)\n\n    Preferably, the comments should also identify which feature or\n    blueprint requires the new specification.  Ideally, changes should\n    already be proposed, so that its use can be seen.\n\nAt a minimum, s/it\u0027s/its/; \"it\u0027s\" is the contraction for \"it is\", while \"its\" is the possessive form of \"it\".","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  By adding something to OpenStack ``global-requirements.txt`` we are"},{"line_number":164,"context_line":"  basically demanding that Linux Distros package this for the next"},{"line_number":165,"context_line":"  release of OpenStack. If they already have, great. If not, we should"},{"line_number":166,"context_line":"  be cautious adding it. :ref:`finding-distro-status`"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- Is the function of this library already covered by other libraries"},{"line_number":169,"context_line":"  in global-requirements?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_012f4489","line":166,"updated":"2014-08-26 20:00:18.000000000","message":"s/cautious adding/cautious of adding/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  be cautious adding it. :ref:`finding-distro-status`"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- Is the function of this library already covered by other libraries"},{"line_number":169,"context_line":"  in global-requirements?"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  Everyone has their own pet libraries they like to use, but we do not"},{"line_number":172,"context_line":"  need 3 different request mocking libraries in OpenStack."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_61571803","line":169,"updated":"2014-08-26 20:00:18.000000000","message":"s/global-requirements/``global-requirements.txt``/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":168,"context_line":"- Is the function of this library already covered by other libraries"},{"line_number":169,"context_line":"  in global-requirements?"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  Everyone has their own pet libraries they like to use, but we do not"},{"line_number":172,"context_line":"  need 3 different request mocking libraries in OpenStack."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  If this new requirement is about replacing an existing library with"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_0146644f","line":171,"updated":"2014-08-26 20:00:18.000000000","message":"s/libraries they/libraries that they/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"ddece0892cacd3944c2baa5c8ac0dd21d4b4a9a2","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  one that\u0027s better suited for our needs, then we also need the"},{"line_number":176,"context_line":"  transition plan to drop the old library in a reasonable amount of"},{"line_number":177,"context_line":"  time."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"For Upgrading Requirements Versions"},{"line_number":180,"context_line":"-----------------------------------"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_e383e353","line":178,"updated":"2014-08-28 11:49:57.000000000","message":"Another suggestions \"check whether you can find the upstream\", just having a entry on pypi.python.org isn\u0027t enough i.e. where to we send patches too if needed?","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7d66178515a02cd795af80f84375909db455bf66","unresolved":false,"context_lines":[{"line_number":182,"context_line":"- Why is it impossible to use the current version definition?"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  Everyone likes everyone else to use the latest version of their"},{"line_number":185,"context_line":"  code, however deployers really don\u0027t like to be constantly updating"},{"line_number":186,"context_line":"  things. Unless it\u0027s actually **impossible** to use the minimum"},{"line_number":187,"context_line":"  version specified in ``global-requirements.txt``, it should not be"},{"line_number":188,"context_line":"  changed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_616e38cb","line":185,"updated":"2014-08-26 20:00:18.000000000","message":"s/code, however deployers/code; however, deployers/","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1d65d7bcebb462e5ee5af66f089e8b5285391560","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"The OpenStack distro support policy is that new software should be"},{"line_number":198,"context_line":"written to support the latest Ubuntu and Fedora releases, with support"},{"line_number":199,"context_line":"of the last LTS of those distros a bonus.  We would also like to"},{"line_number":200,"context_line":"ensure that there is not too much pain for the Debian and SuSE"},{"line_number":201,"context_line":"communities."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa98f980_d966c0ec","line":199,"updated":"2014-09-03 21:40:05.000000000","message":"Actually the policy is:\n\n  OpenStack will target its development efforts to latest Ubuntu/Fedora,\n  but will not introduce any changes that would make it\n  impossible to run on the latest Ubuntu LTS or latest RHEL.\n\nSo it\u0027s a bit stronger than \"a bonus\".  I\u0027d recommend just going with the TC-approved text.","commit_id":"f1825f376082950921ce4a242bcc7722e91eb12a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92c593ee2b203f0905a808e4e6c3f4e023c8fe2f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"a review request for the new requirements definition to the projects"},{"line_number":73,"context_line":"that include it."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"For instance: if a review is accepted to ``global-requirements`` that"},{"line_number":76,"context_line":"increases the minimum version of python-keystoneclient, the system"},{"line_number":77,"context_line":"will submit patches to all the OpenStack projects that list"},{"line_number":78,"context_line":"python-keystoneclient as a requirement or test requirement to match"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9df570_dc028c6e","line":75,"updated":"2014-09-23 18:27:13.000000000","message":"s/``global-requirements``/``global-requirements.txt``/","commit_id":"ad03a3d99314adc35ec8482eddf9a9adcbe7f31e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92c593ee2b203f0905a808e4e6c3f4e023c8fe2f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  be cautious of adding it. :ref:`finding-distro-status`"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- Is the function of this library already covered by other libraries"},{"line_number":171,"context_line":"  in ``global-requirements``?"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  Everyone has their own pet libraries that they like to use, but we"},{"line_number":174,"context_line":"  do not need 3 different request mocking libraries in OpenStack."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9df570_7c7a80f2","line":171,"updated":"2014-09-23 18:27:13.000000000","message":"s/``global-requirements``/``global-requirements.txt``/","commit_id":"ad03a3d99314adc35ec8482eddf9a9adcbe7f31e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92c593ee2b203f0905a808e4e6c3f4e023c8fe2f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"but will not introduce any changes that would make it impossible to"},{"line_number":203,"context_line":"run on the latest Ubuntu LTS or latest RHEL."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"As such we realy need to know what the current state of packaging is"},{"line_number":206,"context_line":"on these platforms (and ideally Debian and SuSE as well)."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"For people unfamiliar with Linux Distro packaging you can use the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9df570_3c4f18bf","line":205,"updated":"2014-09-23 18:27:13.000000000","message":"s/realy/really/","commit_id":"ad03a3d99314adc35ec8482eddf9a9adcbe7f31e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"40d40bb5e5a564fa5af90cdc501238a146c0bca2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  in ``global-requirements.txt``?"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  Everyone has their own pet libraries that they like to use, but we"},{"line_number":174,"context_line":"  do not need 3 different request mocking libraries in OpenStack."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"  If this new requirement is about replacing an existing library with"},{"line_number":177,"context_line":"  one that\u0027s better suited for our needs, then we also need the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da9df570_9708df92","line":174,"updated":"2014-09-23 18:49:24.000000000","message":"nit: spell out \"three\"","commit_id":"12d999e49c5bf548b4988a1d94d53303fa104442"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"40d40bb5e5a564fa5af90cdc501238a146c0bca2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"run on the latest Ubuntu LTS or latest RHEL."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"As such we really need to know what the current state of packaging is"},{"line_number":206,"context_line":"on these platforms (and ideally Debian and SuSE as well)."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"For people unfamiliar with Linux Distro packaging you can use the"},{"line_number":209,"context_line":"following tools to search for packages:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da9df570_3777333c","line":206,"updated":"2014-09-23 18:49:24.000000000","message":"Could you use the correct capitalization \"SUSE\", please?","commit_id":"12d999e49c5bf548b4988a1d94d53303fa104442"}]}